[PR] YARN-11623 FairScheduler: Add AM preemption to documentation [hadoop]

2023-12-03 Thread via GitHub
singer-bin opened a new pull request, #6320: URL: https://github.com/apache/hadoop/pull/6320 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADO

Re: [PR] YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues. [hadoop]

2023-12-03 Thread via GitHub
hadoop-yetus commented on PR #6295: URL: https://github.com/apache/hadoop/pull/6295#issuecomment-1837798797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-16749. RBF: Gets the wrong directory information from Trash [hadoop]

2023-12-03 Thread via GitHub
zhangxiping1 commented on PR #6317: URL: https://github.com/apache/hadoop/pull/6317#issuecomment-1837794522 > @zhangxiping1 I see that you created [HDFS-16749](https://issues.apache.org/jira/browse/HDFS-16749), pr #5039, and @LiuGuH also submitted a PR. Can we compare and explain the differ

Re: [PR] HDFS-17254. DataNode httpServer has too many worker threads [hadoop]

2023-12-03 Thread via GitHub
hadoop-yetus commented on PR #6307: URL: https://github.com/apache/hadoop/pull/6307#issuecomment-1837593823 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17250. EditLogTailer#triggerActiveLogRoll should handle thread Interrupted [hadoop]

2023-12-03 Thread via GitHub
xinglin commented on PR #6266: URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1837558511 @Hexiaoqiao, no, feel free to merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-03 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1413157796 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1348,7 +1363,7 @@ class ReplicationStats exte

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2023-12-03 Thread via GitHub
bbeaudreault commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1837536440 Hi @Neilxzn , any chance you have time to finish this up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Comment Edited] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-03 Thread Zilong Zhu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792541#comment-17792541 ] Zilong Zhu edited comment on HADOOP-19001 at 12/3/23 3:30 PM: ---

[jira] [Commented] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-03 Thread Zilong Zhu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792541#comment-17792541 ] Zilong Zhu commented on HADOOP-19001: - About hadoop-functions.sh, the Hadoop3 scrip

Re: [PR] YARN-11621: Fix intermittently failing unit test: TestAMRMProxy.testAMRMProxyTokenRenewal [hadoop]

2023-12-03 Thread via GitHub
susheelgupta7 commented on code in PR #6310: URL: https://github.com/apache/hadoop/pull/6310#discussion_r1413125808 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMProxy.java: ## @@ -156,13 +156,13 @@ public void

Re: [PR] HDFS-17270: Fix ZKDelegationTokenSecretManagerImpl use closed zookeep… [hadoop]

2023-12-03 Thread via GitHub
hadoop-yetus commented on PR #6315: URL: https://github.com/apache/hadoop/pull/6315#issuecomment-1837484342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17254. DataNode httpServer has too many worker threads [hadoop]

2023-12-03 Thread via GitHub
2005hithlj commented on PR #6307: URL: https://github.com/apache/hadoop/pull/6307#issuecomment-1837476668 @Hexiaoqiao sir. Thank you for your review, it caused by enable http UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDFS-17254. DataNode httpServer has too many worker threads [hadoop]

2023-12-03 Thread via GitHub
2005hithlj commented on code in PR #6307: URL: https://github.com/apache/hadoop/pull/6307#discussion_r1413075732 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -966,6 +966,9 @@ public class DFSConfigKeys extends CommonConfigurat

Re: [PR] HDFS-17247. Improve AvailableSpaceRackFaultTolerantBlockPlacementPolicy logic [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on PR #6245: URL: https://github.com/apache/hadoop/pull/6245#issuecomment-1837453787 Thanks involve me here and sorry to be late. I will try to review it next week. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] HDFS-17250. EditLogTailer#triggerActiveLogRoll should handle thread Interrupted [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on PR #6266: URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1837453460 Hi @xinglin Do you have anymore concerns? If not, I will to push this RP forwards. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on code in PR #6290: URL: https://github.com/apache/hadoop/pull/6290#discussion_r1413054649 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java: ## @@ -1970,16 +1971,32 @@ public static boolean isParentEntry(final String path

[jira] [Commented] (HADOOP-18982) Fix doc about loading native libraries

2023-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792514#comment-17792514 ] ASF GitHub Bot commented on HADOOP-18982: - Hexiaoqiao commented on code in PR #

Re: [PR] HADOOP-18982. Fix doc about loading native libraries. [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on code in PR #6281: URL: https://github.com/apache/hadoop/pull/6281#discussion_r1413053871 ## hadoop-common-project/hadoop-common/src/site/markdown/NativeLibraries.md.vm: ## @@ -128,8 +128,8 @@ You can load any native shared library using DistributedCache

Re: [PR] HDFS-17254. DataNode httpServer has too many worker threads [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on PR #6307: URL: https://github.com/apache/hadoop/pull/6307#issuecomment-1837448346 @2005hithlj Thanks. Is it caused by enable webhdfs or http UI or some other reasons? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] HDFS-16749. RBF: Gets the wrong directory information from Trash [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on PR #6317: URL: https://github.com/apache/hadoop/pull/6317#issuecomment-1837447770 Thanks @LiuGuH for your works. > (4) client via DFSRouter: hdfs dfs -ls /user/test-user/.Trash/Current ,this will return I am confused why it returns wrong subdirs now? Tha

Re: [PR] HDFS-17270: Fix ZKDelegationTokenSecretManagerImpl use closed zookeep… [hadoop]

2023-12-03 Thread via GitHub
Hexiaoqiao commented on PR #6315: URL: https://github.com/apache/hadoop/pull/6315#issuecomment-1837445457 @ThinkerLei Thanks for your work. Try to trigger CI manually, Let's wait what it will say. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] YARN-11561. [Federation] GPG Supports Format PolicyStateStore. [hadoop]

2023-12-03 Thread via GitHub
slfan1989 commented on PR #6300: URL: https://github.com/apache/hadoop/pull/6300#issuecomment-1837438799 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] YARN-11561. [Federation] GPG Supports Format PolicyStateStore. [hadoop]

2023-12-03 Thread via GitHub
slfan1989 merged PR #6300: URL: https://github.com/apache/hadoop/pull/6300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode. [hadoop]

2023-12-03 Thread via GitHub
ayushtkn merged PR #6279: URL: https://github.com/apache/hadoop/pull/6279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado