Re: [PR] HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 [hadoop]

2023-12-17 Thread via GitHub
ayushtkn commented on code in PR #6296: URL: https://github.com/apache/hadoop/pull/6296#discussion_r1429596566 ## LICENSE-binary: ## @@ -337,7 +337,7 @@ org.apache.kerby:kerby-xdr:2.0.3 org.apache.kerby:token-provider:2.0.3 org.apache.solr:solr-solrj:8.11.2 org.apache.yetus:a

Re: [PR] HDFS-17289. Considering the size of non-lastBlocks equals to complete block size can cause append failure. [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6357: URL: https://github.com/apache/hadoop/pull/6357#issuecomment-1859685086 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17289. Considering the size of non-lastBlocks equals to complete block size can cause append failure. [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6357: URL: https://github.com/apache/hadoop/pull/6357#issuecomment-1859679217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17293. First packet data + checksum size will be set to 516 bytes when writing to a new block. [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6368: URL: https://github.com/apache/hadoop/pull/6368#issuecomment-1859520554 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 [hadoop]

2023-12-17 Thread via GitHub
BilwaST commented on PR #6296: URL: https://github.com/apache/hadoop/pull/6296#issuecomment-1859498825 @ayushtkn Testcases are random failures. I ran TestBalancerWithHANameNodes locally and it passes -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] test for triggling yetus [hadoop]

2023-12-17 Thread via GitHub
hfutatzhanghb closed pull request #6365: test for triggling yetus URL: https://github.com/apache/hadoop/pull/6365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] HDFS-17293. First packet data + checksum size will be set to 516 bytes when writing to a new block. [hadoop]

2023-12-17 Thread via GitHub
hfutatzhanghb commented on PR #6368: URL: https://github.com/apache/hadoop/pull/6368#issuecomment-1859452294 @Hexiaoqiao @tomscut @ayushtkn @zhangshuyan0 Sir, could you please help me review this code when you have free time?Thanks ahead. -- This is an automated message from the Apache Gi

[PR] HDFS-17293. First packet data + checksum size will be set to 516 bytes when writing to a new block. [hadoop]

2023-12-17 Thread via GitHub
hfutatzhanghb opened a new pull request, #6368: URL: https://github.com/apache/hadoop/pull/6368 ### Description of PR First packet size(data length + checksum length) will be set to 516 bytes when writing to a new block. In method computePacketChunkSize, the parameters psize and c

Re: [PR] HDFS-17289. Considering the size of non-lastBlocks equals to complete block size can cause append failure. [hadoop]

2023-12-17 Thread via GitHub
hfutatzhanghb commented on PR #6357: URL: https://github.com/apache/hadoop/pull/6357#issuecomment-1859431890 @Hexiaoqiao @zhangshuyan0 @huangzhaobo99 @haiyang1987 @tomscut Have added an UT to reproduce it. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HDFS-17294. Reconfigure the scheduling cycle of the slowPeerCollectorDaemon thread. [hadoop]

2023-12-17 Thread via GitHub
huangzhaobo99 commented on PR #6366: URL: https://github.com/apache/hadoop/pull/6366#issuecomment-1859370420 Hi @ayushtkn @haiyang1987, Please help review this pr when you are available, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.3

2023-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797976#comment-17797976 ] ASF GitHub Bot commented on HADOOP-18613: - hadoop-yetus commented on PR #6296:

Re: [PR] HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6296: URL: https://github.com/apache/hadoop/pull/6296#issuecomment-1859313932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17289. Should not consider the size of non-lastBlocks equals to complete block size. [hadoop]

2023-12-17 Thread via GitHub
huangzhaobo99 commented on PR #6357: URL: https://github.com/apache/hadoop/pull/6357#issuecomment-1859193373 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] HDFS-17294. Reconfigure the scheduling cycle of the slowPeerCollectorDaemon thread. [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6366: URL: https://github.com/apache/hadoop/pull/6366#issuecomment-1859189801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797928#comment-17797928 ] ASF GitHub Bot commented on HADOOP-19001: - hadoop-yetus commented on PR #6367:

Re: [PR] HADOOP-19001. LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6367: URL: https://github.com/apache/hadoop/pull/6367#issuecomment-1859184739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797918#comment-17797918 ] ASF GitHub Bot commented on HADOOP-19001: - iwasakims commented on code in PR #6

Re: [PR] HADOOP-19001. LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR [hadoop]

2023-12-17 Thread via GitHub
iwasakims commented on code in PR #6367: URL: https://github.com/apache/hadoop/pull/6367#discussion_r1429147629 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -1309,7 +1309,7 @@ Environment variables that containers may

[jira] [Updated] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19001: Labels: pull-request-available (was: ) > LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NA

Re: [PR] HADOOP-19001. LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR [hadoop]

2023-12-17 Thread via GitHub
iwasakims commented on PR #6367: URL: https://github.com/apache/hadoop/pull/6367#issuecomment-1859160072 @zhuzilong2013 I think you can use [hadoop_add_ldlibpath](https://github.com/apache/hadoop/blob/rel/release-3.2.4/hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.

[jira] [Commented] (HADOOP-19001) LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR

2023-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797917#comment-17797917 ] ASF GitHub Bot commented on HADOOP-19001: - iwasakims commented on PR #6367: URL

[PR] LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR [hadoop]

2023-12-17 Thread via GitHub
zhuzilong2013 opened a new pull request, #6367: URL: https://github.com/apache/hadoop/pull/6367 Description of PR LD_LIBRARY_PATH is missing HADOOP_COMMON_LIB_NATIVE_DIR JIRA: [HADOOP-19001](https://issues.apache.org/jira/browse/HADOOP-19001) How was this patch tested?

Re: [PR] HDFS-17294. Reconfigure the scheduling cycle of the slowPeerCollectorDaemon thread. [hadoop]

2023-12-17 Thread via GitHub
hadoop-yetus commented on PR #6366: URL: https://github.com/apache/hadoop/pull/6366#issuecomment-1859089671 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18986) Upgrade Zookeeper to 3.8.2

2023-12-17 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilwa S T resolved HADOOP-18986. Resolution: Duplicate > Upgrade Zookeeper to 3.8.2 > -- > >

[jira] [Updated] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.3

2023-12-17 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilwa S T updated HADOOP-18613: --- Summary: Upgrade ZooKeeper to version 3.8.3 (was: Upgrade ZooKeeper to version 3.8.2) > Upgrade Z

[jira] [Commented] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.2

2023-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797902#comment-17797902 ] ASF GitHub Bot commented on HADOOP-18613: - BilwaST commented on PR #6296: URL:

Re: [PR] HADOOP-18613. Upgrade ZooKeeper to version 3.8.2 and Curator to versi… [hadoop]

2023-12-17 Thread via GitHub
BilwaST commented on PR #6296: URL: https://github.com/apache/hadoop/pull/6296#issuecomment-1859083647 > Rethinking: Why are we not moving to 3.8.3? Earlier when i had checked, the latest stable version was 3.8.2. Looks like 3.8.3 is stable too. I will update the patch -- This is a