Re: [PR] HDFS-17317. DebugAdmin metaOut not need multiple close [hadoop]

2024-01-05 Thread via GitHub
xuzifu666 commented on PR #6402: URL: https://github.com/apache/hadoop/pull/6402#issuecomment-1879586686 @ayushtkn Hi, how about recircle result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17302. RBF: ProportionRouterRpcFairnessPolicyController-Sharing and isolation. [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6380: URL: https://github.com/apache/hadoop/pull/6380#issuecomment-1879579502 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11642. Fix Flaky Test TestTimelineAuthFilterForV2#testPutTimelineEntities. [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6417: URL: https://github.com/apache/hadoop/pull/6417#issuecomment-1879572817 @ayushtkn Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] YARN-11634. [Addendum] Speed-up TestTimelineClient. [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6419: URL: https://github.com/apache/hadoop/pull/6419#issuecomment-1879571378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11642. Fix Flaky Test TestTimelineAuthFilterForV2#testPutTimelineEntities. [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6417: URL: https://github.com/apache/hadoop/pull/6417#issuecomment-1879569732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Preparing for 3.5.0 development [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6411: URL: https://github.com/apache/hadoop/pull/6411#issuecomment-1879561986 Spotbugs Report shows 2 Spotbugs: 1. The first one is caused by YARN-11634(#6371), and I have submitted a PR to fix it. ``` Code Warning MS

Re: [PR] HDFS-17326. Fix NameNode Spotbug. [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6420: URL: https://github.com/apache/hadoop/pull/6420#issuecomment-1879561355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17326. Fix NameNode Spotbugs. [hadoop]

2024-01-05 Thread via GitHub
slfan1989 opened a new pull request, #6420: URL: https://github.com/apache/hadoop/pull/6420 ### Description of PR JIRA: HDFS-17326. Fix NameNode Spotbugs. While preparing for 3.5.0 development, the report showed that there was a sputbug in NameNode. [SpotBugs

[jira] [Commented] (HADOOP-19029) Migrate abstract permission tests to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803756#comment-17803756 ] ASF GitHub Bot commented on HADOOP-19029: - slfan1989 commented on PR #6418: URL:

Re: [PR] HADOOP-19029. Migrate abstract permission tests to AssertJ [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6418: URL: https://github.com/apache/hadoop/pull/6418#issuecomment-1879554146 @huangzhaobo99 Thank you for your attention to the upgrade of unit tests, but we cannot modify them one by one like this. I plan to initiate a discussion over time to upgrade unit tests

Re: [PR] YARN-11634. [Addendum] Speed-up TestTimelineClient. [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6419: URL: https://github.com/apache/hadoop/pull/6419#issuecomment-1879552862 @brumi1024 @K0K0V0K In #6371, we introduced a sputbug. I tried to modify the code, can you help review this PR? Thank you very much!

[PR] YARN-11634. [Addendum] Speed-up TestTimelineClient. [hadoop]

2024-01-05 Thread via GitHub
slfan1989 opened a new pull request, #6419: URL: https://github.com/apache/hadoop/pull/6419 ### Description of PR JIRA: YARN-11634. [Addendum] Speed-up TestTimelineClient. ### How was this patch tested? ### For code changes: - [ ] Does the title or

[jira] [Commented] (HADOOP-19029) Migrate abstract permission tests to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803753#comment-17803753 ] ASF GitHub Bot commented on HADOOP-19029: - huangzhaobo99 opened a new pull request, #6418: URL:

[jira] [Updated] (HADOOP-19029) Migrate abstract permission tests to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19029: Labels: pull-request-available (was: ) > Migrate abstract permission tests to AssertJ >

[PR] HADOOP-19029. Migrate abstract permission tests to AssertJ [hadoop]

2024-01-05 Thread via GitHub
huangzhaobo99 opened a new pull request, #6418: URL: https://github.com/apache/hadoop/pull/6418 ### Description of PR JIRA: https://issues.apache.org/jira/browse/HADOOP-19029 ### How was this patch tested? -- This is an automated message from the Apache Git Service.

Re: [PR] Preparing for 3.5.0 development [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6411: URL: https://github.com/apache/hadoop/pull/6411#issuecomment-1879545671 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17302. RBF: ProportionRouterRpcFairnessPolicyController-Sharing and isolation. [hadoop]

2024-01-05 Thread via GitHub
KeeProMise commented on code in PR #6380: URL: https://github.com/apache/hadoop/pull/6380#discussion_r1443614558 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/fairness/TestRouterHandlersFairness.java: ## @@ -308,4 +375,28 @@

Re: [PR] HDFS-17302. RBF: ProportionRouterRpcFairnessPolicyController-Sharing and isolation. [hadoop]

2024-01-05 Thread via GitHub
KeeProMise commented on code in PR #6380: URL: https://github.com/apache/hadoop/pull/6380#discussion_r1443614602 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java: ## @@ -0,0

Re: [PR] YARN-11631. [GPG] Add GPGWebServices. [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6354: URL: https://github.com/apache/hadoop/pull/6354#issuecomment-1879544980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11642. Fix Flaky Test TestTimelineAuthFilterForV2#testPutTimelineEntities. [hadoop]

2024-01-05 Thread via GitHub
slfan1989 opened a new pull request, #6417: URL: https://github.com/apache/hadoop/pull/6417 ### Description of PR JIRA: Fix Flaky Test TestTimelineAuthFilterForV2#testPutTimelineEntities. ### How was this patch tested? ### For code changes: - [ ] Does

[jira] [Commented] (HADOOP-19024) change to bouncy castle jdk1.8 jars

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803740#comment-17803740 ] ASF GitHub Bot commented on HADOOP-19024: - slfan1989 commented on PR #6410: URL:

Re: [PR] HADOOP-19024. Use bouncycastle jdk18 1.77 [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6410: URL: https://github.com/apache/hadoop/pull/6410#issuecomment-1879513161 @pjfanning Thank you for your contribution! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (HADOOP-19029) Migrate abstract permission tests to AssertJ

2024-01-05 Thread huangzhaobo (Jira)
huangzhaobo created HADOOP-19029: Summary: Migrate abstract permission tests to AssertJ Key: HADOOP-19029 URL: https://issues.apache.org/jira/browse/HADOOP-19029 Project: Hadoop Common Issue

[jira] [Commented] (HADOOP-19025) Migrate abstract contract tests to AssertJ

2024-01-05 Thread huangzhaobo (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803739#comment-17803739 ] huangzhaobo commented on HADOOP-19025: -- Thanks [~adoroszlai], I happen to be learning about ACL,

[jira] [Commented] (HADOOP-19025) Migrate abstract contract tests to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803714#comment-17803714 ] ASF GitHub Bot commented on HADOOP-19025: - adoroszlai commented on PR #6415: URL:

Re: [PR] HADOOP-19025. Migrate contract tests in hadoop-common to AssertJ [hadoop]

2024-01-05 Thread via GitHub
adoroszlai commented on PR #6415: URL: https://github.com/apache/hadoop/pull/6415#issuecomment-1879318637 Test failures in Jenkins run are unrelated: ``` [ERROR] Errors: [ERROR] org.apache.hadoop.security.TestRaceWhenRelogin.test(org.apache.hadoop.security.TestRaceWhenRelogin)

[jira] [Commented] (HADOOP-18883) Expect-100 JDK bug resolution: prevent multiple server calls

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803712#comment-17803712 ] ASF GitHub Bot commented on HADOOP-18883: - mukund-thakur commented on code in PR #6022: URL:

Re: [PR] HADOOP-18883. [ABFS]: Expect-100 JDK bug resolution: prevent multiple server calls [hadoop]

2024-01-05 Thread via GitHub
mukund-thakur commented on code in PR #6022: URL: https://github.com/apache/hadoop/pull/6022#discussion_r1443402179 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java: ## @@ -340,8 +344,11 @@ public void sendRequest(byte[]

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1879299355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18883) Expect-100 JDK bug resolution: prevent multiple server calls

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803710#comment-17803710 ] ASF GitHub Bot commented on HADOOP-18883: - mukund-thakur commented on code in PR #6022: URL:

Re: [PR] HADOOP-18883. [ABFS]: Expect-100 JDK bug resolution: prevent multiple server calls [hadoop]

2024-01-05 Thread via GitHub
mukund-thakur commented on code in PR #6022: URL: https://github.com/apache/hadoop/pull/6022#discussion_r1443395651 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java: ## @@ -324,14 +328,26 @@ public void sendRequest(byte[]

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803708#comment-17803708 ] ASF GitHub Bot commented on HADOOP-13147: - hadoop-yetus commented on PR #6408: URL:

Re: [PR] HADOOP-13147 - Constructors must not call overrideable methods [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6408: URL: https://github.com/apache/hadoop/pull/6408#issuecomment-1879269064 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19025) Migrate abstract contract tests to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803705#comment-17803705 ] ASF GitHub Bot commented on HADOOP-19025: - hadoop-yetus commented on PR #6415: URL:

Re: [PR] HADOOP-19025. Migrate contract tests in hadoop-common to AssertJ [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6415: URL: https://github.com/apache/hadoop/pull/6415#issuecomment-1879251962 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19014) use jsr311-compat jar to allow us to use Jackson 2.14.3

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803704#comment-17803704 ] ASF GitHub Bot commented on HADOOP-19014: - pjfanning opened a new pull request, #6416: URL:

[PR] HADOOP-19014. Upgrade to Jackson 2.14.3. [hadoop]

2024-01-05 Thread via GitHub
pjfanning opened a new pull request, #6416: URL: https://github.com/apache/hadoop/pull/6416 ### Description of PR Alternative to #6370. jersey-json 1.21.0 has a transitive dependency on the jsr311-compat jar. ### How was this patch tested? ### For code changes:

[jira] [Commented] (HADOOP-18975) AWS SDK v2: extend support for FIPS endpoints

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803690#comment-17803690 ] ASF GitHub Bot commented on HADOOP-18975: - hadoop-yetus commented on PR #6277: URL:

Re: [PR] HADOOP-18975. AWS SDK v2: extend support for FIPS endpoints [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6277: URL: https://github.com/apache/hadoop/pull/6277#issuecomment-1879179572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19025) Migrate abstract contract tests to AssertJ

2024-01-05 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HADOOP-19025: -- Summary: Migrate abstract contract tests to AssertJ (was: Migrate ContractTestUtils

[jira] [Created] (HADOOP-19028) Bind abstract contract tests into JUnit5 lifecycle

2024-01-05 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HADOOP-19028: - Summary: Bind abstract contract tests into JUnit5 lifecycle Key: HADOOP-19028 URL: https://issues.apache.org/jira/browse/HADOOP-19028 Project: Hadoop Common

[jira] [Commented] (HADOOP-19025) Migrate ContractTestUtils to AssertJ

2024-01-05 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803662#comment-17803662 ] Attila Doroszlai commented on HADOOP-19025: --- [~huangzhaobo99], the first PR updates classes

[jira] [Commented] (HADOOP-19027) S3A: S3AInputStream doesn't recover from HTTP exceptions

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803659#comment-17803659 ] Steve Loughran commented on HADOOP-19027: - The retry logic in S3AInputStream only seems to

[jira] [Commented] (HADOOP-19027) S3A: S3AInputStream doesn't recover from HTTP exceptions

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803654#comment-17803654 ] Steve Loughran commented on HADOOP-19027: - full stack trace {code}

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803652#comment-17803652 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144: URL:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1879075825 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19027) S3A: S3AInputStream doesn't recover from HTTP exceptions

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803649#comment-17803649 ] Steve Loughran commented on HADOOP-19027: - openssl, "stream is closed" {code} Error while

[jira] [Created] (HADOOP-19027) S3A: S3AInputStream doesn't recover from HTTP exceptions

2024-01-05 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19027: --- Summary: S3A: S3AInputStream doesn't recover from HTTP exceptions Key: HADOOP-19027 URL: https://issues.apache.org/jira/browse/HADOOP-19027 Project: Hadoop

[jira] [Commented] (HADOOP-19025) Migrate ContractTestUtils to AssertJ

2024-01-05 Thread huangzhaobo99 (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803644#comment-17803644 ] huangzhaobo99 commented on HADOOP-19025: [~adoroszlai] Can this task be split into multiple

Re: [PR] HDFS-17324. RBF: Router should not return nameservices that not enable observer r… [hadoop]

2024-01-05 Thread via GitHub
goiri commented on code in PR #6412: URL: https://github.com/apache/hadoop/pull/6412#discussion_r1443127143 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -136,9 +136,9 @@ public class

[jira] [Updated] (HADOOP-19025) Migrate ContractTestUtils to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19025: Labels: pull-request-available (was: ) > Migrate ContractTestUtils to AssertJ >

[jira] [Commented] (HADOOP-19025) Migrate ContractTestUtils to AssertJ

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803631#comment-17803631 ] ASF GitHub Bot commented on HADOOP-19025: - adoroszlai opened a new pull request, #6415: URL:

[PR] HADOOP-19025. Migrate contract tests in hadoop-common to AssertJ [hadoop]

2024-01-05 Thread via GitHub
adoroszlai opened a new pull request, #6415: URL: https://github.com/apache/hadoop/pull/6415 ## What changes were proposed in this pull request? Replace assertions in `ContractTestUtils` and abstract contract tests with `assertThat` from AssertJ, to reduce dependency on JUnit4.

Re: [PR] HDFS-17302. RBF: ProportionRouterRpcFairnessPolicyController-Sharing and isolation. [hadoop]

2024-01-05 Thread via GitHub
goiri commented on code in PR #6380: URL: https://github.com/apache/hadoop/pull/6380#discussion_r1443121381 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/fairness/TestRouterHandlersFairness.java: ## @@ -308,4 +375,28 @@ private

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
huangzhaobo99 commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1878972507 > Thanks for fixing the spotbugs warning and refactor the code, @huangzhaobo99! @tasanuma Thanks for you merge to trunk! -- This is an automated message from the Apache Git

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
tasanuma commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1878968475 Thanks for fixing the spotbugs warning and refactor the code, @huangzhaobo99! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
tasanuma merged PR #6400: URL: https://github.com/apache/hadoop/pull/6400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
tasanuma commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1878966616 The CI results would be the same as https://github.com/apache/hadoop/pull/6400#issuecomment-1873682217. The spotbugs warnings should disappear after this PR is merged. I'm merging it.

Re: [PR] HDFS-17300. [SBN READ] Observer should throw ObserverRetryOnActiveException if stateid is always delayed with Active Namenode for a configured time [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6414: URL: https://github.com/apache/hadoop/pull/6414#issuecomment-1878913920 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18975) AWS SDK v2: extend support for FIPS endpoints

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803588#comment-17803588 ] ASF GitHub Bot commented on HADOOP-18975: - steveloughran commented on code in PR #6277: URL:

Re: [PR] HADOOP-18975. AWS SDK v2: extend support for FIPS endpoints [hadoop]

2024-01-05 Thread via GitHub
steveloughran commented on code in PR #6277: URL: https://github.com/apache/hadoop/pull/6277#discussion_r1443045900 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -165,6 +175,8 @@ private , ClientT> Build

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
huangzhaobo99 commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1878864458 > @huangzhaobo99 Thanks for the PR. It seems that the spotbugs warning is not targeting the latest change. I think there might be an issue with the CI configuration. Let's ignore it

Re: [PR] HDFS-17315. Optimize the namenode format code logic. [hadoop]

2024-01-05 Thread via GitHub
tasanuma commented on PR #6400: URL: https://github.com/apache/hadoop/pull/6400#issuecomment-1878852193 @huangzhaobo99 Thanks for the PR. It seems that the spotbugs warning is not targeting the latest change. I think there might be an issue with the CI configuration. Let's ignore it for

[jira] [Commented] (HADOOP-18830) S3A: Cut S3 Select

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803573#comment-17803573 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran commented on PR #6144: URL:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2024-01-05 Thread via GitHub
steveloughran commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1878842405 rebased pr with retest. failures unrelated; the signing one has an active pr to fix, the committer one looks like my config is at fault (bucket overrides not being cut) ```

[jira] [Commented] (HADOOP-19024) change to bouncy castle jdk1.8 jars

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803571#comment-17803571 ] ASF GitHub Bot commented on HADOOP-19024: - hadoop-yetus commented on PR #6410: URL:

Re: [PR] HADOOP-19024. Use bouncycastle jdk18 1.77 [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6410: URL: https://github.com/apache/hadoop/pull/6410#issuecomment-1878836593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803562#comment-17803562 ] ASF GitHub Bot commented on HADOOP-18708: - steveloughran commented on code in PR #6164: URL:

Re: [PR] HADOOP-18708. AWS SDK V2 - Implement CSE [hadoop]

2024-01-05 Thread via GitHub
steveloughran commented on code in PR #6164: URL: https://github.com/apache/hadoop/pull/6164#discussion_r1442966873 ## hadoop-project/pom.xml: ## @@ -188,6 +188,7 @@ 900 1.12.565 2.20.160 + 3.1.0 Review Comment: so this isn't in the big bundle? what does

[jira] [Updated] (HADOOP-18886) S3A: AWS SDK V2 Migration: stabilization and S3Express

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18886: Description: The final stabilisation changes to the V2 SDK MIgration; those moved off

[jira] [Updated] (HADOOP-18135) Produce Windows binaries of Hadoop

2024-01-05 Thread Gautham Banasandra (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautham Banasandra updated HADOOP-18135: Description: We currently only provide Linux libraries and binaries. We need to

Re: [PR] HDFS-17324. RBF: Router should not return nameservices that not enable observer r… [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6412: URL: https://github.com/apache/hadoop/pull/6412#issuecomment-1878570815 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-1878567308 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19014) use jsr311-compat jar to allow us to use Jackson 2.14.3

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803525#comment-17803525 ] ASF GitHub Bot commented on HADOOP-19014: - pjfanning commented on code in PR #6370: URL:

Re: [PR] HADOOP-19014. Jackson 2.14.3 requiring jsr311-compat [hadoop]

2024-01-05 Thread via GitHub
pjfanning commented on code in PR #6370: URL: https://github.com/apache/hadoop/pull/6370#discussion_r1442799261 ## hadoop-project/pom.xml: ## @@ -921,6 +921,11 @@ + Review Comment: I'll add some comments and recheck the dependency scopes.

[jira] [Commented] (HADOOP-19024) change to bouncy castle jdk1.8 jars

2024-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803523#comment-17803523 ] ASF GitHub Bot commented on HADOOP-19024: - steveloughran commented on PR #6410: URL:

Re: [PR] HADOOP-19024. Use bouncycastle jdk18 1.77 [hadoop]

2024-01-05 Thread via GitHub
steveloughran commented on PR #6410: URL: https://github.com/apache/hadoop/pull/6410#issuecomment-1878553469 I agree that this is needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HADOOP-19014. Jackson 2.14.3 requiring jsr311-compat [hadoop]

2024-01-05 Thread via GitHub
steveloughran commented on PR #6370: URL: https://github.com/apache/hadoop/pull/6370#issuecomment-1878552124 I'm happy with this, just need to understand if there are any problems with it being optional we will need to add in release notes as incompatible and explain the issue and

[jira] [Commented] (HADOOP-19023) ITestS3AConcurrentOps#testParallelRename intermittent timeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803521#comment-17803521 ] Steve Loughran commented on HADOOP-19023: - * make sure you've not got a site config with an

[jira] [Updated] (HADOOP-19023) ITestS3AConcurrentOps#testParallelRename intermittent timeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19023: Component/s: fs/s3 > ITestS3AConcurrentOps#testParallelRename intermittent timeout

[jira] [Updated] (HADOOP-19023) ITestS3AConcurrentOps#testParallelRename intermittent timeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19023: Affects Version/s: 3.4.0 > ITestS3AConcurrentOps#testParallelRename intermittent timeout

[jira] [Updated] (HADOOP-19022) ITestS3AConfiguration#testRequestTimeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19022: Component/s: fs/s3 test > ITestS3AConfiguration#testRequestTimeout

[jira] [Comment Edited] (HADOOP-19022) ITestS3AConfiguration#testRequestTimeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803520#comment-17803520 ] Steve Loughran edited comment on HADOOP-19022 at 1/5/24 11:51 AM: --

[jira] [Updated] (HADOOP-19022) ITestS3AConfiguration#testRequestTimeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19022: Affects Version/s: 3.4.0 > ITestS3AConfiguration#testRequestTimeout failure >

[jira] [Commented] (HADOOP-19022) ITestS3AConfiguration#testRequestTimeout failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803520#comment-17803520 ] Steve Loughran commented on HADOOP-19022: - should be a string now, e.g "20s" >

[jira] [Commented] (HADOOP-19025) Migrate ContractTestUtils to AssertJ

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803519#comment-17803519 ] Steve Loughran commented on HADOOP-19025: - looking forward to this! > Migrate

[jira] [Commented] (HADOOP-19026) S3A: TestIAMInstanceCredentialsProvider.testIAMInstanceCredentialsInstantiate failure

2024-01-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803518#comment-17803518 ] Steve Loughran commented on HADOOP-19026: - {code} java.lang.AssertionError: Cause not a

[jira] [Created] (HADOOP-19026) S3A: TestIAMInstanceCredentialsProvider.testIAMInstanceCredentialsInstantiate failure

2024-01-05 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19026: --- Summary: S3A: TestIAMInstanceCredentialsProvider.testIAMInstanceCredentialsInstantiate failure Key: HADOOP-19026 URL: https://issues.apache.org/jira/browse/HADOOP-19026

Re: [PR] HDFS-17269. RBF: Listing trash directory should return subdirs from all subclusters. [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6312: URL: https://github.com/apache/hadoop/pull/6312#issuecomment-1878479567 > @LiuGuH Would it be more chaotic to display the trash directories of all clusters at once? Should we allow users to choose whether to display the trash directories of all subgroups

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-05 Thread via GitHub
LiuGuH commented on PR #6390: URL: https://github.com/apache/hadoop/pull/6390#issuecomment-1878479270 > @LiuGuH When we submit a PR again, a better way is to write the JIRA corresponding to this PR in the description information. > > Like: `JIRA: HDFS-17309. RBF: Fix Router Safemode

Re: [PR] HDFS-17325. Doc: Fix the documentation of fs expunge command in FileSystemShell.md [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6413: URL: https://github.com/apache/hadoop/pull/6413#issuecomment-1878467995 @LiuGuH Thanks for the contribution! @ayushtkn Thanks for reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17325. Doc: Fix the documentation of fs expunge command in FileSystemShell.md [hadoop]

2024-01-05 Thread via GitHub
slfan1989 merged PR #6413: URL: https://github.com/apache/hadoop/pull/6413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6390: URL: https://github.com/apache/hadoop/pull/6390#issuecomment-1878463127 @LiuGuH When we submit a PR again, a better way is to write the JIRA corresponding to this PR in the description information. Like: `JIRA: HDFS-17309. RBF: Fix Router Safemode

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6390: URL: https://github.com/apache/hadoop/pull/6390#issuecomment-1878460283 @LiuGuH Thank you for your contribution! Merged Into trunk. @goiri @simbadzina Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HDFS-17309. RBF: Fix Router Safemode check condition error [hadoop]

2024-01-05 Thread via GitHub
slfan1989 merged PR #6390: URL: https://github.com/apache/hadoop/pull/6390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17325. Doc: Fix the documentation of fs expunge command in FileSystemShell.md [hadoop]

2024-01-05 Thread via GitHub
hadoop-yetus commented on PR #6413: URL: https://github.com/apache/hadoop/pull/6413#issuecomment-1878458100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17300. [SBN READ] Observer should throw ObserverRetryOnActiveException if stateid is always delayed with Active Namenode for a configured time [hadoop]

2024-01-05 Thread via GitHub
LiuGuH opened a new pull request, #6414: URL: https://github.com/apache/hadoop/pull/6414 …ateid is always delayed with Active Namenode for a period of time ### Description of PR Now when Observer NN is used, if the stateid is delayed , the rpcServer will be requeued

Re: [PR] HDFS-17300. [SBN READ] Observer should throw ObserverRetryOnActiveException if stateid is always delayed with Active Namenode for a configured time [hadoop]

2024-01-05 Thread via GitHub
LiuGuH closed pull request #6383: HDFS-17300. [SBN READ] Observer should throw ObserverRetryOnActiveException if stateid is always delayed with Active Namenode for a configured time URL: https://github.com/apache/hadoop/pull/6383 -- This is an automated message from the Apache Git Service.

Re: [PR] HDFS-17321. RBF: Add RouterAutoMsyncService for auto msync in Router [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6404: URL: https://github.com/apache/hadoop/pull/6404#issuecomment-1878445162 @simbadzina Thanks for helping review the code! @LiuGuH Thanks for the contribution! but I think it's better if we don't introduce a new one if the original one works.

Re: [PR] HDFS-17325 Doc: Fix the documentation of fs expunge command in FileSystemShell.md [hadoop]

2024-01-05 Thread via GitHub
slfan1989 commented on PR #6413: URL: https://github.com/apache/hadoop/pull/6413#issuecomment-1878430249 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   >