LiuGuH commented on PR #6414:
URL: https://github.com/apache/hadoop/pull/6414#issuecomment-1886497158
@chliang71 Do you have time to review this? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LiuGuH commented on PR #6392:
URL: https://github.com/apache/hadoop/pull/6392#issuecomment-1886482486
> There is still a check style issue though.
Fixed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
hfutatzhanghb commented on PR #6431:
URL: https://github.com/apache/hadoop/pull/6431#issuecomment-1886385171
@Hexiaoqiao @tomscut Sir, could you please help me review this simple
modification when you are free, Thanks a lot.
--
This is an automated message from the Apache Git Service.
To
hadoop-yetus commented on PR #6392:
URL: https://github.com/apache/hadoop/pull/6392#issuecomment-1886164841
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6419:
URL: https://github.com/apache/hadoop/pull/6419#issuecomment-1886092782
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805341#comment-17805341
]
ASF GitHub Bot commented on HADOOP-18610:
-
tomscut commented on PR #5953:
URL:
tomscut commented on PR #5953:
URL: https://github.com/apache/hadoop/pull/5953#issuecomment-1886076795
Hi @steveloughran and @saxenapranav, could you please help review this PR?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
hfutatzhanghb commented on PR #6434:
URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1886067772
@Hexiaoqiao @zhangshuyan0 @tomscut Sir, could you please take a look at this
PR when you have free time? Thanks.
--
This is an automated message from the Apache Git Service.
To
slfan1989 commented on PR #6419:
URL: https://github.com/apache/hadoop/pull/6419#issuecomment-1886011678
@brumi1024 @K0K0V0K Can you help review the code again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
slfan1989 commented on code in PR #6419:
URL: https://github.com/apache/hadoop/pull/6419#discussion_r1448159809
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java:
##
@@ -89,7 +89,7 @@ public void te
goiri commented on PR #6392:
URL: https://github.com/apache/hadoop/pull/6392#issuecomment-1885974080
There is still a check style issue though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zz12341 commented on code in PR #6437:
URL: https://github.com/apache/hadoop/pull/6437#discussion_r1448119281
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##
@@ -791,15 +791,33 @@ public short getMinReplication
shahrs87 commented on code in PR #6437:
URL: https://github.com/apache/hadoop/pull/6437#discussion_r1448086058
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##
@@ -791,15 +791,33 @@ public short getMinReplicatio
zz12341 opened a new pull request, #6437:
URL: https://github.com/apache/hadoop/pull/6437
…
### Description of PR
[HDFS-16064](https://github.com/apache/hadoop/pull/4410) fixed an issue
where decommissioning replicas were not counted as usable replicas, which
caused de
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1885834973
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1885771188
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HADOOP-19025:
--
Status: Patch Available (was: Open)
> Migrate abstract contract tests to AssertJ
> -
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805270#comment-17805270
]
ASF GitHub Bot commented on HADOOP-19027:
-
hadoop-yetus commented on PR #6425:
hadoop-yetus commented on PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#issuecomment-1885562678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6432:
URL: https://github.com/apache/hadoop/pull/6432#issuecomment-1885452493
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6436:
URL: https://github.com/apache/hadoop/pull/6436#issuecomment-1885410016
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6432:
URL: https://github.com/apache/hadoop/pull/6432#issuecomment-1885403725
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6434:
URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1885348791
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6433:
URL: https://github.com/apache/hadoop/pull/6433#issuecomment-1885332277
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6433:
URL: https://github.com/apache/hadoop/pull/6433#issuecomment-1885328661
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6435:
URL: https://github.com/apache/hadoop/pull/6435#issuecomment-1885276837
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Steve Loughran created HADOOP-19033:
---
Summary: S3A: disable checksum validation
Key: HADOOP-19033
URL: https://issues.apache.org/jira/browse/HADOOP-19033
Project: Hadoop Common
Issue Type:
hadoop-yetus commented on PR #6431:
URL: https://github.com/apache/hadoop/pull/6431#issuecomment-1885260781
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#issuecomment-1885244852
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805226#comment-17805226
]
ASF GitHub Bot commented on HADOOP-19027:
-
hadoop-yetus commented on PR #6425:
hadoop-yetus commented on PR #6419:
URL: https://github.com/apache/hadoop/pull/6419#issuecomment-1885164744
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6431:
URL: https://github.com/apache/hadoop/pull/6431#issuecomment-1885136023
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805200#comment-17805200
]
ASF GitHub Bot commented on HADOOP-19027:
-
hadoop-yetus commented on PR #6425:
hadoop-yetus commented on PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#issuecomment-1885110998
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
saeidN commented on PR #23:
URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1885109517
@steveloughran when will mvn repo be updated with the new jar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
hadoop-yetus commented on PR #6392:
URL: https://github.com/apache/hadoop/pull/6392#issuecomment-1885098919
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
brumi1024 opened a new pull request, #6436:
URL: https://github.com/apache/hadoop/pull/6436
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'H
tomicooler opened a new pull request, #6435:
URL: https://github.com/apache/hadoop/pull/6435
### Description of PR
WIP: until the other 2 ticket is merged, I'll rebase this PR.
Details in the Jira:
[YARN-11641](https://issues.apache.org/jira/browse/YARN-11641)
Note:
hfutatzhanghb opened a new pull request, #6434:
URL: https://github.com/apache/hadoop/pull/6434
### Description of PR
In method FSEditLogAsync#enqueueEdit , there exist the below codes:
```java
if (Thread.holdsLock(this)) {
// if queue is full, synchronized c
[
https://issues.apache.org/jira/browse/HADOOP-19032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-19032:
Summary: S3A: ITestS3AFileContextURI: MultiObjectDeleteException bulk
delete of odd filen
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805185#comment-17805185
]
ASF GitHub Bot commented on HADOOP-19027:
-
steveloughran commented on PR #6425:
steveloughran commented on PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#issuecomment-1885027660
as it stands, this PR will
* map http/ssl channel problems to EOFException subclass which is retried
* map out of range 416 to a different EOF subclass -which is not retried
*
hadoop-yetus commented on PR #6414:
URL: https://github.com/apache/hadoop/pull/6414#issuecomment-1885028838
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805182#comment-17805182
]
ASF GitHub Bot commented on HADOOP-19027:
-
steveloughran commented on code in P
K0K0V0K commented on code in PR #6419:
URL: https://github.com/apache/hadoop/pull/6419#discussion_r1447513712
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java:
##
@@ -89,7 +89,7 @@ public void tear
steveloughran commented on code in PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#discussion_r1447492936
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:
##
@@ -1711,4 +1715,59 @@ public static String etag(FileStatus status) {
tomicooler opened a new pull request, #6433:
URL: https://github.com/apache/hadoop/pull/6433
Change-Id: Id00a5382d982dcf33ec8a3769fc33419b660968b
### Description of PR
There is no reason to ignore the configured capacity if the memory is 0 in
the configuration.
I
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805172#comment-17805172
]
ASF GitHub Bot commented on HADOOP-19027:
-
steveloughran commented on code in P
steveloughran commented on code in PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#discussion_r1447486233
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractVectoredRead.java:
##
@@ -72,9 +78,40 @@ public void testEOFRanges() thr
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805170#comment-17805170
]
ASF GitHub Bot commented on HADOOP-19027:
-
steveloughran commented on PR #6425:
[
https://issues.apache.org/jira/browse/HADOOP-19032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-19032:
Summary: S3A: ITestS3AFileContextURI: MultiObjectDeleteException bulk
delete of odd filen
steveloughran commented on PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#issuecomment-1884981187
Testing
- new tests with mocking and of real tests where failure is shorter file
than claimed in openFile(); no actual generation of failures within an ITest.
- one presumably u
[
https://issues.apache.org/jira/browse/HADOOP-19032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805169#comment-17805169
]
Steve Loughran commented on HADOOP-19032:
-
{code}
[ERROR] Tests run: 17, Failu
Steve Loughran created HADOOP-19032:
---
Summary: MultiObjectDeleteException bulk delete of odd filenames
Key: HADOOP-19032
URL: https://issues.apache.org/jira/browse/HADOOP-19032
Project: Hadoop Common
tomicooler opened a new pull request, #6432:
URL: https://github.com/apache/hadoop/pull/6432
Change-Id: Iff7c8d0522003f9ae9d5c01a1070158e45903d3c
### Description of PR
The JSON assert tests that were using the `createMutableRM` were flaky the
queue order changed in the
LiuGuH commented on PR #6392:
URL: https://github.com/apache/hadoop/pull/6392#issuecomment-1884817179
@goiri Do you have time to reivew this, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
LiuGuH commented on code in PR #6392:
URL: https://github.com/apache/hadoop/pull/6392#discussion_r1440027525
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java:
##
@@ -229,7 +229,7 @@ public ConnectionConte
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1884664069
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805051#comment-17805051
]
ASF GitHub Bot commented on HADOOP-19027:
-
steveloughran commented on PR #6425:
steveloughran commented on PR #6425:
URL: https://github.com/apache/hadoop/pull/6425#issuecomment-1884551071
note aws sdk has done something here with Netty
https://github.com/aws/aws-sdk-java-v2/pull/4655
--
This is an automated message from the Apache Git Service.
To respond to the me
hfutatzhanghb opened a new pull request, #6431:
URL: https://github.com/apache/hadoop/pull/6431
### Description of PR
See HDFS-17335.
To monitor syncWaitQ in FSEditLogAsync, we add a metric syncPendingCount.
The reason we add this metrics is that when dequeueEdit() return
hadoop-yetus commented on PR #6414:
URL: https://github.com/apache/hadoop/pull/6414#issuecomment-1884472273
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6426:
URL: https://github.com/apache/hadoop/pull/6426#issuecomment-1884422714
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
63 matches
Mail list logo
