Re: [PR] YARN-11634. [Addendum] Speed-up TestTimelineClient. [hadoop]

2024-01-14 Thread via GitHub
brumi1024 merged PR #6419: URL: https://github.com/apache/hadoop/pull/6419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HDFS-17129. mis-order of ibr and fbr on datanode [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao commented on PR #6244: URL: https://github.com/apache/hadoop/pull/6244#issuecomment-1891393507 > It may take me a long time to completely solve the issue. My personal suggestion is to roll back https://github.com/apache/hadoop/pull/5408 ([HDFS-16898](https://issues.apache.org/jir

Re: [PR] YARN-11634. [Addendum] Speed-up TestTimelineClient. [hadoop]

2024-01-14 Thread via GitHub
slfan1989 commented on PR #6419: URL: https://github.com/apache/hadoop/pull/6419#issuecomment-1891338241 @brumi1024 Can you help review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] HDFS-17129. mis-order of ibr and fbr on datanode [hadoop]

2024-01-14 Thread via GitHub
slfan1989 commented on PR #6244: URL: https://github.com/apache/hadoop/pull/6244#issuecomment-1891335134 We need to discuss how to address the issue described in this pull request, which is currently blocking the release of hadoop-3.4.0 RC1. After reading discussions in #5888 and #624

Re: [PR] HADOOP-19040. mvn site commands fails due to MetricsSystem And MetricsSystemImpl changes. [hadoop]

2024-01-14 Thread via GitHub
hadoop-yetus commented on PR #6450: URL: https://github.com/apache/hadoop/pull/6450#issuecomment-1891329107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19040) mvn site commands fails due to MetricsSystem And MetricsSystemImpl changes.

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806630#comment-17806630 ] ASF GitHub Bot commented on HADOOP-19040: - hadoop-yetus commented on PR #6450:

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806620#comment-17806620 ] ASF GitHub Bot commented on HADOOP-18610: - saxenapranav commented on code in PR

Re: [PR] HADOOP-18610. ABFS OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-01-14 Thread via GitHub
saxenapranav commented on code in PR #5953: URL: https://github.com/apache/hadoop/pull/5953#discussion_r1451926333 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,108 @@ +/** + * Licensed to the Ap

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806619#comment-17806619 ] ASF GitHub Bot commented on HADOOP-18610: - saxenapranav commented on code in PR

Re: [PR] HADOOP-18610. ABFS OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-01-14 Thread via GitHub
saxenapranav commented on code in PR #5953: URL: https://github.com/apache/hadoop/pull/5953#discussion_r1451925127 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Ap

[jira] [Updated] (HADOOP-19040) mvn site commands fails due to MetricsSystem And MetricsSystemImpl changes.

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19040: Labels: pull-request-available (was: ) > mvn site commands fails due to MetricsSystem An

[jira] [Commented] (HADOOP-19040) mvn site commands fails due to MetricsSystem And MetricsSystemImpl changes.

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806616#comment-17806616 ] ASF GitHub Bot commented on HADOOP-19040: - slfan1989 opened a new pull request,

[PR] HADOOP-19040. mvn site commands fails due to MetricsSystem And MetricsSystemImpl changes. [hadoop]

2024-01-14 Thread via GitHub
slfan1989 opened a new pull request, #6450: URL: https://github.com/apache/hadoop/pull/6450 …sSystemImpl changes. ### Description of PR JIRA: HADOOP-19040. mvn site commands fails due to MetricsSystem And MetricsSystemImpl changes. ### How was this patch tested?

Re: [PR] HDFS-17324. RBF: Router should not return nameservices that not enable observer r… [hadoop]

2024-01-14 Thread via GitHub
hadoop-yetus commented on PR #6412: URL: https://github.com/apache/hadoop/pull/6412#issuecomment-1891285008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17324. RBF: Router should not return nameservices that not enable observer r… [hadoop]

2024-01-14 Thread via GitHub
LiuGuH commented on code in PR #6412: URL: https://github.com/apache/hadoop/pull/6412#discussion_r1451883398 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java: ## @@ -599,9 +604,6 @@ public void testR

[jira] [Commented] (HADOOP-19036) Standardize Maven Initialization Across Operating Systems

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806585#comment-17806585 ] ASF GitHub Bot commented on HADOOP-19036: - hadoop-yetus commented on PR #6444:

Re: [PR] HADOOP-19036. Standardize Maven Initialization Across Operating Systems. [hadoop]

2024-01-14 Thread via GitHub
hadoop-yetus commented on PR #6444: URL: https://github.com/apache/hadoop/pull/6444#issuecomment-1891187073 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19036) Standardize Maven Initialization Across Operating Systems

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806583#comment-17806583 ] ASF GitHub Bot commented on HADOOP-19036: - hadoop-yetus commented on PR #6444:

Re: [PR] HADOOP-19036. Standardize Maven Initialization Across Operating Systems. [hadoop]

2024-01-14 Thread via GitHub
hadoop-yetus commented on PR #6444: URL: https://github.com/apache/hadoop/pull/6444#issuecomment-1891184222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19036) Standardize Maven Initialization Across Operating Systems

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806578#comment-17806578 ] ASF GitHub Bot commented on HADOOP-19036: - hadoop-yetus commented on PR #6444:

Re: [PR] HADOOP-19036. Standardize Maven Initialization Across Operating Systems. [hadoop]

2024-01-14 Thread via GitHub
hadoop-yetus commented on PR #6444: URL: https://github.com/apache/hadoop/pull/6444#issuecomment-1891148967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17320. seekToNewSource uses ignoredNodes to get a new node other than the current node. [hadoop]

2024-01-14 Thread via GitHub
hadoop-yetus commented on PR #6403: URL: https://github.com/apache/hadoop/pull/6403#issuecomment-1891107282 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19041) further use of StandardCharsets

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806564#comment-17806564 ] ASF GitHub Bot commented on HADOOP-19041: - pjfanning opened a new pull request,

[jira] [Updated] (HADOOP-19041) further use of StandardCharsets

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19041: Labels: pull-request-available (was: ) > further use of StandardCharsets > -

[PR] HADOOP-19041. Use StandardCharsets in more places [hadoop]

2024-01-14 Thread via GitHub
pjfanning opened a new pull request, #6449: URL: https://github.com/apache/hadoop/pull/6449 ### Description of PR HADOOP-19041 ### How was this patch tested? ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g

[jira] [Created] (HADOOP-19041) further use of StandardCharsets

2024-01-14 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-19041: --- Summary: further use of StandardCharsets Key: HADOOP-19041 URL: https://issues.apache.org/jira/browse/HADOOP-19041 Project: Hadoop Common Issue Type: Task

Re: [PR] HDFS-17333. DFSClient support lazy resolve host->ip. [hadoop]

2024-01-14 Thread via GitHub
KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1891003400 @Hexiaoqiao hi, could you please help to review, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HDFS-17302. RBF: ProportionRouterRpcFairnessPolicyController-Sharing and isolation. [hadoop]

2024-01-14 Thread via GitHub
KeeProMise commented on PR #6380: URL: https://github.com/apache/hadoop/pull/6380#issuecomment-1890960456 @goiri hi, If no more comments here, please help merge it, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Preparing for 3.5.0 development [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao commented on PR #6411: URL: https://github.com/apache/hadoop/pull/6411#issuecomment-1890924064 Mark this PR to 'ready to review' and re-trigger CI mannually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Preparing for 3.5.0 development [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao commented on PR #6411: URL: https://github.com/apache/hadoop/pull/6411#issuecomment-1890923129 @slfan1989 Hi Shilun, We should check in this PR first then branch-3.4 could freeze and point branch-3.5.0 to trunk for devs. What do you think about? Thanks. -- This is an automate

[jira] [Commented] (HADOOP-19034) Fix Download Maven Url Not Found

2024-01-14 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806452#comment-17806452 ] Xiaoqiao He commented on HADOOP-19034: -- Merged to trunk and branch-3.4.0 & branch-

[jira] [Resolved] (HADOOP-19034) Fix Download Maven Url Not Found

2024-01-14 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He resolved HADOOP-19034. -- Fix Version/s: 3.4.0 3.5.0 Hadoop Flags: Reviewed Resolution: F

[jira] [Commented] (HADOOP-19034) Fix Download Maven Url Not Found

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806451#comment-17806451 ] ASF GitHub Bot commented on HADOOP-19034: - Hexiaoqiao commented on PR #6438: UR

Re: [PR] HADOOP-19034. Fix Download Maven Url Not Found. [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao commented on PR #6438: URL: https://github.com/apache/hadoop/pull/6438#issuecomment-1890911794 Merged. Thanks @slfan1989 and @steveloughran . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HADOOP-19034. Fix Download Maven Url Not Found. [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao merged PR #6438: URL: https://github.com/apache/hadoop/pull/6438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[jira] [Commented] (HADOOP-19038) Improve create-release RUN script

2024-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806448#comment-17806448 ] ASF GitHub Bot commented on HADOOP-19038: - Hexiaoqiao commented on code in PR #

Re: [PR] HADOOP-19038. Improve create-release RUN script. [hadoop]

2024-01-14 Thread via GitHub
Hexiaoqiao commented on code in PR #6448: URL: https://github.com/apache/hadoop/pull/6448#discussion_r1451701620 ## dev-support/bin/create-release: ## @@ -504,9 +504,9 @@ function dockermode echo "LABEL org.apache.hadoop.create-release=\"cr-${RANDOM}\"" # setup owner