Re: [PR] HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block [hadoop]

2024-02-27 Thread via GitHub
haiyang1987 commented on code in PR #6559: URL: https://github.com/apache/hadoop/pull/6559#discussion_r1505502474 ## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ## @@ -3982,6 +3982,17 @@ + + dfs.datanode.delete.corrupt.replica.from.disk.enable

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1968357990 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401 Erasure Coding: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1968265932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18583) hadoop checknative fails to load openssl 3.x

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821493#comment-17821493 ] ASF GitHub Bot commented on HADOOP-18583: - jasonwzs commented on PR #5256: URL:

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-1968123399 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18583. Fix loading of OpenSSL 3.x symbols [hadoop]

2024-02-27 Thread via GitHub
jasonwzs commented on PR #5256: URL: https://github.com/apache/hadoop/pull/5256#issuecomment-1968123368 @packet23 @steveloughran , can you provide more details on the individual issues related to openssl 3 support? It would be nice if we create jira issues for tracking purpose. I am

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821490#comment-17821490 ] ASF GitHub Bot commented on HADOOP-19085: - hadoop-yetus commented on PR #6535: URL:

Re: [PR] HDFS-17316 Add hadoop-compat-bench [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6535: URL: https://github.com/apache/hadoop/pull/6535#issuecomment-1968100873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17387. [FGL] Abstract the configuration locking mode [hadoop]

2024-02-27 Thread via GitHub
ZanderXu commented on code in PR #6572: URL: https://github.com/apache/hadoop/pull/6572#discussion_r1505263247 ## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ## @@ -3956,6 +3956,15 @@ + + dfs.namenode.lock.model.provider.class +

Re: [PR] HDFS-17387. [FGL] Abstract the configuration locking mode [hadoop]

2024-02-27 Thread via GitHub
ZanderXu commented on code in PR #6572: URL: https://github.com/apache/hadoop/pull/6572#discussion_r1505263154 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/fgl/MeasurableReentrantReadWriteLock.java: ## Review Comment: done --

[PR] HDFS-17401 Erasure Coding: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-02-27 Thread via GitHub
RuinanGu opened a new pull request, #6597: URL: https://github.com/apache/hadoop/pull/6597 ### Description of PR jira: [https://issues.apache.org/jira/browse/HDFS-17401](url) Excess internal block can't be deleted correctly when it's stored in fallback storage. Simple

[jira] [Commented] (HADOOP-19093) add load tests for abfs rename resilience

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821422#comment-17821422 ] ASF GitHub Bot commented on HADOOP-19093: - hadoop-yetus commented on PR #6596: URL:

Re: [PR] HADOOP-19093. [ABFS] ILoadTestRenameRecovery [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6596: URL: https://github.com/apache/hadoop/pull/6596#issuecomment-1967614035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1967598559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821419#comment-17821419 ] ASF GitHub Bot commented on HADOOP-18910: - mukund-thakur commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-27 Thread via GitHub
mukund-thakur commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1967594293 > You also need to add following test configuration to specify the account type you are using `fs.azure.test.namespace.enabled "` > > ``` > >

[jira] [Commented] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-27 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821417#comment-17821417 ] Venkatasubrahmanian Narayanan commented on HADOOP-19091: Actually, a follow-up

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1967550720 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18950: shaded avro jar [hadoop]

2024-02-27 Thread via GitHub
pjfanning commented on PR #4854: URL: https://github.com/apache/hadoop/pull/4854#issuecomment-1967549235 @ayushtkn @slfan1989 @steveloughran Is this a change we could put in 3.4.0-RC3? Avro is a bit like Protobuf in that Hadoop has generated classes using both frameworks and needs runtime

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1967520180 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-27 Thread via GitHub
ritegarg closed pull request #6556: HDFS-17299. Adding rack failure tolerance when creating a new file URL: https://github.com/apache/hadoop/pull/6556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Test Build [hadoop]

2024-02-27 Thread via GitHub
ritegarg closed pull request #6563: Test Build URL: https://github.com/apache/hadoop/pull/6563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-27 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821372#comment-17821372 ] Venkatasubrahmanian Narayanan edited comment on HADOOP-19091 at 2/27/24 7:38 PM:

[jira] [Comment Edited] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-27 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821372#comment-17821372 ] Venkatasubrahmanian Narayanan edited comment on HADOOP-19091 at 2/27/24 7:34 PM:

Re: [PR] HDFS-17391:Adjust the checkpoint io buffer size to the chunk size [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6594: URL: https://github.com/apache/hadoop/pull/6594#issuecomment-1967402612 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-19094) Update DN to report which NN has provided the updated block keys

2024-02-27 Thread Joseph Dell'Aringa (Jira)
Joseph Dell'Aringa created HADOOP-19094: --- Summary: Update DN to report which NN has provided the updated block keys Key: HADOOP-19094 URL: https://issues.apache.org/jira/browse/HADOOP-19094

[jira] [Commented] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-27 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821372#comment-17821372 ] Venkatasubrahmanian Narayanan commented on HADOOP-19091: [~srahman] I've

[jira] [Updated] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-27 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkatasubrahmanian Narayanan updated HADOOP-19091: --- Attachment: 0001-AWS-Hive-Changes.patch

[jira] [Updated] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-02-27 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkatasubrahmanian Narayanan updated HADOOP-19091: --- Attachment: HADOOP-19091-HIVE-WIP.patch > Add support for

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821356#comment-17821356 ] ASF GitHub Bot commented on HADOOP-19090: - ayushtkn commented on code in PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
ayushtkn commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1504679035 ## hadoop-project/pom.xml: ## @@ -93,11 +93,11 @@ ${common.protobuf2.scope} -3.21.12 +3.23.4 Review Comment: this is correct, you need to

[jira] [Commented] (HADOOP-19088) upgrade to jersey-json 1.22.0

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821355#comment-17821355 ] ASF GitHub Bot commented on HADOOP-19088: - hadoop-yetus commented on PR #6585: URL:

Re: [PR] HADOOP-19088. Use jersey-json 1.22.0 [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6585: URL: https://github.com/apache/hadoop/pull/6585#issuecomment-1967248628 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19093) add load tests for abfs rename resilience

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19093: Labels: pull-request-available (was: ) > add load tests for abfs rename resilience >

[jira] [Commented] (HADOOP-19093) add load tests for abfs rename resilience

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821353#comment-17821353 ] ASF GitHub Bot commented on HADOOP-19093: - steveloughran opened a new pull request, #6596: URL:

[PR] HADOOP-19093. [ABFS] ILoadTestRenameRecovery [hadoop]

2024-02-27 Thread via GitHub
steveloughran opened a new pull request, #6596: URL: https://github.com/apache/hadoop/pull/6596 ### Description of PR Adds new test which can be explicitly launched to try and trigger rename throttling. ### How was this patch tested? It doesn't generate enough load at

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1967140782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17254. DataNode httpServer has too many worker threads [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6307: URL: https://github.com/apache/hadoop/pull/6307#issuecomment-1967106942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-27 Thread Han Liu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821332#comment-17821332 ] Han Liu commented on HADOOP-19085: -- The code has been updated to a new version and all issues listed

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1966847913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1966671093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17254. DataNode httpServer has too many worker threads [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6307: URL: https://github.com/apache/hadoop/pull/6307#issuecomment-1966570601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-02-27 Thread via GitHub
zhtttylz opened a new pull request, #6595: URL: https://github.com/apache/hadoop/pull/6595 JIRA: HDFS-17146. [Addendum] Enhance test readability with assertJ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-27 Thread via GitHub
pjfanning commented on PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34#issuecomment-1966522150 @steveloughran do you have the permissions to rerun the CI build? - I think it was just a download issue This update looks promising - see

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821226#comment-17821226 ] ASF GitHub Bot commented on HADOOP-19090: - pjfanning commented on PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1966519899 The 1 broken test seems unrelated: ``` [ERROR] org.apache.hadoop.hdfs.server.namenode.TestSecureNameNode Time elapsed: 1.417 s <<< ERROR!

Re: [PR] HDFS-17333. DFSClient support lazy resolve host->ip. [hadoop]

2024-02-27 Thread via GitHub
KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1966509264 Hi @tasanuma @Hexiaoqiao @zhangshuyan0, @slfan1989 Please kindly review this PR as well if you have bandwidth, Thanks. -- This is an automated message from the Apache Git Service.

[jira] [Created] (HADOOP-19093) add load tests for abfs rename resilience

2024-02-27 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19093: --- Summary: add load tests for abfs rename resilience Key: HADOOP-19093 URL: https://issues.apache.org/jira/browse/HADOOP-19093 Project: Hadoop Common

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1966351154 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821187#comment-17821187 ] ASF GitHub Bot commented on HADOOP-19090: - hadoop-yetus commented on PR #6593: URL:

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821188#comment-17821188 ] ASF GitHub Bot commented on HADOOP-19090: - pjfanning commented on code in PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
pjfanning commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1504072883 ## hadoop-project/pom.xml: ## @@ -93,11 +93,11 @@ ${common.protobuf2.scope} -3.21.12 +3.23.4 Review Comment: this value is the one used

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1966336761 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2024-02-27 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821186#comment-17821186 ] PJ Fanning commented on HADOOP-18197: - I have https://github.com/apache/hadoop-thirdparty/pull/34

[jira] [Updated] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19090: Affects Version/s: 3.4.0 3.3.9 > Update Protocol Buffers

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821184#comment-17821184 ] ASF GitHub Bot commented on HADOOP-19090: - steveloughran commented on code in PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
steveloughran commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1504069368 ## hadoop-project/pom.xml: ## @@ -93,11 +93,11 @@ ${common.protobuf2.scope} -3.21.12 +3.23.4 Review Comment: I'd prefer editing

[jira] [Commented] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2024-02-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821183#comment-17821183 ] Steve Loughran commented on HADOOP-18197: - +1 for moving to 3.23; trying to maintain someone

[jira] [Updated] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to Custom SASTokenProvider Implementation

2024-02-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18516: Fix Version/s: (was: 3.4.0) > [ABFS]: Support fixed SAS token config in addition to

[jira] [Updated] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to Custom SASTokenProvider Implementation

2024-02-27 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18516: Parent: HADOOP-19092 Issue Type: Sub-task (was: Improvement) > [ABFS]: Support

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821177#comment-17821177 ] ASF GitHub Bot commented on HADOOP-19052: - hadoop-yetus commented on PR #6587: URL:

[jira] [Created] (HADOOP-19092) ABFS phase 4: post Hadoop 3.4.0 features

2024-02-27 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19092: --- Summary: ABFS phase 4: post Hadoop 3.4.0 features Key: HADOOP-19092 URL: https://issues.apache.org/jira/browse/HADOOP-19092 Project: Hadoop Common

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-1966310845 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6577: URL: https://github.com/apache/hadoop/pull/6577#issuecomment-1966285056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17387. [FGL] Abstract the configuration locking mode [hadoop]

2024-02-27 Thread via GitHub
ferhui commented on code in PR #6572: URL: https://github.com/apache/hadoop/pull/6572#discussion_r1503967442 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/fgl/MeasurableReentrantReadWriteLock.java: ## Review Comment: Got it. If so.

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-1966189086 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17387. [FGL] Abstract the configuration locking mode [hadoop]

2024-02-27 Thread via GitHub
ZanderXu commented on code in PR #6572: URL: https://github.com/apache/hadoop/pull/6572#discussion_r1503958822 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/fgl/MeasurableReentrantReadWriteLock.java: ## Review Comment: Yes, this

Re: [PR] HDFS-17391:Adjust the checkpoint io buffer size to the chunk size [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6594: URL: https://github.com/apache/hadoop/pull/6594#issuecomment-1966183261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1966180516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17387. [FGL] Abstract the configuration locking mode [hadoop]

2024-02-27 Thread via GitHub
ferhui commented on code in PR #6572: URL: https://github.com/apache/hadoop/pull/6572#discussion_r1503944791 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/fgl/MeasurableReentrantReadWriteLock.java: ## Review Comment: Is it used for

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-1966164021 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to Custom SASTokenProvider Implementation

2024-02-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821065#comment-17821065 ] ASF GitHub Bot commented on HADOOP-18516: - hadoop-yetus commented on PR #6552: URL:

Re: [PR] HADOOP-18516: [ABFS][Authentication] Support Fixed SAS Token for ABFS Authentication [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6552: URL: https://github.com/apache/hadoop/pull/6552#issuecomment-1966046437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-02-27 Thread via GitHub
hfutatzhanghb commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-1966017968 @zhangshuyan0 @ZanderXu @tasanuma @tomscut Hi, sir. Have updated this PR. 1. Only move the single high priority command to the head of queue. The left commands in cmds are