Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6598: URL: https://github.com/apache/hadoop/pull/6598#issuecomment-1974558688 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6598: URL: https://github.com/apache/hadoop/pull/6598#issuecomment-1974496717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6598: URL: https://github.com/apache/hadoop/pull/6598#issuecomment-1974452168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6598: URL: https://github.com/apache/hadoop/pull/6598#issuecomment-1974375414 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6598: URL: https://github.com/apache/hadoop/pull/6598#issuecomment-1974363652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509893467 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509891173 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java: ## @@ -111,6 +111,7 @@ protected LocatedBlock nextBlockOutputSt

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1974274041 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Testing without restart to check unit tests [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6605: URL: https://github.com/apache/hadoop/pull/6605#issuecomment-1974233711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17406. Suppress UnresolvedPathException in hdfs router log [hadoop]

2024-03-01 Thread via GitHub
haiyang1987 commented on PR #6603: URL: https://github.com/apache/hadoop/pull/6603#issuecomment-1974225273 Thanks @ZanderXu for your review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDFS-17396. BootstrapStandby should download rollback image during RollingUpgrade [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6583: URL: https://github.com/apache/hadoop/pull/6583#issuecomment-1974210242 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509773824 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -2259,4 +2282,4 @@ public String toString() { return extend

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509772592 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java: ## @@ -111,6 +111,7 @@ protected LocatedBlock nextBlockOutputSt

Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
Jtdellaringa commented on code in PR #6598: URL: https://github.com/apache/hadoop/pull/6598#discussion_r1509756204 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java: ## @@ -221,12 +225,16 @@ private synchron

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-01 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822729#comment-17822729 ] Shilun Fan commented on HADOOP-19090: - [~ste...@apache.org] Thank you for your cont

Re: [PR] HDFS-17404. Add Namenode info to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
ctrezzo commented on code in PR #6598: URL: https://github.com/apache/hadoop/pull/6598#discussion_r1509687361 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java: ## @@ -221,12 +225,16 @@ private synchronized

[jira] [Commented] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822727#comment-17822727 ] ASF GitHub Bot commented on HADOOP-19098: - hadoop-yetus commented on PR #6604:

Re: [PR] HADOOP-19098 Vector IO: consistent specified rejection of overlapping ranges [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6604: URL: https://github.com/apache/hadoop/pull/6604#issuecomment-1974086742 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17333. DFSClient support lazy resolve host->ip. [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1974015178 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1973994876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509591909 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

[PR] Testing without restart to check unit tests [hadoop]

2024-03-01 Thread via GitHub
ritegarg opened a new pull request, #6605: URL: https://github.com/apache/hadoop/pull/6605 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509482598 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

[jira] [Commented] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-03-01 Thread Venkatasubrahmanian Narayanan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822709#comment-17822709 ] Venkatasubrahmanian Narayanan commented on HADOOP-19091: [~ste.

Re: [PR] HDFS-17404. Add Namenode Index to log message when setting block keys [hadoop]

2024-03-01 Thread via GitHub
ctrezzo commented on code in PR #6598: URL: https://github.com/apache/hadoop/pull/6598#discussion_r1509499856 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java: ## @@ -226,7 +228,7 @@ public synchronized voi

Re: [PR] HDFS-17383:Datanode current block token should come from active NameNode in HA mode [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6562: URL: https://github.com/apache/hadoop/pull/6562#issuecomment-1973844005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19098: Labels: pull-request-available (was: ) > Vector IO: consistent specified rejection of ov

[jira] [Commented] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822693#comment-17822693 ] ASF GitHub Bot commented on HADOOP-19098: - steveloughran opened a new pull requ

[PR] HADOOP-19098 Vector IO: consistent specified rejection of overlapping ranges [hadoop]

2024-03-01 Thread via GitHub
steveloughran opened a new pull request, #6604: URL: https://github.com/apache/hadoop/pull/6604 * Clarify behaviour * Add checks to all implementations * Add abfs contract test. ABFS doesn't (yet) implement the API; this initially verifies that the fallback implementatio

Re: [PR] HADOOP-19012. Use CRC tables to speed up galoisFieldMultiply in CrcUtil. [hadoop]

2024-03-01 Thread via GitHub
szetszwo commented on PR #6542: URL: https://github.com/apache/hadoop/pull/6542#issuecomment-1973763043 > Possible null pointer dereference in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize(String) due to return value of called method > [Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VAL

Re: [PR] HDFS-17391:Adjust the checkpoint io buffer size to the chunk size [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6594: URL: https://github.com/apache/hadoop/pull/6594#issuecomment-1973649405 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19097) core-default fs.s3a.connection.establish.timeout value too low -warning always printed

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822675#comment-17822675 ] ASF GitHub Bot commented on HADOOP-19097: - virajjasani commented on PR #6601: U

Re: [PR] HADOOP-19097. S3A: Set fs.s3a.connection.establish.timeout to 30s [hadoop]

2024-03-01 Thread via GitHub
virajjasani commented on PR #6601: URL: https://github.com/apache/hadoop/pull/6601#issuecomment-1973645133 Change looks good, until we remove fs.s3a settings from core-default, i wonder if we should do one round of comparison b/ s3a/Contants and core-default (as a followup jira)? -- This

Re: [PR] HDFS-17382. Add Apache Log4j Extras Library to Hadoop 3.4 for Enhance… [hadoop]

2024-03-01 Thread via GitHub
dntjr8096 commented on PR #6584: URL: https://github.com/apache/hadoop/pull/6584#issuecomment-1973375164 @dineshchitlangia @slfan1989 @steveloughran First of all, thank you for reviewing my PR. I also agree with moving away from log4j1. Patching to log4j2 and backporting if possible would

[jira] [Created] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-01 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19098: --- Summary: Vector IO: consistent specified rejection of overlapping ranges Key: HADOOP-19098 URL: https://issues.apache.org/jira/browse/HADOOP-19098 Project: Hado

Re: [PR] HDFS-17333. DFSClient support lazy resolve host->ip. [hadoop]

2024-03-01 Thread via GitHub
tasanuma commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1973277467 @KeeProMise Sorry for being very late. This is a nice feature and the PR looks pretty good to me. It's been a long time since Jenkins last ran, so I've triggered it to run again. I

[jira] [Commented] (HADOOP-19097) core-default fs.s3a.connection.establish.timeout value too low -warning always printed

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822573#comment-17822573 ] ASF GitHub Bot commented on HADOOP-19097: - steveloughran commented on PR #6601:

Re: [PR] HADOOP-19097. S3A: Set fs.s3a.connection.establish.timeout to 30s [hadoop]

2024-03-01 Thread via GitHub
steveloughran commented on PR #6601: URL: https://github.com/apache/hadoop/pull/6601#issuecomment-1973221326 @HarshitGupta11 @mukund-thakur @ahmarsuhail reviews, please? targeting 3.4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-19074) Transitive dependencies with CVEs in Hadoop distro

2024-03-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822570#comment-17822570 ] Steve Loughran commented on HADOOP-19074: - [~prathapsagars] * hadoop RC 3.4 wi

[jira] [Commented] (HADOOP-19074) Transitive dependencies with CVEs in Hadoop distro

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822566#comment-17822566 ] ASF GitHub Bot commented on HADOOP-19074: - steveloughran commented on PR #6586:

Re: [PR] Commit to remove vulnerabilities raised for: HADOOP-19074 [hadoop]

2024-03-01 Thread via GitHub
steveloughran commented on PR #6586: URL: https://github.com/apache/hadoop/pull/6586#issuecomment-1973202811 @prathapsagar thanks for starting this. you are about to discover why it so hard to update dependencies. Everything we want to use in our own code should be defined in the thi

[jira] [Commented] (HADOOP-19074) Transitive dependencies with CVEs in Hadoop distro

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822559#comment-17822559 ] ASF GitHub Bot commented on HADOOP-19074: - steveloughran commented on code in P

Re: [PR] Commit to remove vulnerabilities raised for: HADOOP-19074 [hadoop]

2024-03-01 Thread via GitHub
steveloughran commented on code in PR #6586: URL: https://github.com/apache/hadoop/pull/6586#discussion_r1508977472 ## hadoop-project/pom.xml: ## @@ -169,7 +169,7 @@ -Xmx2048m -XX:+HeapDumpOnOutOfMemoryError -3.0.0-M1 +3.2.5 Review Comment: tried that a

Re: [PR] HDFS-17382. Add Apache Log4j Extras Library to Hadoop 3.4 for Enhance… [hadoop]

2024-03-01 Thread via GitHub
dineshchitlangia commented on PR #6584: URL: https://github.com/apache/hadoop/pull/6584#issuecomment-1973179762 > commented; ignore what I said above about hadoop common, as this is already hadoop hdfs. > > however, we are trying to move off log4j 1 entirely. Can't we focus on that?

[jira] [Commented] (HADOOP-19091) Add support for Tez to MagicS3GuardCommitter

2024-03-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822555#comment-17822555 ] Steve Loughran commented on HADOOP-19091: - 1. can you find out why a different

Re: [PR] HDFS-17382. Add Apache Log4j Extras Library to Hadoop 3.4 for Enhance… [hadoop]

2024-03-01 Thread via GitHub
steveloughran commented on code in PR #6584: URL: https://github.com/apache/hadoop/pull/6584#discussion_r1508958305 ## hadoop-hdfs-project/hadoop-hdfs/pom.xml: ## @@ -35,6 +35,17 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> + + log4j + apache-log4j-

Re: [PR] HDFS-17382. Add Apache Log4j Extras Library to Hadoop 3.4 for Enhance… [hadoop]

2024-03-01 Thread via GitHub
steveloughran commented on PR #6584: URL: https://github.com/apache/hadoop/pull/6584#issuecomment-1973158445 @dineshchitlangia I want to strip dependendencies from hadoop common, rather than add more, as they contaminate all applications downstream and just add more CVEs. Just as we

[jira] [Commented] (HADOOP-19018) Release Hadoop 3.4.0

2024-03-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822548#comment-17822548 ] Steve Loughran commented on HADOOP-19018: - I'm happy with shipping RC3 without

[jira] [Updated] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19090: Target Version/s: 3.4.1 > Update Protocol Buffers installation to 3.23.4 > --

Re: [PR] HDFS-17387. [FGL] Abstract the configuration locking mode [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6572: URL: https://github.com/apache/hadoop/pull/6572#issuecomment-1973147848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822545#comment-17822545 ] Steve Loughran commented on HADOOP-19090: - I'm happy with that; we can target 3

[jira] [Commented] (HADOOP-19084) prune dependency exports of hadoop-* modules

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822543#comment-17822543 ] ASF GitHub Bot commented on HADOOP-19084: - steveloughran merged PR #6582: URL:

Re: [PR] HADOOP-19084. Prune hadoop-common transitive dependencies (#6574) [hadoop]

2024-03-01 Thread via GitHub
steveloughran merged PR #6582: URL: https://github.com/apache/hadoop/pull/6582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HDFS-17406. Suppress UnresolvedPathException in hdfs router log [hadoop]

2024-03-01 Thread via GitHub
ZanderXu merged PR #6603: URL: https://github.com/apache/hadoop/pull/6603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HDFS-17406. Suppress UnresolvedPathException in hdfs router log [hadoop]

2024-03-01 Thread via GitHub
ZanderXu closed pull request #6603: HDFS-17406. Suppress UnresolvedPathException in hdfs router log URL: https://github.com/apache/hadoop/pull/6603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] HDFS-17406. Suppress UnresolvedPathException in hdfs router log [hadoop]

2024-03-01 Thread via GitHub
haiyang1987 commented on PR #6603: URL: https://github.com/apache/hadoop/pull/6603#issuecomment-1972961520 > The spotbugs is not introduced by this PR. But @haiyang1987 would like to fix this spotbugs? Yeah, I will to fix this spotbugs. thanks~ -- This is an automated m

Re: [PR] HDFS-17406. Suppress UnresolvedPathException in hdfs router log [hadoop]

2024-03-01 Thread via GitHub
ZanderXu commented on PR #6603: URL: https://github.com/apache/hadoop/pull/6603#issuecomment-1972954861 The spotbugs is not introduced by this PR. But @haiyang1987 would like to fix this spotbugs? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822496#comment-17822496 ] ASF GitHub Bot commented on HADOOP-18656: - hadoop-yetus commented on PR #6409:

Re: [PR] HADOOP-18656: [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6409: URL: https://github.com/apache/hadoop/pull/6409#issuecomment-1972931402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17406. Suppress UnresolvedPathException in hdfs router log [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6603: URL: https://github.com/apache/hadoop/pull/6603#issuecomment-1972910846 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19096: Labels: pull-request-available (was: ) > [ABFS] Enhancing Client-Side Throttling Metrics

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-03-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822474#comment-17822474 ] ASF GitHub Bot commented on HADOOP-19096: - hadoop-yetus commented on PR #6276:

Re: [PR] HADOOP-19096: [ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-03-01 Thread via GitHub
hadoop-yetus commented on PR #6276: URL: https://github.com/apache/hadoop/pull/6276#issuecomment-1972852926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] Hadoop 18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-03-01 Thread via GitHub
anmolanmol1234 commented on code in PR #6314: URL: https://github.com/apache/hadoop/pull/6314#discussion_r1508647572 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -1411,6 +1448,97 @@ protected AccessTokenProvider getToke