[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828611#comment-17828611 ] ASF GitHub Bot commented on HADOOP-19052: - liangyu-1 commented on PR #6587: URL

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-19 Thread via GitHub
liangyu-1 commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-2008719994 @slfan1989 Hi, I have just fixed the checkstyle warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828609#comment-17828609 ] ASF GitHub Bot commented on HADOOP-19052: - hadoop-yetus commented on PR #6587:

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-2008697038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17430. RecoveringBlock will skip no live replicas when get block recovery command. [hadoop]

2024-03-19 Thread via GitHub
dineshchitlangia commented on PR #6635: URL: https://github.com/apache/hadoop/pull/6635#issuecomment-2008619571 @ZanderXu as you had posted the first set of suggestions, could you confirm if your suggestions are addressed? We can merge once we have your +1 -- This is an automated message

Re: [PR] HDFS-17430. RecoveringBlock will skip no live replicas when get block recovery command. [hadoop]

2024-03-19 Thread via GitHub
haiyang1987 commented on PR #6635: URL: https://github.com/apache/hadoop/pull/6635#issuecomment-2008615230 Hi Sir @dineshchitlangia @ayushtkn Would you mind help review this PR when you have free time? Thank you so much. -- This is an automated message from the Apache Git Service. To re

Re: [PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
haiyang1987 commented on PR #6643: URL: https://github.com/apache/hadoop/pull/6643#issuecomment-2008608210 Thanks @dineshchitlangia @ayushtkn @wzk784533 for your review and merge~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
dineshchitlangia merged PR #6643: URL: https://github.com/apache/hadoop/pull/6643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr

Re: [PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
haiyang1987 commented on PR #6643: URL: https://github.com/apache/hadoop/pull/6643#issuecomment-2008603273 Thanks @wzk784533 @ayushtkn @dineshchitlangia for your review. I found that the log format showed some problems, such as the mentioned in this issue https://github.com/apache/ha

Re: [PR] HDFS-17433. metrics sumOfActorCommandQueueLength should only record valid commands. [hadoop]

2024-03-19 Thread via GitHub
hfutatzhanghb commented on PR #6644: URL: https://github.com/apache/hadoop/pull/6644#issuecomment-2008595490 > +1 LGTM, pending CI @hfutatzhanghb thanks for finding this issue and contributing the fix. Sir, thanks a lot for reviewing. -- This is an automated message from the Apache

[PR] HDFS-17433. metrics sumOfActorCommandQueueLength should only record valid commands. [hadoop]

2024-03-19 Thread via GitHub
hfutatzhanghb opened a new pull request, #6644: URL: https://github.com/apache/hadoop/pull/6644 ### Description of PR We add an phone alarm on metrics sumOfActorCommandQueueLength when it beyond 3000. Recently, we received the alarm and we found that `DatanodeCommand[] cmds` with

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828561#comment-17828561 ] ASF GitHub Bot commented on HADOOP-19052: - slfan1989 commented on PR #6587: URL

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-19 Thread via GitHub
slfan1989 commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-2008519566 @liangyu-1 Can we fix the checkstyle issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (HADOOP-19118) KeyShell fails with NPE when KMS throws Exception with null as message

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828517#comment-17828517 ] Steve Loughran commented on HADOOP-19118: - if e.e.getLocalizedMessage() is null

[jira] [Commented] (HADOOP-14837) Handle S3A "glacier" data

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828513#comment-17828513 ] ASF GitHub Bot commented on HADOOP-14837: - steveloughran commented on code in P

Re: [PR] HADOOP-14837 : Support Read Restored Glacier Objects [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on code in PR #6407: URL: https://github.com/apache/hadoop/pull/6407#discussion_r1530919362 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/api/S3ObjectStorageClassFilter.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

Re: [PR] YARN-5305. Allow log aggregation to discard expired delegation tokens [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6625: URL: https://github.com/apache/hadoop/pull/6625#issuecomment-2008119232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828511#comment-17828511 ] ASF GitHub Bot commented on HADOOP-19098: - hadoop-yetus commented on PR #6604:

Re: [PR] HADOOP-19098 Vector IO: consistent specified rejection of overlapping ranges [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6604: URL: https://github.com/apache/hadoop/pull/6604#issuecomment-2008090350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
ayushtkn commented on code in PR #6643: URL: https://github.com/apache/hadoop/pull/6643#discussion_r1530927655 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java: ## @@ -628,7 +628,7 @@ public void run() {

Re: [PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6643: URL: https://github.com/apache/hadoop/pull/6643#issuecomment-2007841730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828478#comment-17828478 ] ASF GitHub Bot commented on HADOOP-19102: - steveloughran commented on code in P

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1530854506 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStreamReadFooter.java: ## @@ -167,24 +200,55 @@ public void testSee

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828472#comment-17828472 ] ASF GitHub Bot commented on HADOOP-19102: - steveloughran commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2007808498 yeah, spotbugs unrelated; should be fixed in trunk now and for future PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-03-19 Thread via GitHub
shameersss1 commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2007805123 > -1. Please do not change the following `@Public` and `@Evolving` classes: > > * QuotaExceededException.java > > * DSQuotaExceededException.java > > > >

[jira] [Commented] (HADOOP-19116) update to zookeeper client 3.8.4 due to CVE

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828468#comment-17828468 ] ASF GitHub Bot commented on HADOOP-19116: - ayushtkn commented on PR #6638: URL:

Re: [PR] HADOOP-19116. Update to zookeeper client 3.8.4 due to CVE. [hadoop]

2024-03-19 Thread via GitHub
ayushtkn commented on PR #6638: URL: https://github.com/apache/hadoop/pull/6638#issuecomment-2007802017 There is a failure in the patch-unit https://github.com/apache/hadoop/assets/25608848/27684f97-4dd4-42e9-8760-2a32f4202401";> ``` [INFO] --

[jira] [Resolved] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19050. - Fix Version/s: 3.5.0 Resolution: Fixed Fixed in trunk; backport to 3.4 should go

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-19 Thread via GitHub
steveloughran merged PR #6544: URL: https://github.com/apache/hadoop/pull/6544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828465#comment-17828465 ] ASF GitHub Bot commented on HADOOP-19050: - adnanhemani commented on PR #6544: U

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-19 Thread via GitHub
adnanhemani commented on PR #6544: URL: https://github.com/apache/hadoop/pull/6544#issuecomment-2007791751 Yup, this makes sense. I will ensure that Hadoop gets the SDK changes as soon as the SDK updates are complete. Thank you again for all your time reviewing this! -- This is an automa

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828463#comment-17828463 ] ASF GitHub Bot commented on HADOOP-19050: - steveloughran commented on PR #6544:

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on PR #6544: URL: https://github.com/apache/hadoop/pull/6544#issuecomment-2007781626 hey, if yetus is unhappy, rebase is the right thing to do, so don't worry too much. just trying to remember where i was, that's all -- This is an automated message from the Apache

[jira] [Commented] (HADOOP-19079) check that class that is loaded is really an exception

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828461#comment-17828461 ] ASF GitHub Bot commented on HADOOP-19079: - steveloughran commented on code in P

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on code in PR #6557: URL: https://github.com/apache/hadoop/pull/6557#discussion_r1530821435 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java: ## @@ -150,9 +156,14 @@ public static void validateResponse(Ht

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828459#comment-17828459 ] ASF GitHub Bot commented on HADOOP-19050: - adnanhemani commented on PR #6544: U

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-19 Thread via GitHub
adnanhemani commented on PR #6544: URL: https://github.com/apache/hadoop/pull/6544#issuecomment-2007775835 Sorry! Yetus was complaining that it could not apply the changes on top of `trunk` so I instinctively rebased and force pushed - will keep this in mind! -- This is an automated messa

Re: [PR] [SPARK-38958]: Override S3 Client in Spark Write/Read calls [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on PR #6550: URL: https://github.com/apache/hadoop/pull/6550#issuecomment-2007773085 Can use HADOOP-18562 for the JIRA ID here; hadoop codebase see. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828456#comment-17828456 ] ASF GitHub Bot commented on HADOOP-19050: - steveloughran commented on PR #6544:

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-03-19 Thread via GitHub
steveloughran commented on PR #6544: URL: https://github.com/apache/hadoop/pull/6544#issuecomment-2007753756 please, please please, no force push once reviews have started unless there's merge problems or its been neglected for too long...makes it harder to seee what's changed between revie

[jira] [Updated] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19119: Priority: Minor (was: Major) > spotbugs complaining about possible NPE in > org.apache.

[jira] [Resolved] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19119. - Fix Version/s: 3.5.0 3.4.1 Resolution: Fixed > spotbugs compl

[jira] [Commented] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828452#comment-17828452 ] ASF GitHub Bot commented on HADOOP-19119: - steveloughran merged PR #6642: URL:

Re: [PR] HADOOP-19119. Spotbugs: possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize() [hadoop]

2024-03-19 Thread via GitHub
steveloughran merged PR #6642: URL: https://github.com/apache/hadoop/pull/6642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HADOOP-19112. Hadoop 3.4.0 release wrap-up. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6640: URL: https://github.com/apache/hadoop/pull/6640#issuecomment-2007709572 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-2007703551 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-5305. Allow log aggregation to discard expired delegation tokens [hadoop]

2024-03-19 Thread via GitHub
K0K0V0K commented on PR #6625: URL: https://github.com/apache/hadoop/pull/6625#issuecomment-2007689009 Thanks, @p-szucs for this fix. Nice work! LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (HADOOP-19114) upgrade to commons-compress 1.26.1 due to cves

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828442#comment-17828442 ] ASF GitHub Bot commented on HADOOP-19114: - hadoop-yetus commented on PR #6636:

Re: [PR] HADOOP-19114. Upgrade to commons-compress 1.26.1 due to CVEs. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6636: URL: https://github.com/apache/hadoop/pull/6636#issuecomment-2007664941 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19115) upgrade to nimbus-jose-jwt 9.37.2 due to CVE

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828438#comment-17828438 ] ASF GitHub Bot commented on HADOOP-19115: - hadoop-yetus commented on PR #6637:

Re: [PR] HADOOP-19115. Upgrade to nimbus-jose-jwt 9.37.2 due to CVE. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6637: URL: https://github.com/apache/hadoop/pull/6637#issuecomment-2007632453 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-5305. Allow log aggregation to discard expired delegation tokens [hadoop]

2024-03-19 Thread via GitHub
p-szucs commented on code in PR #6625: URL: https://github.com/apache/hadoop/pull/6625#discussion_r1530716191 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppL

[jira] [Commented] (HADOOP-19116) update to zookeeper client 3.8.4 due to CVE

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828436#comment-17828436 ] ASF GitHub Bot commented on HADOOP-19116: - hadoop-yetus commented on PR #6638:

Re: [PR] HADOOP-19116. Update to zookeeper client 3.8.4 due to CVE. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6638: URL: https://github.com/apache/hadoop/pull/6638#issuecomment-2007616577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-5305. Allow log aggregation to discard expired delegation tokens [hadoop]

2024-03-19 Thread via GitHub
K0K0V0K commented on code in PR #6625: URL: https://github.com/apache/hadoop/pull/6625#discussion_r1530670402 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppL

Re: [PR] HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6641: URL: https://github.com/apache/hadoop/pull/6641#issuecomment-2007547095 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19112) Hadoop 3.4.0 release wrap-up

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828352#comment-17828352 ] ASF GitHub Bot commented on HADOOP-19112: - hadoop-yetus commented on PR #6640:

Re: [PR] HADOOP-19112. Hadoop 3.4.0 release wrap-up. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6640: URL: https://github.com/apache/hadoop/pull/6640#issuecomment-2007274658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828342#comment-17828342 ] ASF GitHub Bot commented on HADOOP-19119: - hadoop-yetus commented on PR #6642:

Re: [PR] HADOOP-19119. Spotbugs: possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize() [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6642: URL: https://github.com/apache/hadoop/pull/6642#issuecomment-2007214433 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2007163057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
wzk784533 commented on PR #6643: URL: https://github.com/apache/hadoop/pull/6643#issuecomment-2007159204 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[jira] [Updated] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2024-03-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-18487: Fix Version/s: (was: 3.4.0) > Make protobuf 2.5 an optional runtime dependency. > ---

[jira] [Updated] (HADOOP-19089) [ABFS] Reverting Back Support of setXAttr() and getXAttr() on root path

2024-03-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-19089: Fix Version/s: (was: 3.4.0) > [ABFS] Reverting Back Support of setXAttr() and getXAttr() on r

[jira] [Resolved] (HADOOP-19018) Release Hadoop 3.4.0

2024-03-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan resolved HADOOP-19018. - Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Release Hadoop 3.4.

[jira] [Resolved] (HADOOP-19112) Hadoop 3.4.0 release wrap-up

2024-03-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan resolved HADOOP-19112. - Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Hadoop 3.4.0 releas

[jira] [Resolved] (HADOOP-19117) 3.4.0 release documents

2024-03-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan resolved HADOOP-19117. - Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > 3.4.0 release docum

[jira] [Updated] (HADOOP-19117) 3.4.0 release documents

2024-03-19 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-19117: Target Version/s: 3.4.0 > 3.4.0 release documents > --- > > K

[jira] [Commented] (HADOOP-19112) Hadoop 3.4.0 release wrap-up

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828301#comment-17828301 ] ASF GitHub Bot commented on HADOOP-19112: - slfan1989 commented on PR #6640: URL

Re: [PR] HADOOP-19112. Hadoop 3.4.0 release wrap-up. [hadoop]

2024-03-19 Thread via GitHub
slfan1989 commented on PR #6640: URL: https://github.com/apache/hadoop/pull/6640#issuecomment-2007013296 @Hexiaoqiao Thank you very much for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HADOOP-19112. Hadoop 3.4.0 release wrap-up. [hadoop]

2024-03-19 Thread via GitHub
slfan1989 merged PR #6640: URL: https://github.com/apache/hadoop/pull/6640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HADOOP-19117. 3.4.0 release documents. [hadoop-site]

2024-03-19 Thread via GitHub
slfan1989 commented on PR #53: URL: https://github.com/apache/hadoop-site/pull/53#issuecomment-2007011255 @steveloughran @Hexiaoqiao Thank you very much for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HADOOP-19117. 3.4.0 release documents. [hadoop-site]

2024-03-19 Thread via GitHub
slfan1989 merged PR #53: URL: https://github.com/apache/hadoop-site/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[PR] HDFS-17431. Fix log format for BlockRecoveryWorker#recoverBlocks [hadoop]

2024-03-19 Thread via GitHub
haiyang1987 opened a new pull request, #6643: URL: https://github.com/apache/hadoop/pull/6643 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17431 Fix log format for BlockRecoveryWorker#recoverBlocks -- This is an automated message from the Apache Git Service. To re

[jira] [Updated] (HADOOP-19114) upgrade to commons-compress 1.26.1 due to cves

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19114: Component/s: build CVE > upgrade to commons-compress 1.26.1 due to cves

[jira] [Updated] (HADOOP-19114) upgrade to commons-compress 1.26.1 due to cves

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19114: Affects Version/s: 3.4.0 > upgrade to commons-compress 1.26.1 due to cves > -

[jira] [Updated] (HADOOP-19115) upgrade to nimbus-jose-jwt 9.37.2 due to CVE

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19115: Component/s: build CVE > upgrade to nimbus-jose-jwt 9.37.2 due to CVE >

[jira] [Updated] (HADOOP-19115) upgrade to nimbus-jose-jwt 9.37.2 due to CVE

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19115: Affects Version/s: 3.4.0 3.5.0 > upgrade to nimbus-jose-jwt 9.37.2

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2006966559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11656 RMStateStore event queue blocked [hadoop]

2024-03-19 Thread via GitHub
p-szucs commented on code in PR #6569: URL: https://github.com/apache/hadoop/pull/6569#discussion_r1530182598 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/multidispatcher/MultiDispatcherExecutor.java: ## @@ -0,0 +1,122 @@ +/**

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-03-19 Thread via GitHub
aajisaka commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2006945704 -1. Please do not change the following `@Public` and `@Evolving` classes: - QuotaExceededException.java - DSQuotaExceededException.java > https://apache.github.io/hadoop/h

[jira] [Updated] (HADOOP-19116) update to zookeeper client 3.8.4 due to CVE

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19116: Affects Version/s: 3.3.6 3.4.0 > update to zookeeper client 3.8.4

[jira] [Commented] (HADOOP-19116) update to zookeeper client 3.8.4 due to CVE

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828287#comment-17828287 ] Steve Loughran commented on HADOOP-19116: - I've just created a new component "C

[jira] [Updated] (HADOOP-19116) update to zookeeper client 3.8.4 due to CVE

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19116: Component/s: CVE > update to zookeeper client 3.8.4 due to CVE >

Re: [PR] HADOOP-19117. 3.4.0 release documents. [hadoop-site]

2024-03-19 Thread via GitHub
steveloughran commented on PR #53: URL: https://github.com/apache/hadoop-site/pull/53#issuecomment-2006936741 Really tips github PR review over the edge. I've trusted the generated job to be good and just verified that the links in the existing pages have been updated. All good! -- This

Re: [PR] WIP: ApacheHttpClient adaptation in ABFS. [hadoop]

2024-03-19 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2006936579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19119: Labels: pull-request-available (was: ) > spotbugs complaining about possible NPE in > o

[jira] [Commented] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828282#comment-17828282 ] ASF GitHub Bot commented on HADOOP-19119: - steveloughran opened a new pull requ

[PR] HADOOP-19119. Spotbugs: possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize() [hadoop]

2024-03-19 Thread via GitHub
steveloughran opened a new pull request, #6642: URL: https://github.com/apache/hadoop/pull/6642 Spotbugs is mistaken here as it doesn't observer the read/write locks used to manage exclusive access to the maps. * cache the value between checks * tag as @VisibleForTesting

[jira] [Updated] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.getSize()

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19119: Summary: spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.Valu

[jira] [Created] (HADOOP-19119) spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.alueQueue.getSize()

2024-03-19 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19119: --- Summary: spotbugs complaining about possible NPE in org.apache.hadoop.crypto.key.kms.ValueQueue.alueQueue.getSize() Key: HADOOP-19119 URL: https://issues.apache.org/jira/bro

[jira] [Commented] (HADOOP-19100) Fix Spotbugs warnings in the build

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828280#comment-17828280 ] Steve Loughran commented on HADOOP-19100: - PRs against hadoop-common are report

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828279#comment-17828279 ] Steve Loughran commented on HADOOP-19085: - One thing I'd like to say is: what a

[jira] [Updated] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19085: Component/s: fs test > Compatibility Benchmark over HCFS Implementations

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828278#comment-17828278 ] Steve Loughran commented on HADOOP-19085: - bq. The patch was just committed I

[jira] [Updated] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-19 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19085: Fix Version/s: 3.5.0 > Compatibility Benchmark over HCFS Implementations > --

[jira] [Updated] (HADOOP-19118) KeyShell fails with NPE when KMS throws Exception with null as message

2024-03-19 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dénes Bodó updated HADOOP-19118: Description: There is an issue in specific Ranger versions (where RANGER-3989 is not fixed) whic

[jira] [Created] (HADOOP-19118) KeyShell fails with NPE when KMS throws Exception with null as message

2024-03-19 Thread Jira
Dénes Bodó created HADOOP-19118: --- Summary: KeyShell fails with NPE when KMS throws Exception with null as message Key: HADOOP-19118 URL: https://issues.apache.org/jira/browse/HADOOP-19118 Project: Hadoo

[PR] HDFS-17413. [FGL] CacheReplicationMonitor supports fine-grained lock [hadoop]

2024-03-19 Thread via GitHub
ZanderXu opened a new pull request, #6641: URL: https://github.com/apache/hadoop/pull/6641 Using FSLock to make cache-pool and cache-directive thread safe, since Clients will access or modify these information and these information has nothing to do with block. Using BMLock to make c

  1   2   >