[PR] Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-06 Thread via GitHub
fuchaohong opened a new pull request, #6713: URL: https://github.com/apache/hadoop/pull/6713 … file. ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6709: URL: https://github.com/apache/hadoop/pull/6709#issuecomment-2041337533 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6709: URL: https://github.com/apache/hadoop/pull/6709#discussion_r1554813666 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java: ## @@ -1201,7 +1201,9 @@ private void lostFoundInit(D

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6709: URL: https://github.com/apache/hadoop/pull/6709#discussion_r1554813666 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java: ## @@ -1201,7 +1201,9 @@ private void lostFoundInit(D

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
hiwangzhihui commented on code in PR #6709: URL: https://github.com/apache/hadoop/pull/6709#discussion_r1554813100 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java: ## @@ -1201,7 +1201,9 @@ private void lostFoundInit(DFSCl

Re: [PR] HDFS-17383:Datanode current block token should come from active NameNode in HA mode [hadoop]

2024-04-06 Thread via GitHub
zhangshuyan0 commented on PR #6562: URL: https://github.com/apache/hadoop/pull/6562#issuecomment-2041304944 There a problem with this fix. Assuming the following situation: 1. nn1 and nn2 are both standby, and after dn1 registers with them, its currentKey is null; 2. nn1 is transitione

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-06 Thread via GitHub
haiyang1987 commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2041284092 Hi @ZanderXu @Hexiaoqiao @ayushtkn @zhangshuyan0 please help me review this PR when you are free, thanks ~ -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-19078) reduce use of javax.ws.rs.core.MediaType

2024-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834579#comment-17834579 ] ASF GitHub Bot commented on HADOOP-19078: - hadoop-yetus commented on PR #6555:

Re: [PR] HADOOP-19078. Reduce use of javax.ws.rs.core.MediaType [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6555: URL: https://github.com/apache/hadoop/pull/6555#issuecomment-2041275189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19145) Software Architecture Document

2024-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834571#comment-17834571 ] ASF GitHub Bot commented on HADOOP-19145: - hadoop-yetus commented on PR #6712:

Re: [PR] HADOOP-19145. Add software architecture document [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6712: URL: https://github.com/apache/hadoop/pull/6712#issuecomment-2041227076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Updated] (HADOOP-19145) Software Architecture Document

2024-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19145: Labels: architecture docuentation pull-request-available software-engineering (was: arch

[jira] [Commented] (HADOOP-19145) Software Architecture Document

2024-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834568#comment-17834568 ] ASF GitHub Bot commented on HADOOP-19145: - lkhorasandzhian opened a new pull re

[PR] HADOOP-19145. Add software architecture document [hadoop]

2024-04-06 Thread via GitHub
lkhorasandzhian opened a new pull request, #6712: URL: https://github.com/apache/hadoop/pull/6712 Add SAD of Apache Hadoop and folders with essential diagrams. [Link to the published issue is here](https://issues.apache.org/jira/browse/HADOOP-19145) ### Description of PR We

[jira] [Created] (HADOOP-19145) Software Architecture Document

2024-04-06 Thread Levon Khorasandzhian (Jira)
Levon Khorasandzhian created HADOOP-19145: - Summary: Software Architecture Document Key: HADOOP-19145 URL: https://issues.apache.org/jira/browse/HADOOP-19145 Project: Hadoop Common Is

[jira] [Updated] (HADOOP-19145) Software Architecture Document

2024-04-06 Thread Levon Khorasandzhian (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levon Khorasandzhian updated HADOOP-19145: -- Description: We (GitHub @lkhorasandzhian & @vacherkasskiy) have prepared feat

[jira] [Commented] (HADOOP-19136) Upgrade commons-io to 2.16.0

2024-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834555#comment-17834555 ] ASF GitHub Bot commented on HADOOP-19136: - hadoop-yetus commented on PR #6704:

Re: [PR] HADOOP-19136. Upgrade commons-io to 2.16.0. [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6704: URL: https://github.com/apache/hadoop/pull/6704#issuecomment-2041174987 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2041157433 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19072) S3A: expand optimisations on stores with "fs.s3a.create.performance"

2024-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834548#comment-17834548 ] ASF GitHub Bot commented on HADOOP-19072: - virajjasani commented on code in PR

Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-04-06 Thread via GitHub
virajjasani commented on code in PR #6543: URL: https://github.com/apache/hadoop/pull/6543#discussion_r1554648819 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MkdirOperation.java: ## @@ -124,7 +132,32 @@ public Boolean execute() throws IOException {

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6709: URL: https://github.com/apache/hadoop/pull/6709#issuecomment-2041150281 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6709: URL: https://github.com/apache/hadoop/pull/6709#issuecomment-2041148709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6709: URL: https://github.com/apache/hadoop/pull/6709#issuecomment-2041147563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Test PR: Test Jenkins. (WIP) [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6707: URL: https://github.com/apache/hadoop/pull/6707#issuecomment-2041105167 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-04-06 Thread via GitHub
hiwangzhihui commented on code in PR #6352: URL: https://github.com/apache/hadoop/pull/6352#discussion_r1554610415 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java: #

Re: [PR] Test PR: Test Jenkins. (WIP) [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6707: URL: https://github.com/apache/hadoop/pull/6707#issuecomment-2041081384 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Test PR: Test Jenkins. (WIP) [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6707: URL: https://github.com/apache/hadoop/pull/6707#issuecomment-2041079533 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6709: URL: https://github.com/apache/hadoop/pull/6709#discussion_r1554551429 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java: ## @@ -1201,7 +1200,7 @@ private void lostFoundInit(D

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-04-06 Thread via GitHub
shameersss1 commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2041016095 > the checkstyle is because it wants `./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/` to have a package class describing it >

Re: [PR] HDFS-17453. IncrementalBlockReport can have race condition with Edit Log Tailer [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6708: URL: https://github.com/apache/hadoop/pull/6708#issuecomment-2041015894 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17449. catch the IndexOutOfBounds and throw IllegalArgument instead [hadoop]

2024-04-06 Thread via GitHub
ayushtkn merged PR #6691: URL: https://github.com/apache/hadoop/pull/6691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log. [hadoop]

2024-04-06 Thread via GitHub
ayushtkn commented on code in PR #6709: URL: https://github.com/apache/hadoop/pull/6709#discussion_r1554546040 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java: ## @@ -1201,7 +1200,7 @@ private void lostFoundInit(DFSClient

Re: [PR] HDFS-17453. IncrementalBlockReport can have race condition with Edit Log Tailer [hadoop]

2024-04-06 Thread via GitHub
hadoop-yetus commented on PR #6708: URL: https://github.com/apache/hadoop/pull/6708#issuecomment-2040998440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-04-06 Thread via GitHub
shameersss1 commented on code in PR #6631: URL: https://github.com/apache/hadoop/pull/6631#discussion_r1554538806 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java: ## @@ -41,8 +42,7 @@ @Inter