Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1568309941 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java: ## @@ -165,5 +165,7 @@ public static ApiVersion getCurren

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1568309941 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java: ## @@ -165,5 +165,7 @@ public static ApiVersion getCurren

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837986#comment-17837986 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837985#comment-17837985 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837984#comment-17837984 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1568309007 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -848,32 +848,37 @@ public AbfsInputStream openFileForR

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ZanderXu commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568286270 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== +

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ferhui commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568281919 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== + +

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ferhui commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568281027 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== + +

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-16 Thread via GitHub
snvijaya commented on code in PR #6716: URL: https://github.com/apache/hadoop/pull/6716#discussion_r1567404776 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/stages/CleanupJobStage.

[jira] [Commented] (HADOOP-19130) FTPFileSystem rename with full qualified path broken

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837964#comment-17837964 ] ASF GitHub Bot commented on HADOOP-19130: - zj619 commented on code in PR #6678:

Re: [PR] HADOOP-19130. FTPFileSystem rename with full qualified path broken [hadoop]

2024-04-16 Thread via GitHub
zj619 commented on code in PR #6678: URL: https://github.com/apache/hadoop/pull/6678#discussion_r1568220170 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/ftp/TestFTPFileSystem.java: ## @@ -60,6 +62,9 @@ public class TestFTPFileSystem { @Rule pub

[jira] [Commented] (HADOOP-19130) FTPFileSystem rename with full qualified path broken

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837963#comment-17837963 ] ASF GitHub Bot commented on HADOOP-19130: - zj619 commented on code in PR #6678:

Re: [PR] HADOOP-19130. FTPFileSystem rename with full qualified path broken [hadoop]

2024-04-16 Thread via GitHub
zj619 commented on code in PR #6678: URL: https://github.com/apache/hadoop/pull/6678#discussion_r1568219463 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ftp/FTPFileSystem.java: ## @@ -685,21 +685,21 @@ private boolean rename(FTPClient client, Path sr

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2060343659 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ZanderXu commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568168688 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== +

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837952#comment-17837952 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2060283113 Hi @steveloughran , thank you a lot for the review. Have taken the comments. Have taken assertj in the new test util class. Class `ITestAbfsInputStreamFooter` is now extending `Abstra

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837950#comment-17837950 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060278478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837948#comment-17837948 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567168026 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ferhui commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2060276815 @kokonguyen191 Thanks for contribution. Left some comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ferhui commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568165869 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== + +

[PR] HDFS-17472. [FGL] gcDeletedSnapshot and getDelegationToken support FGL [hadoop]

2024-04-16 Thread via GitHub
ZanderXu opened a new pull request, #6743: URL: https://github.com/apache/hadoop/pull/6743 [FGL] gcDeletedSnapshot and getDelegationToken support FGL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-16 Thread via GitHub
ZanderXu opened a new pull request, #6741: URL: https://github.com/apache/hadoop/pull/6741 [FGL] UTs support fine-grained locking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837923#comment-17837923 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060158389 > there are downstream modules which depend on bc from hadoop common. they need to be adjusted so their poms declare explicit use. ... It make sense for the downstream modules addin

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837922#comment-17837922 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060155541 > the pr cuts out all bouncy castle init. What will break? @steveloughran , thanks for looking at this! As mentioned in `core-default.xml`, could we ask admin to set java.securit

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837905#comment-17837905 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060001044 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837904#comment-17837904 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2059994340 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6739: URL: https://github.com/apache/hadoop/pull/6739#discussion_r1567940219 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java: ## @@ -35,7 +34,6 @@ import java.util.Map; import java.util.O

[jira] [Commented] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-16 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837883#comment-17837883 ] Steve Loughran commented on HADOOP-19150: - actually, it should be {code} Abf

[jira] [Updated] (HADOOP-19151) Support configurable SASL mechanism

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19151: Labels: pull-request-available (was: ) > Support configurable SASL mechanism > -

[jira] [Commented] (HADOOP-19151) Support configurable SASL mechanism

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837881#comment-17837881 ] ASF GitHub Bot commented on HADOOP-19151: - szetszwo opened a new pull request,

[PR] HADOOP-19151. Support configurable SASL mechanism. [hadoop]

2024-04-16 Thread via GitHub
szetszwo opened a new pull request, #6740: URL: https://github.com/apache/hadoop/pull/6740 ### Description of PR Currently, the SASL mechanism is hard coded to DIGEST-MD5. As mentioned in [HADOOP-14811](https://issues.apache.org/jira/browse/HADOOP-14811), DIGEST-MD5 is known to be in

Re: [PR] HDFS-17381. Distcp of EC files should not be limited to DFS. [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6551: URL: https://github.com/apache/hadoop/pull/6551#discussion_r1567914216 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableDirectoryCreateCommand.java: ## @@ -67,31 +67,13 @@ protected Object doExecute(

Re: [PR] HADOOP-19124. Update org.ehcache from 3.3.1 to 3.8.2. (#6665) [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6705: URL: https://github.com/apache/hadoop/pull/6705#issuecomment-2059872469 yeah, 3.3 is a different complication...if things are hard it's good to go through yetus. going from 3.5 to 3.4 locally I often locally cherrypick, run any new/changed tests and then

[jira] [Commented] (HADOOP-19124) Update org.ehcache from 3.3.1 to 3.8.2.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837876#comment-17837876 ] ASF GitHub Bot commented on HADOOP-19124: - steveloughran commented on PR #6705:

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6629: URL: https://github.com/apache/hadoop/pull/6629#discussion_r1567902995 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/pom.xml: ## @@ -494,86 +489,12 @@

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837874#comment-17837874 ] ASF GitHub Bot commented on HADOOP-19107: - steveloughran commented on code in P

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837871#comment-17837871 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on code in P

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
mukund-thakur commented on code in PR #6726: URL: https://github.com/apache/hadoop/pull/6726#discussion_r1567902648 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractBulkDelete.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Sof

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6735: URL: https://github.com/apache/hadoop/pull/6735#issuecomment-2059825741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837853#comment-17837853 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo opened a new pull request,

[jira] [Commented] (HADOOP-19136) Upgrade commons-io to 2.16.0

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837846#comment-17837846 ] ASF GitHub Bot commented on HADOOP-19136: - hadoop-yetus commented on PR #6704:

Re: [PR] HADOOP-19136. Upgrade commons-io to 2.16.0. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6704: URL: https://github.com/apache/hadoop/pull/6704#issuecomment-2059798218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Created] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread Tsz-wo Sze (Jira)
Tsz-wo Sze created HADOOP-19152: --- Summary: Do not hard code security providers. Key: HADOOP-19152 URL: https://issues.apache.org/jira/browse/HADOOP-19152 Project: Hadoop Common Issue Type: Impr

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2059736403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Created] (HADOOP-19151) Support configurable SASL mechanism

2024-04-16 Thread Tsz-wo Sze (Jira)
Tsz-wo Sze created HADOOP-19151: --- Summary: Support configurable SASL mechanism Key: HADOOP-19151 URL: https://issues.apache.org/jira/browse/HADOOP-19151 Project: Hadoop Common Issue Type: Impro

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837813#comment-17837813 ] ASF GitHub Bot commented on HADOOP-19107: - ayushtkn commented on code in PR #66

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-16 Thread via GitHub
ayushtkn commented on code in PR #6629: URL: https://github.com/apache/hadoop/pull/6629#discussion_r1567765826 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-server/hadoop-yarn-server-timelineservic

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837811#comment-17837811 ] ASF GitHub Bot commented on HADOOP-19107: - hadoop-yetus commented on PR #6629:

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6629: URL: https://github.com/apache/hadoop/pull/6629#issuecomment-2059664011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2059643011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Created] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-16 Thread Mukund Thakur (Jira)
Mukund Thakur created HADOOP-19150: -- Summary: Test ITestAbfsRestOperationException#testAuthFailException is broken. Key: HADOOP-19150 URL: https://issues.apache.org/jira/browse/HADOOP-19150 Project:

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837802#comment-17837802 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2059595712 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Created] (HADOOP-19149) ABFS: Implement ThreadLocal for ObjectMapper in AzureHttpOperation via config option with static shared instance as an alternative.

2024-04-16 Thread Mukund Thakur (Jira)
Mukund Thakur created HADOOP-19149: -- Summary: ABFS: Implement ThreadLocal for ObjectMapper in AzureHttpOperation via config option with static shared instance as an alternative. Key: HADOOP-19149 URL: https://is

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-16 Thread via GitHub
tomicooler commented on code in PR #6732: URL: https://github.com/apache/hadoop/pull/6732#discussion_r1567660577 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Abstra

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837775#comment-17837775 ] ASF GitHub Bot commented on HADOOP-18679: - hadoop-yetus commented on PR #6738:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6738: URL: https://github.com/apache/hadoop/pull/6738#issuecomment-2059423509 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837744#comment-17837744 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2059255931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837741#comment-17837741 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2059240094 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-16 Thread via GitHub
slfan1989 commented on code in PR #6732: URL: https://github.com/apache/hadoop/pull/6732#discussion_r1567460352 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Abstrac

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837728#comment-17837728 ] ASF GitHub Bot commented on HADOOP-19129: - steveloughran commented on PR #6676:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6676: URL: https://github.com/apache/hadoop/pull/6676#issuecomment-2059164245 @anujmodi2021 can you do a PR for this for branch-3.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837722#comment-17837722 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on PR #6726:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2059138849 commented. I've also done a PR #6738 which tunes the API to work with iceberg, having just written a PoC of the iceberg binding. My PR * moved the wrapper methods to a new

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2059128762 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837718#comment-17837718 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2059115354 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837717#comment-17837717 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on code in P

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6726: URL: https://github.com/apache/hadoop/pull/6726#discussion_r1566433464 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/bulkdelete.md: ## @@ -0,0 +1,284 @@ + + +# interface `BulkDelete` Review Comment: needs to

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837716#comment-17837716 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on PR #6738:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6738: URL: https://github.com/apache/hadoop/pull/6738#issuecomment-2059110117 This is #6726 with another commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837715#comment-17837715 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2059102749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837710#comment-17837710 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran opened a new pull requ

[PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran opened a new pull request, #6738: URL: https://github.com/apache/hadoop/pull/6738 ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integra

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2058962419 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-16 Thread via GitHub
anmolanmol1234 commented on code in PR #6716: URL: https://github.com/apache/hadoop/pull/6716#discussion_r1567132937 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/ManifestCommitter

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837690#comment-17837690 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2058922165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567230524 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable getStr

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6735: URL: https://github.com/apache/hadoop/pull/6735#issuecomment-2058881480 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567205509 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable getStr

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837682#comment-17837682 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2058878425 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567203473 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java: ## @@ -628,25 +638,59 @@ private void loadRootINode(INo

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567198629 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclEntryStatusFormat.java: ## @@ -47,7 +47,7 @@ public enum AclEntryStatusFormat i

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837676#comment-17837676 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567171371 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStreamReadFooter.java: ## @@ -54,9 +63,44 @@ public class ITestAbfsI

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837674#comment-17837674 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567168026 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache

  1   2   >