Re: [PR] MAPREDUCE-7402. fix mapreduce.task.io.sort.factor=1 lead to an infinite loop. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6622: URL: https://github.com/apache/hadoop/pull/6622#issuecomment-2103907810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19167) Change of Codec configuration does not work

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845202#comment-17845202 ] ASF GitHub Bot commented on HADOOP-19167: - hadoop-yetus commented on PR #6807: URL:

Re: [PR] HADOOP-19167 Bug Fix: Change of Codec configuration does not work [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6807: URL: https://github.com/apache/hadoop/pull/6807#issuecomment-2103901140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] MAPREDUCE-7402. fix mapreduce.task.io.sort.factor=1 lead to an infinite loop. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6622: URL: https://github.com/apache/hadoop/pull/6622#issuecomment-2103892286 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-09 Thread via GitHub
ferhui commented on code in PR #6806: URL: https://github.com/apache/hadoop/pull/6806#discussion_r1596215333 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/fgl/FSNLockBenchmarkThroughput.java: ## @@ -0,0 +1,269 @@ +/** + * Licensed to

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
ZanderXu commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1596217290 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-09 Thread via GitHub
ferhui commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2103801948 > > Thanks. What is the purpose of this PR? Provide a benchmark tool and each one can test the HDFS cluster performance? or just test the namenode performance locally? > >

Re: [PR] HDFS-17503. Unreleased volume references because of OOM. [hadoop]

2024-05-09 Thread via GitHub
zhuzilong2013 commented on PR #6782: URL: https://github.com/apache/hadoop/pull/6782#issuecomment-2103787150 Thanks @ZanderXu for your review and merge~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845178#comment-17845178 ] ASF GitHub Bot commented on HADOOP-18851: - ChenSammi commented on PR #6803: URL:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-09 Thread via GitHub
ChenSammi commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2103782158 > @ChenSammi , Please add your input as well in case I missed anything. Thanks. Yes, removing the synchronized directly have potential risks to sub classes of

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1596189673 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] HDFS-17503. Unreleased volume references because of OOM. [hadoop]

2024-05-09 Thread via GitHub
ZanderXu commented on PR #6782: URL: https://github.com/apache/hadoop/pull/6782#issuecomment-2103752898 Merged. Thanks @zhuzilong2013 for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17503. Unreleased volume references because of OOM. [hadoop]

2024-05-09 Thread via GitHub
ZanderXu merged PR #6782: URL: https://github.com/apache/hadoop/pull/6782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
ZanderXu commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1596183555 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-09 Thread via GitHub
ZanderXu commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2103741784 > Thanks. What is the purpose of this PR? Provide a benchmark tool and each one can test the HDFS cluster performance? or just test the namenode performance locally?

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-09 Thread via GitHub
ferhui commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2103691546 Thanks. What is the purpose of this PR? Provide a benchmark tool and each one can test the HDFS cluster performance? or just test the namenode performance locally? -- This is an

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2103686670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2103647255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17476. fix: False positive "Observer Node is too far behind" due to long overflow. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6747: URL: https://github.com/apache/hadoop/pull/6747#issuecomment-2103618886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-16368. DFSadmin supports refresh topology info without restarting namenode [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #3743: URL: https://github.com/apache/hadoop/pull/3743#issuecomment-2103598386 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2103584427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845140#comment-17845140 ] ASF GitHub Bot commented on HADOOP-18508: - hadoop-yetus commented on PR #5081: URL:

Re: [PR] HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2103496441 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-2103362606 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17276. Fix the nn fetch editlog forbidden in kerberos environment [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6326: URL: https://github.com/apache/hadoop/pull/6326#issuecomment-2103056076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845063#comment-17845063 ] ASF GitHub Bot commented on HADOOP-18958: - hadoop-yetus commented on PR #6255: URL:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6255: URL: https://github.com/apache/hadoop/pull/6255#issuecomment-2103047392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to Custom SASTokenProvider Implementation

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844991#comment-17844991 ] ASF GitHub Bot commented on HADOOP-18516: - hadoop-yetus commented on PR #6552: URL:

Re: [PR] HADOOP-18516: [ABFS][Authentication] Support Fixed SAS Token for ABFS Authentication [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6552: URL: https://github.com/apache/hadoop/pull/6552#issuecomment-2102708307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19136) Upgrade commons-io to 2.16.1

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844987#comment-17844987 ] ASF GitHub Bot commented on HADOOP-19136: - hadoop-yetus commented on PR #6704: URL:

Re: [PR] HADOOP-19136. Upgrade commons-io to 2.16.1. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6704: URL: https://github.com/apache/hadoop/pull/6704#issuecomment-2102668027 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19131) Assist reflection IO with WrappedOperations class

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844984#comment-17844984 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686: URL:

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2102654014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2102606424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844977#comment-17844977 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844971#comment-17844971 ] ASF GitHub Bot commented on HADOOP-18851: - vikaskr22 commented on PR #6803: URL:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-09 Thread via GitHub
vikaskr22 commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2102594497 Hi @Hexiaoqiao , technically I didn't see or observe any issues till now but @ChenSammi has some concerns related to concurrency in other sub classes of

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1595385718 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844953#comment-17844953 ] ASF GitHub Bot commented on HADOOP-18679: - hadoop-yetus commented on PR #6726: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2102481437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1595273510 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1595269674 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
ZanderXu commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1595242159 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-09 Thread via GitHub
ZanderXu commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1595242159 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -667,39 +667,28 @@ public void

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2102258570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17515. Erasure Coding: ErasureCodingWork is not effectively limi… [hadoop]

2024-05-09 Thread via GitHub
zhengchenyu closed pull request #6805: HDFS-17515. Erasure Coding: ErasureCodingWork is not effectively limi… URL: https://github.com/apache/hadoop/pull/6805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HDFS-17515. Erasure Coding: ErasureCodingWork is not effectively limi… [hadoop]

2024-05-09 Thread via GitHub
zhengchenyu commented on PR #6805: URL: https://github.com/apache/hadoop/pull/6805#issuecomment-2102237952 Not ready for review! Wait for HDFS-17516! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-19167) Change of Codec configuration does not work

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844925#comment-17844925 ] ASF GitHub Bot commented on HADOOP-19167: - skyskyhu opened a new pull request, #6807: URL:

[PR] HADOOP-19167 Bug Fix: Change of Codec configuration does not work [hadoop]

2024-05-09 Thread via GitHub
skyskyhu opened a new pull request, #6807: URL: https://github.com/apache/hadoop/pull/6807 [HADOOP-19167](https://issues.apache.org/jira/browse/HADOOP-19167) Change of Codec configuration does not work ### Description of PR In one of my projects, I need to dynamically adjust

[jira] [Commented] (HADOOP-19167) Change of Codec configuration does not work

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844920#comment-17844920 ] ASF GitHub Bot commented on HADOOP-19167: - skyskyhu closed pull request #6798: HADOOP-19167 Bug

Re: [PR] HADOOP-19167 Bug Fix: Change of Codec configuration does not work [hadoop]

2024-05-09 Thread via GitHub
skyskyhu closed pull request #6798: HADOOP-19167 Bug Fix: Change of Codec configuration does not work URL: https://github.com/apache/hadoop/pull/6798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17503. Unreleased volume references because of OOM. [hadoop]

2024-05-09 Thread via GitHub
zhuzilong2013 commented on PR #6782: URL: https://github.com/apache/hadoop/pull/6782#issuecomment-2102119137 @Hexiaoqiao Hi~ sir. Could you please help me review this PR when you are free? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HDFS-17504. DN process should exit when BPServiceActor exit [hadoop]

2024-05-09 Thread via GitHub
zhuzilong2013 commented on PR #6792: URL: https://github.com/apache/hadoop/pull/6792#issuecomment-2102118561 @Hexiaoqiao Hi~ sir. Could you please help me review this PR when you are free? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-09 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1595039239 ## hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md: ## @@ -879,6 +879,42 @@ hierarchical namespace enabled, and set the following configuration

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844883#comment-17844883 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR #6787: URL:

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844882#comment-17844882 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR #6787: URL:

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-09 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1595038507 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-18610) ABFS OAuth2 Token Provider to support Azure Workload Identity for AKS

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844881#comment-17844881 ] ASF GitHub Bot commented on HADOOP-18610: - anujmodi2021 commented on code in PR #6787: URL:

Re: [PR] HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity [hadoop]

2024-05-09 Thread via GitHub
anujmodi2021 commented on code in PR #6787: URL: https://github.com/apache/hadoop/pull/6787#discussion_r1595037949 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java: ## @@ -0,0 +1,144 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844879#comment-17844879 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

[PR] HDFS-17515. Erasure Coding: ErasureCodingWork is not effectively limi… [hadoop]

2024-05-09 Thread via GitHub
zhengchenyu opened a new pull request, #6805: URL: https://github.com/apache/hadoop/pull/6805 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17515 ### How was this patch tested? unit test ### For code changes: - Add

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2102051696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-09 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594952346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void

Re: [PR] [DRAFT] Jackson 2.14 [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6761: URL: https://github.com/apache/hadoop/pull/6761#issuecomment-2102033031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks