Re: [PR] HDFS-16368. DFSadmin supports refresh topology info without restarting namenode [hadoop]

2024-05-14 Thread via GitHub
hfutatzhanghb commented on PR #3743: URL: https://github.com/apache/hadoop/pull/3743#issuecomment-2111693845 > Not sure why this PR has been pick up again. IIRC we have discussed add tools to support refresh topology online many times. I would like to share my concern again. This is one hig

Re: [PR] YARN-11469. [BackPort] Refactor FederationStateStoreFacade Cache Code. (#5570) [hadoop]

2024-05-14 Thread via GitHub
slfan1989 commented on PR #6796: URL: https://github.com/apache/hadoop/pull/6796#issuecomment-2111643363 @steveloughran @goiri We are backporting `YARN-11469` to branch-3.3 in order to upgrade ehcache from `3.3.1` to `3.8.2`. However, there are significant differences between the code in br

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846489#comment-17846489 ] ASF GitHub Bot commented on HADOOP-19013: - hadoop-yetus commented on PR #6646:

Re: [PR] HADOOP-19013. Adding x-amz-server-side-encryption-aws-kms-key-id in the get file attributes for S3A. [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6646: URL: https://github.com/apache/hadoop/pull/6646#issuecomment-2111558054 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846477#comment-17846477 ] ASF GitHub Bot commented on HADOOP-19170: - zhengchenyu commented on PR #6827: U

Re: [PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
zhengchenyu commented on PR #6827: URL: https://github.com/apache/hadoop/pull/6827#issuecomment-2111467319 > thanks, merged to trunk. If you do a PR cherrypicking this against hadoop branch-3.4 I'll commit it there as soon as yetus is happy...no need for any code review. Yes, this is

Re: [PR] YARN-11469. [BackPort] Refactor FederationStateStoreFacade Cache Code. (#5570) [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6796: URL: https://github.com/apache/hadoop/pull/6796#issuecomment-2111465001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Updated] (HADOOP-19163) Upgrade protobuf version to 3.25.3

2024-05-14 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilwa S T updated HADOOP-19163: --- Summary: Upgrade protobuf version to 3.25.3 (was: Upgrade protobuf version to 3.24.4) > Upgrade p

Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]

2024-05-14 Thread via GitHub
slfan1989 merged PR #6812: URL: https://github.com/apache/hadoop/pull/6812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846459#comment-17846459 ] ASF GitHub Bot commented on HADOOP-19013: - hadoop-yetus commented on PR #6646:

Re: [PR] HADOOP-19013. Adding x-amz-server-side-encryption-aws-kms-key-id in the get file attributes for S3A. [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6646: URL: https://github.com/apache/hadoop/pull/6646#issuecomment-2111294977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19148) Update solr from 8.11.2 to 8.11.3 to address CVE-2023-50298

2024-05-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846458#comment-17846458 ] Viraj Jasani commented on HADOOP-19148: --- [~brahmareddy] is anyone picking this up

[jira] [Commented] (HADOOP-19172) Upgrade aws-java-sdk to 1.12.720

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846457#comment-17846457 ] ASF GitHub Bot commented on HADOOP-19172: - virajjasani commented on PR #6823: U

Re: [PR] HADOOP-19172. S3A: upgrade AWS v1 sdk to 1.12.720 [hadoop]

2024-05-14 Thread via GitHub
virajjasani commented on PR #6823: URL: https://github.com/apache/hadoop/pull/6823#issuecomment-2111241771 +1 (non-binding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] HDFS-17528. FsImageValidation: set txid when saving a new image [hadoop]

2024-05-14 Thread via GitHub
szetszwo opened a new pull request, #6828: URL: https://github.com/apache/hadoop/pull/6828 ### Description of PR - When the fsimage is specified as a file and the FsImageValidation tool saves a new image (for removing inaccessible inodes), the txid is not set. Then, the resulted imag

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2111025819 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846407#comment-17846407 ] ASF GitHub Bot commented on HADOOP-18851: - hadoop-yetus commented on PR #6803:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2111003939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846404#comment-17846404 ] ASF GitHub Bot commented on HADOOP-19139: - steveloughran commented on PR #6699:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2110977633 @saxenapranav can you wait until there's a version of #6789 which adds something to hadoop common to build an enumset from a comma separated list of options? this will allow for easy

[jira] [Assigned] (HADOOP-18786) Hadoop build depends on archives.apache.org

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18786: --- Assignee: Christopher Tubbs > Hadoop build depends on archives.apache.org > --

[jira] [Commented] (HADOOP-18786) Hadoop build depends on archives.apache.org

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846400#comment-17846400 ] ASF GitHub Bot commented on HADOOP-18786: - steveloughran commented on PR #5789:

[jira] [Updated] (HADOOP-18786) Hadoop build depends on archives.apache.org

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18786: Fix Version/s: 3.5.0 > Hadoop build depends on archives.apache.org >

[jira] [Commented] (HADOOP-18786) Hadoop build depends on archives.apache.org

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846399#comment-17846399 ] ASF GitHub Bot commented on HADOOP-18786: - steveloughran merged PR #5789: URL:

Re: [PR] HADOOP-18786. Use CDN instead of ASF archive [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #5789: URL: https://github.com/apache/hadoop/pull/5789#issuecomment-2110965419 thanks, in trunk. can you do a pr cherrypicking to branch-3.4 so we can keep that in sync. No need for more reviews, just a yetus test run. -- This is an automated message from the

Re: [PR] HADOOP-18786. Use CDN instead of ASF archive [hadoop]

2024-05-14 Thread via GitHub
steveloughran merged PR #5789: URL: https://github.com/apache/hadoop/pull/5789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18786) Hadoop build depends on archives.apache.org

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846398#comment-17846398 ] ASF GitHub Bot commented on HADOOP-18786: - steveloughran commented on PR #5789:

Re: [PR] HADOOP-18786. Use CDN instead of ASF archive [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #5789: URL: https://github.com/apache/hadoop/pull/5789#issuecomment-2110961454 ok, let's merge and see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience (#6716) [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #6824: URL: https://github.com/apache/hadoop/pull/6824#issuecomment-2110959526 ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/stages/AbstractJobOrTaskStage.j

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846396#comment-17846396 ] ASF GitHub Bot commented on HADOOP-19170: - steveloughran commented on PR #6827:

Re: [PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #6827: URL: https://github.com/apache/hadoop/pull/6827#issuecomment-2110955296 thanks, merged to trunk. If you do a PR cherrypicking this against hadoop branch-3.4 I'll commit it there as soon as yetus is happy...no need for any code review. -- This is an au

[jira] [Assigned] (HADOOP-18958) Improve UserGroupInformation debug log

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18958: --- Assignee: wangzhihui > Improve UserGroupInformation debug log > -

[jira] [Resolved] (HADOOP-18958) Improve UserGroupInformation debug log

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18958. - Fix Version/s: 3.5.0 Resolution: Fixed > Improve UserGroupInformation debug log

[jira] [Updated] (HADOOP-18958) Improve UserGroupInformation debug log

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18958: Summary: Improve UserGroupInformation debug log (was: UserGroupInformation debug log im

[jira] [Reopened] (HADOOP-18958) UserGroupInformation debug log improve

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reopened HADOOP-18958: - > UserGroupInformation debug log improve > -- > >

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846395#comment-17846395 ] ASF GitHub Bot commented on HADOOP-18958: - steveloughran merged PR #6255: URL:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2024-05-14 Thread via GitHub
steveloughran merged PR #6255: URL: https://github.com/apache/hadoop/pull/6255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846394#comment-17846394 ] ASF GitHub Bot commented on HADOOP-19170: - steveloughran commented on PR #6827:

Re: [PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #6827: URL: https://github.com/apache/hadoop/pull/6827#issuecomment-2110942031 not sure what is up here. lack of a test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2110930846 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19172) Upgrade aws-java-sdk to 1.12.720

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846392#comment-17846392 ] ASF GitHub Bot commented on HADOOP-19172: - steveloughran commented on PR #6823:

Re: [PR] HADOOP-19172. S3A: upgrade AWS v1 sdk to 1.12.720 [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #6823: URL: https://github.com/apache/hadoop/pull/6823#issuecomment-2110926534 @mukund-thakur @ahmarsuhail can I get some review of this. now we don't ship this, it's low risk -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Resolved] (HADOOP-19152) Do not hard code security providers.

2024-05-14 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved HADOOP-19152. - Fix Version/s: 3.5.0 Hadoop Flags: Reviewed Release Note: Added a new conf "hadoop.se

[jira] [Updated] (HADOOP-19171) S3A: handle alternative forms of connection failure

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19171: Description: We've had reports of network connection failures surfacing deeper in the sta

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846386#comment-17846386 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on PR #6739: URL:

[jira] [Updated] (HADOOP-19171) S3A: handle alternative forms of connection failure

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19171: Description: We've had reports of network connection failures surfacing deeper in the sta

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-05-14 Thread via GitHub
szetszwo merged PR #6739: URL: https://github.com/apache/hadoop/pull/6739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-05-14 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2110845650 @steveloughran , thanks a lot for reviewing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846385#comment-17846385 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo merged PR #6739: URL: https

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846384#comment-17846384 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-05-14 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2110842717 > continuous-integration/jenkins/pr-head Pending — This commit is being built This has been stuck by `Windows Batch Script` for more than 22 hours. Since this passed all the GitHub

[jira] [Commented] (HADOOP-19154) upgrade bouncy castle to 1.78.1 due to CVEs

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846383#comment-17846383 ] ASF GitHub Bot commented on HADOOP-19154: - ayushtkn commented on PR #6755: URL:

Re: [PR] HADOOP-19154. Upgrade bouncycastle to 1.78.1 due to CVEs [hadoop]

2024-05-14 Thread via GitHub
ayushtkn commented on PR #6755: URL: https://github.com/apache/hadoop/pull/6755#issuecomment-2110839627 @pjfanning the result is from windows build which doesn't run tests & some issues with mvn site, the actual build result for your PR is here: https://ci-hadoop.apache.org/blue/organiza

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2110605041 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846352#comment-17846352 ] ASF GitHub Bot commented on HADOOP-18958: - hadoop-yetus commented on PR #6255:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6255: URL: https://github.com/apache/hadoop/pull/6255#issuecomment-2110542796 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-14 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1600246934 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean checkLe

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2110528849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2110523072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-14 Thread via GitHub
simbadzina merged PR #6804: URL: https://github.com/apache/hadoop/pull/6804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-14 Thread via GitHub
simbadzina commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2110488809 Failing tests in continuous-integration unrelated to my changes ``` Failed junit tests | hadoop.hdfs.server.federation.router.security.token.TestSQLDelegationTokenSecretMana

Re: [PR] HDFS-17476. fix: False positive "Observer Node is too far behind" due to long overflow. [hadoop]

2024-05-14 Thread via GitHub
KeeProMise commented on PR #6747: URL: https://github.com/apache/hadoop/pull/6747#issuecomment-2110243175 > Thanks involving me. > > @KeeProMise I'm just doubt what scenarios could cause a negative `clientStateId`? @ZanderXu thanks for your review, under normal circumstances, t

[jira] [Comment Edited] (HADOOP-19174) Tez and hive jobs fail due to google's protobuf 2.5.0 in classpath

2024-05-14 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846307#comment-17846307 ] Ayush Saxena edited comment on HADOOP-19174 at 5/14/24 1:02 PM: -

Re: [PR] HDFS-17521. Erasure Coding: Fix calculation errors caused by special index order [hadoop]

2024-05-14 Thread via GitHub
zhengchenyu commented on PR #6813: URL: https://github.com/apache/hadoop/pull/6813#issuecomment-2110181645 @zhangshuyan0 Thanks for your review! I don't means that parity index is smaller. Parity index and data index is fixed number, we can't update it. The reproduce case: Whe

[jira] [Commented] (HADOOP-19174) Tez and hive jobs fail due to google's protobuf 2.5.0 in classpath

2024-05-14 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846307#comment-17846307 ] Ayush Saxena commented on HADOOP-19174: --- Additional questions: * Which Hive vers

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846296#comment-17846296 ] ASF GitHub Bot commented on HADOOP-18851: - ChenSammi commented on PR #6803: URL

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-14 Thread via GitHub
ChenSammi commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2110134515 @Hexiaoqiao , thanks for the info about mvnsite. Current, hadoop-yetus is passed. This "Apache Yetus", I never see it's all green. Should this github CI be all green before the PR can be

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846295#comment-17846295 ] ASF GitHub Bot commented on HADOOP-13147: - hadoop-yetus commented on PR #6408:

Re: [PR] HADOOP-13147 - Constructors must not call overrideable methods [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6408: URL: https://github.com/apache/hadoop/pull/6408#issuecomment-2110134328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846292#comment-17846292 ] ASF GitHub Bot commented on HADOOP-18958: - hiwangzhihui commented on PR #6255:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2024-05-14 Thread via GitHub
hiwangzhihui commented on PR #6255: URL: https://github.com/apache/hadoop/pull/6255#issuecomment-2110091932 hi, @steveloughran If you have time, please review it again. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846285#comment-17846285 ] ASF GitHub Bot commented on HADOOP-19170: - hadoop-yetus commented on PR #6827:

Re: [PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6827: URL: https://github.com/apache/hadoop/pull/6827#issuecomment-2110040679 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2110034091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2109940524 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846273#comment-17846273 ] ASF GitHub Bot commented on HADOOP-18958: - hadoop-yetus commented on PR #6255:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6255: URL: https://github.com/apache/hadoop/pull/6255#issuecomment-2109938623 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846268#comment-17846268 ] ASF GitHub Bot commented on HADOOP-18851: - hadoop-yetus commented on PR #6803:

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2109897935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-14 Thread via GitHub
kaiyaok2 commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2109873971 > it is just the variable name change, maybe changing to `testRootDir` should fix @ayushtkn Fixed. Thanks for the message -- This is an automated message from the Apache Git Serv

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-14 Thread via GitHub
ayushtkn commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2109847341 We have the test results, everything is green, the checkstyle alarm is for the existing code, not introduced as part of this PR but I think since we are touching it now, maybe we can fix

[jira] [Created] (HADOOP-19175) update s3a committer docs

2024-05-14 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19175: --- Summary: update s3a committer docs Key: HADOOP-19175 URL: https://issues.apache.org/jira/browse/HADOOP-19175 Project: Hadoop Common Issue Type: Improve

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2109819556 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846251#comment-17846251 ] ASF GitHub Bot commented on HADOOP-19170: - zhengchenyu commented on PR #6822: U

Re: [PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
zhengchenyu commented on PR #6822: URL: https://github.com/apache/hadoop/pull/6822#issuecomment-2109767782 @steveloughran OK, I add https://github.com/apache/hadoop/pull/6827 for backport to branch-3.4. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846250#comment-17846250 ] ASF GitHub Bot commented on HADOOP-19170: - zhengchenyu opened a new pull reques

[PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
zhengchenyu opened a new pull request, #6827: URL: https://github.com/apache/hadoop/pull/6827 Backport https://github.com/apache/hadoop/pull/6822 to branch-3.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2109700134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17526. getMetadataInputStream should use getShareDeleteFileInputStream for windows [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6826: URL: https://github.com/apache/hadoop/pull/6826#issuecomment-2109685586 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[jira] [Commented] (HADOOP-19170) Fixes compilation issues on Mac

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846232#comment-17846232 ] ASF GitHub Bot commented on HADOOP-19170: - steveloughran commented on PR #6822:

Re: [PR] HADOOP-19170. Fixes compilation issues on Mac [hadoop]

2024-05-14 Thread via GitHub
steveloughran commented on PR #6822: URL: https://github.com/apache/hadoop/pull/6822#issuecomment-2109677169 can we pull into branch-3.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (HADOOP-19174) Tez and hive jobs fail due to google's protobuf 2.5.0 in classpath

2024-05-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846230#comment-17846230 ] Steve Loughran commented on HADOOP-19174: - * which hadoop version * what happe

[jira] [Commented] (HADOOP-19163) Upgrade protobuf version to 3.24.4

2024-05-14 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846226#comment-17846226 ] Bilwa S T commented on HADOOP-19163: [~ste...@apache.org] sure, i will update my PR

Re: [PR] HDFS-17476. fix: False positive "Observer Node is too far behind" due to long overflow. [hadoop]

2024-05-14 Thread via GitHub
ZanderXu commented on PR #6747: URL: https://github.com/apache/hadoop/pull/6747#issuecomment-2109505953 Thanks involving me. @KeeProMise I'm just doubt what scenarios could cause a negative `clientStateId`? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
p-szucs commented on PR #6821: URL: https://github.com/apache/hadoop/pull/6821#issuecomment-2109479272 Thanks @brumi1024 for the review, I updated the patch based on your suggestions, and added unit tests as well. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
p-szucs commented on code in PR #6821: URL: https://github.com/apache/hadoop/pull/6821#discussion_r1599517841 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/Res

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
p-szucs commented on code in PR #6821: URL: https://github.com/apache/hadoop/pull/6821#discussion_r1599505033 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/Res

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
p-szucs commented on code in PR #6821: URL: https://github.com/apache/hadoop/pull/6821#discussion_r1599504396 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/Res

[jira] [Updated] (HADOOP-19174) Tez and hive jobs fail due to google's protobuf 2.5.0 in classpath

2024-05-14 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilwa S T updated HADOOP-19174: --- Description: There are two issues here: *1. We are running tez 0.10.3 which uses hadoop 3.3.6 vers

Re: [PR] YARN-11692. Support mixed cgroup v1/v2 controller structure [hadoop]

2024-05-14 Thread via GitHub
p-szucs commented on code in PR #6821: URL: https://github.com/apache/hadoop/pull/6821#discussion_r1599502676 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -2087,6 +2087,20 @@ yarn.nodemanager.linux-container-executor.cgrou

  1   2   >