[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847769#comment-17847769 ] ASF GitHub Bot commented on HADOOP-13147: - hadoop-yetus commented on PR #6408: URL:

Re: [PR] HADOOP-13147: Constructors must not call overrideable methods [hadoop]

2024-05-19 Thread via GitHub
hadoop-yetus commented on PR #6408: URL: https://github.com/apache/hadoop/pull/6408#issuecomment-2119647920 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17529. Improve router state store cache update [hadoop]

2024-05-19 Thread via GitHub
kokonguyen191 commented on PR #6833: URL: https://github.com/apache/hadoop/pull/6833#issuecomment-2119557407 @ZanderXu Can you help me take a look when you're free, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDFS-17529. Improve router state store cache update [hadoop]

2024-05-19 Thread via GitHub
kokonguyen191 commented on PR #6833: URL: https://github.com/apache/hadoop/pull/6833#issuecomment-2119556931 The failed unit tests really look like they were related to the changes but they aren't. Both tests fail without the patch, and seem to have failed for some past MRs already. --

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847754#comment-17847754 ] ASF GitHub Bot commented on HADOOP-13147: - hadoop-yetus commented on PR #6408: URL:

Re: [PR] HADOOP-13147: Constructors must not call overrideable methods [hadoop]

2024-05-19 Thread via GitHub
hadoop-yetus commented on PR #6408: URL: https://github.com/apache/hadoop/pull/6408#issuecomment-2119545069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17531. [Discuss] RBF: Aynchronous router RPC. [hadoop]

2024-05-19 Thread via GitHub
KeeProMise commented on PR #6838: URL: https://github.com/apache/hadoop/pull/6838#issuecomment-2119506196 @ayushtkn @slfan1989 hi, thanks for you replay, I sent the discussion to common-...@hadoop.apache.org. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HDFS-17531. [Discuss] RBF: Aynchronous router RPC. [hadoop]

2024-05-19 Thread via GitHub
slfan1989 commented on PR #6838: URL: https://github.com/apache/hadoop/pull/6838#issuecomment-2119459510 @KeeProMise Thanks for the contribution! This pr is too large and it seems that it cannot be reviewed. Let’s first follow the process and discuss it on the hadoop-common mailing

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847739#comment-17847739 ] ASF GitHub Bot commented on HADOOP-13147: - sebbASF commented on code in PR #6408: URL:

Re: [PR] HADOOP-13147: Constructors must not call overrideable methods [hadoop]

2024-05-19 Thread via GitHub
sebbASF commented on code in PR #6408: URL: https://github.com/apache/hadoop/pull/6408#discussion_r1606126878 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPureJavaCrc32C.java: ## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847734#comment-17847734 ] ASF GitHub Bot commented on HADOOP-13147: - ayushtkn commented on code in PR #6408: URL:

Re: [PR] HADOOP-13147: Constructors must not call overrideable methods [hadoop]

2024-05-19 Thread via GitHub
ayushtkn commented on code in PR #6408: URL: https://github.com/apache/hadoop/pull/6408#discussion_r1606103696 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPureJavaCrc32C.java: ## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847733#comment-17847733 ] ASF GitHub Bot commented on HADOOP-13147: - ayushtkn commented on code in PR #6408: URL:

Re: [PR] HADOOP-13147: Constructors must not call overrideable methods [hadoop]

2024-05-19 Thread via GitHub
ayushtkn commented on code in PR #6408: URL: https://github.com/apache/hadoop/pull/6408#discussion_r1606100798 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPureJavaCrc32C.java: ## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-13147) Constructors must not call overrideable methods

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847732#comment-17847732 ] ASF GitHub Bot commented on HADOOP-13147: - ayushtkn commented on code in PR #6408: URL:

Re: [PR] HADOOP-13147 - Constructors must not call overrideable methods [hadoop]

2024-05-19 Thread via GitHub
ayushtkn commented on code in PR #6408: URL: https://github.com/apache/hadoop/pull/6408#discussion_r1606099905 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestPureJavaCrc32C.java: ## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software

Re: [PR] HDFS-17531. [Discuss] RBF: Aynchronous router RPC. [hadoop]

2024-05-19 Thread via GitHub
ayushtkn commented on PR #6838: URL: https://github.com/apache/hadoop/pull/6838#issuecomment-2119352612 passing by: discuss threads should be on hadoop dev mailing lists -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Cherry-pick fixes of non-idempotent tests to branch-3.4 [hadoop]

2024-05-19 Thread via GitHub
ayushtkn merged PR #6837: URL: https://github.com/apache/hadoop/pull/6837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] HDFS-17531. RBF: Aynchronous router RPC. [hadoop]

2024-05-19 Thread via GitHub
KeeProMise opened a new pull request, #6838: URL: https://github.com/apache/hadoop/pull/6838 ### Description of PR see: https://issues.apache.org/jira/browse/HDFS-17531 ### How was this patch tested? TestNoNamenodesAvailableLongTime TestObserverWithRouter

Re: [PR] Cherry-pick fixes of non-idempotent tests to branch-3.4 [hadoop]

2024-05-19 Thread via GitHub
slfan1989 commented on PR #6837: URL: https://github.com/apache/hadoop/pull/6837#issuecomment-2119150611 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HADOOP-19148) Update solr from 8.11.2 to 8.11.3 to address CVE-2023-50298

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847626#comment-17847626 ] ASF GitHub Bot commented on HADOOP-19148: - virajjasani commented on PR #6830: URL:

Re: [PR] HADOOP-19148 Update solr from 8.11.2 to 8.11.3 to address CVE-2023-50298 [hadoop]

2024-05-19 Thread via GitHub
virajjasani commented on PR #6830: URL: https://github.com/apache/hadoop/pull/6830#issuecomment-2119120736 I observed similar behaviour on other recent PR also that attempted to upgrade some dependency (e.g. kafka-client) -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-19148) Update solr from 8.11.2 to 8.11.3 to address CVE-2023-50298

2024-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847625#comment-17847625 ] ASF GitHub Bot commented on HADOOP-19148: - virajjasani commented on PR #6830: URL:

Re: [PR] HADOOP-19148 Update solr from 8.11.2 to 8.11.3 to address CVE-2023-50298 [hadoop]

2024-05-19 Thread via GitHub
virajjasani commented on PR #6830: URL: https://github.com/apache/hadoop/pull/6830#issuecomment-2119120430 The full build was run but somehow the status is not getting reported to PR: https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-multibranch/view/change-requests/job/PR-6830/ --