Re: [PR] HDFS-17528. FsImageValidation: set txid when saving a new image [hadoop]

2024-05-22 Thread via GitHub
szetszwo commented on PR #6828: URL: https://github.com/apache/hadoop/pull/6828#issuecomment-2126096755 @vinayakumarb , thanks a lot for reviewing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-19184) TestStagingCommitter.testJobCommitFailure failing

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848772#comment-17848772 ] ASF GitHub Bot commented on HADOOP-19184: - hadoop-yetus commented on PR #6843:

Re: [PR] HADOOP-19184. Fix UT TestStagingCommitter.testJobCommitFailure [hadoop]

2024-05-22 Thread via GitHub
hadoop-yetus commented on PR #6843: URL: https://github.com/apache/hadoop/pull/6843#issuecomment-2125936053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19184) TestStagingCommitter.testJobCommitFailure failing

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848765#comment-17848765 ] ASF GitHub Bot commented on HADOOP-19184: - mukund-thakur commented on PR #6843:

Re: [PR] HADOOP-19184. Fix UT TestStagingCommitter.testJobCommitFailure [hadoop]

2024-05-22 Thread via GitHub
mukund-thakur commented on PR #6843: URL: https://github.com/apache/hadoop/pull/6843#issuecomment-2125863095 not yet ready. will clean this up and retest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged delete of files and objects

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848758#comment-17848758 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on PR #6726:

Re: [PR] HADOOP-18679. Add API for bulk/paged delete of files [hadoop]

2024-05-22 Thread via GitHub
mukund-thakur commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2125833326 fix this with mockito magic somehow. https://github.com/apache/hadoop/pull/6843/files this was not easy to debug. -- This is an automated message from the Apache Git Service.

[jira] [Updated] (HADOOP-19184) TestStagingCommitter.testJobCommitFailure failing

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19184: Labels: pull-request-available (was: ) > TestStagingCommitter.testJobCommitFailure faili

[jira] [Commented] (HADOOP-19184) TestStagingCommitter.testJobCommitFailure failing

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848757#comment-17848757 ] ASF GitHub Bot commented on HADOOP-19184: - mukund-thakur opened a new pull requ

[PR] HADOOP-19184. Fix UT TestStagingCommitter.testJobCommitFailure [hadoop]

2024-05-22 Thread via GitHub
mukund-thakur opened a new pull request, #6843: URL: https://github.com/apache/hadoop/pull/6843 Follow up of HADOOP-18679 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corr

[jira] [Updated] (HADOOP-19184) TestStagingCommitter.testJobCommitFailure failing

2024-05-22 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur updated HADOOP-19184: --- Description: {code:java} [INFO] [ERROR] Failures: [ERROR]   TestStagingCommitter.testJobC

[jira] [Created] (HADOOP-19184) TestStagingCommitter.testJobCommitFailure failing

2024-05-22 Thread Mukund Thakur (Jira)
Mukund Thakur created HADOOP-19184: -- Summary: TestStagingCommitter.testJobCommitFailure failing Key: HADOOP-19184 URL: https://issues.apache.org/jira/browse/HADOOP-19184 Project: Hadoop Common

Re: [PR] YARN-11687. CGroupV2 resource calculator [hadoop]

2024-05-22 Thread via GitHub
hadoop-yetus commented on PR #6835: URL: https://github.com/apache/hadoop/pull/6835#issuecomment-2125205257 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18325) ABFS: Add correlated metric support for ABFS operations

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848665#comment-17848665 ] ASF GitHub Bot commented on HADOOP-18325: - hadoop-yetus commented on PR #6314:

Re: [PR] HADOOP-18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-05-22 Thread via GitHub
hadoop-yetus commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-2125090047 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Comment Edited] (HADOOP-19178) WASB Driver Deprecation and eventual removal

2024-05-22 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848360#comment-17848360 ] Steve Loughran edited comment on HADOOP-19178 at 5/22/24 2:17 PM: ---

[jira] [Commented] (HADOOP-18325) ABFS: Add correlated metric support for ABFS operations

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848572#comment-17848572 ] ASF GitHub Bot commented on HADOOP-18325: - steveloughran commented on PR #6314:

Re: [PR] HADOOP-18325: ABFS: Add correlated metric support for ABFS operations [hadoop]

2024-05-22 Thread via GitHub
steveloughran commented on PR #6314: URL: https://github.com/apache/hadoop/pull/6314#issuecomment-2124572940 ok, fix those 2 checkstyles ``` ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:28:import org.apache.hadoop.fs.azurebfs.

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848571#comment-17848571 ] ASF GitHub Bot commented on HADOOP-18508: - steveloughran commented on PR #5081:

Re: [PR] HADOOP-18508. S3A: Support parallel integration test runs on same bucket [hadoop]

2024-05-22 Thread via GitHub
steveloughran commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2124570812 ..it and the STS one are both with jiras. STS failure depends on the region you are running from, so it is test setup. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848570#comment-17848570 ] ASF GitHub Bot commented on HADOOP-18508: - steveloughran commented on PR #5081:

Re: [PR] HADOOP-18508. S3A: Support parallel integration test runs on same bucket [hadoop]

2024-05-22 Thread via GitHub
steveloughran commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2124569504 I need to sit down and fix that committer factory one. nothing hard but it is irritating me -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] YARN-11687. CGroupV2 resource calculator [hadoop]

2024-05-22 Thread via GitHub
hadoop-yetus commented on PR #6835: URL: https://github.com/apache/hadoop/pull/6835#issuecomment-2124562337 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged delete of files and objects

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848564#comment-17848564 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on PR #6726:

Re: [PR] HADOOP-18679. Add API for bulk/paged delete of files [hadoop]

2024-05-22 Thread via GitHub
steveloughran commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2124552084 problem is store is null in innermost s3afs, triggers an NPE in deleteObject() before the aws client has its delete operation called, so list of deleted paths is not updated.

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848554#comment-17848554 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832:

Re: [PR] HADOOP-18184. S3A Prefetching unbuffer. [hadoop]

2024-05-22 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-2124495782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18679. Add API for bulk/paged delete of files [hadoop]

2024-05-22 Thread via GitHub
steveloughran commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2124490917 yeah, just seen those too. the mocked s3 client isn't getting the delete one object calls via the store object. got a small PR up to help debug it, which is *not* a fix -- T

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged delete of files and objects

2024-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848552#comment-17848552 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on PR #6726:

[jira] [Created] (HADOOP-19183) RBF: Support leader follower mode for multiple subclusters

2024-05-22 Thread Yuanbo Liu (Jira)
Yuanbo Liu created HADOOP-19183: --- Summary: RBF: Support leader follower mode for multiple subclusters Key: HADOOP-19183 URL: https://issues.apache.org/jira/browse/HADOOP-19183 Project: Hadoop Common

Re: [PR] YARN-11687. CGroupV2 resource calculator [hadoop]

2024-05-22 Thread via GitHub
K0K0V0K commented on code in PR #6835: URL: https://github.com/apache/hadoop/pull/6835#discussion_r1609460882 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGr