[jira] [Commented] (HADOOP-18931) FileSystem.getFileSystemClass() to log at debug the jar the .class came from

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854945#comment-17854945 ] ASF GitHub Bot commented on HADOOP-18931: - virajjasani commented on PR #6197: U

Re: [PR] HADOOP-18931. FileSystem.getFileSystemClass() to log at debug the jar the .class came from [hadoop]

2024-06-13 Thread via GitHub
virajjasani commented on PR #6197: URL: https://github.com/apache/hadoop/pull/6197#issuecomment-2167335766 My bad, i misunderstood this earlier. The recommendation was to use `assertj-core` jar location to test test ClassUtil functions (rather than using log4j jar location), i was under the

Re: [PR] HADOOP-19148 Upgrade solr from 8.11.2 to 8.11.3 to address CVE-2023-50298 [hadoop]

2024-06-13 Thread via GitHub
virajjasani commented on PR #6830: URL: https://github.com/apache/hadoop/pull/6830#issuecomment-2167307908 @slfan1989 are the above Yarn federation test failures known to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] HDFS-17439. Support -nonSuperUser for NNThroughputBenchmark: useful f… [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6677: URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2167075511 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode [hadoop]

2024-06-13 Thread via GitHub
LiuGuH commented on PR #6882: URL: https://github.com/apache/hadoop/pull/6882#issuecomment-2167063934 @haiyang1987 Hello ,sir . This is based on your version , and resolve lease and changed some something else . @ZanderXu @haiyang1987 Could you please review this, Thanks. -- This

[jira] [Commented] (HADOOP-19131) WrappedIO to export modern filesystem/statistics APIs in a reflection friendly form

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854900#comment-17854900 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686:

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2167030549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19131) WrappedIO to export modern filesystem/statistics APIs in a reflection friendly form

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854899#comment-17854899 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686:

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2167027183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17546. Implementing HostsFileReader timeout [hadoop]

2024-06-13 Thread via GitHub
simbadzina commented on code in PR #6873: URL: https://github.com/apache/hadoop/pull/6873#discussion_r1639044953 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/TestCombinedHostsFileReader.java: ## @@ -19,14 +19,23 @@ import java.io.File; import

Re: [PR] HDFS-17546. Implementing HostsFileReader timeout [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6873: URL: https://github.com/apache/hadoop/pull/6873#issuecomment-2166910505 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17552. [ARR] RPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6888: URL: https://github.com/apache/hadoop/pull/6888#issuecomment-2166541589 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19148 Upgrade solr from 8.11.2 to 8.11.3 to address CVE-2023-50298 [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6830: URL: https://github.com/apache/hadoop/pull/6830#issuecomment-2166403300 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19204) VectorIO regression: empty ranges are now rejected

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854872#comment-17854872 ] ASF GitHub Bot commented on HADOOP-19204: - hadoop-yetus commented on PR #6887:

Re: [PR] HADOOP-19204. VectorIO regression: empty ranges are now rejected [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6887: URL: https://github.com/apache/hadoop/pull/6887#issuecomment-2166794586 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17523: Add fine-grained locks metrics in DataSetLockManager [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6886: URL: https://github.com/apache/hadoop/pull/6886#issuecomment-2166792039 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-215932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19194) Add test to find unshaded dependencies in the aws sdk

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854843#comment-17854843 ] ASF GitHub Bot commented on HADOOP-19194: - mukund-thakur commented on PR #6865:

Re: [PR] HADOOP-19194:Add test to find unshaded dependencies in the aws sdk [hadoop]

2024-06-13 Thread via GitHub
mukund-thakur commented on PR #6865: URL: https://github.com/apache/hadoop/pull/6865#issuecomment-2166572968 this https://github.com/aws/aws-sdk-java-v2/blob/master/test/bundle-shading-tests/src/test/java/software/amazon/awssdk/bundle/BundleShadedCorrectlyTest.java looks a good test. maybe

Re: [PR] HADOOP-18508. S3A: Support parallel integration test runs on same bucket [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2166371107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854820#comment-17854820 ] ASF GitHub Bot commented on HADOOP-18508: - hadoop-yetus commented on PR #5081:

[jira] [Commented] (HADOOP-19148) Update solr from 8.11.2 to 8.11.3 to address CVE-2023-50298

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854828#comment-17854828 ] ASF GitHub Bot commented on HADOOP-19148: - hadoop-yetus commented on PR #6830:

[PR] HDFS-17552. [ARR] RPC client uses CompletableFuture to support asynchronous operations. [hadoop]

2024-06-13 Thread via GitHub
KeeProMise opened a new pull request, #6888: URL: https://github.com/apache/hadoop/pull/6888 ### Description of PR please see: https://issues.apache.org/jira/browse/HDFS-17552 ### How was this patch tested? new UT TestAsyncIPC#testAsyncCallWithCompletableFuture()

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854792#comment-17854792 ] ASF GitHub Bot commented on HADOOP-19161: - hadoop-yetus commented on PR #6789:

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2166096602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19203) WrappedIO BulkDelete API to raise IOEs as UncheckedIOExceptions

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854766#comment-17854766 ] ASF GitHub Bot commented on HADOOP-19203: - hadoop-yetus commented on PR #6885:

Re: [PR] HADOOP-19203. WrappedIO BulkDelete API to raise IOEs as UncheckedIOExceptions [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6885: URL: https://github.com/apache/hadoop/pull/6885#issuecomment-2165835177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6882: URL: https://github.com/apache/hadoop/pull/6882#issuecomment-2165806876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6882: URL: https://github.com/apache/hadoop/pull/6882#issuecomment-2165281095 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18931) FileSystem.getFileSystemClass() to log at debug the jar the .class came from

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854727#comment-17854727 ] ASF GitHub Bot commented on HADOOP-18931: - steveloughran commented on PR #6197:

Re: [PR] HADOOP-18931. FileSystem.getFileSystemClass() to log at debug the jar the .class came from [hadoop]

2024-06-13 Thread via GitHub
steveloughran commented on PR #6197: URL: https://github.com/apache/hadoop/pull/6197#issuecomment-2165442737 > It is assertj: org.assertj.core.api.Assertions (unless i misinterpreted something and you are suggesting to use different class from assertj) think my concern is more when lo

Re: [PR] HDFS-17439. Support -nonSuperUser for NNThroughputBenchmark: useful f… [hadoop]

2024-06-13 Thread via GitHub
sodonnel commented on PR #6677: URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2165394746 @fateh288 This change LGTM. As the last commit was a little old, could you merge in trunk or rebase on trunk and push the change so the CI runs again. This will avoid any problems that ma

Re: [PR] YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread [hadoop]

2024-06-13 Thread via GitHub
pstrzelczak commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-2165145077 As already mentioned, this issue make 1vcpu to be always occupied due to busy loop. The makes the adoption of 3.3 line difficult in production environments. Can it be fixed? -- This

Re: [PR] HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6882: URL: https://github.com/apache/hadoop/pull/6882#issuecomment-2164965425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18708: Support S3 Client Side Encryption(CSE) With AWS SDK V2 [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6884: URL: https://github.com/apache/hadoop/pull/6884#issuecomment-2165013120 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854679#comment-17854679 ] ASF GitHub Bot commented on HADOOP-18708: - hadoop-yetus commented on PR #6884: