[jira] [Commented] (HADOOP-19248) Protobuf code generate and replace should happen together

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876575#comment-17876575 ] ASF GitHub Bot commented on HADOOP-19248: - pan3793 commented on PR #6975: URL:

Re: [PR] HADOOP-19248. Protobuf code generate and replace should happen together [hadoop]

2024-08-25 Thread via GitHub
pan3793 commented on PR #6975: URL: https://github.com/apache/hadoop/pull/6975#issuecomment-2309276084 kindly ping @slfan1989, can we move this ahead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDFS-17556. Avoid adding block to neededReconstruction repeatedly in decommission [hadoop]

2024-08-25 Thread via GitHub
hadoop-yetus commented on PR #6896: URL: https://github.com/apache/hadoop/pull/6896#issuecomment-2309014541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17607. Reduce the number of times conf is loaded when DataNode s… [hadoop]

2024-08-25 Thread via GitHub
hadoop-yetus commented on PR #7012: URL: https://github.com/apache/hadoop/pull/7012#issuecomment-2309003600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17556. Avoid adding block to neededReconstruction repeatedly in decommission [hadoop]

2024-08-25 Thread via GitHub
lfxy commented on PR #6896: URL: https://github.com/apache/hadoop/pull/6896#issuecomment-2308894828 @haiyang1987 Thank you for your suggestion. I have update the UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HDFS-17556. Avoid adding block to neededReconstruction repeatedly in decommission [hadoop]

2024-08-25 Thread via GitHub
haiyang1987 commented on code in PR #6896: URL: https://github.com/apache/hadoop/pull/6896#discussion_r1730368502 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManager.java: ## @@ -2329,4 +2331,81 @@ public void delayDele

[PR] HDFS-17607. Reduce the number of times conf is loaded when DataNode s… [hadoop]

2024-08-25 Thread via GitHub
ThinkerLei opened a new pull request, #7012: URL: https://github.com/apache/hadoop/pull/7012 Reduce the number of times conf is loaded when DataNode startUp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] HDFS-17556. Avoid adding block to neededReconstruction repeatedly in decommission [hadoop]

2024-08-25 Thread via GitHub
haiyang1987 commented on PR #6896: URL: https://github.com/apache/hadoop/pull/6896#issuecomment-2308868812 Well work, Leave some comments inline, Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDFS-17523: Add fine-grained lock held info when the lock holding time reaches the specified threshold [hadoop]

2024-08-25 Thread via GitHub
ThinkerLei commented on code in PR #6890: URL: https://github.com/apache/hadoop/pull/6890#discussion_r1730364747 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/AutoCloseDataSetLock.java: ## @@ -30,17 +33,39 @@ * use a try-with-resource sy

[PR] Add Haiyang Hu to Committer List [hadoop-site]

2024-08-25 Thread via GitHub
haiyang1987 opened a new pull request, #59: URL: https://github.com/apache/hadoop-site/pull/59 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add Haiyang Hu to Committer List [hadoop-site]

2024-08-25 Thread via GitHub
haiyang1987 closed pull request #58: Add Haiyang Hu to Committer List URL: https://github.com/apache/hadoop-site/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] Add Haiyang Hu to Committer List [hadoop-site]

2024-08-25 Thread via GitHub
haiyang1987 opened a new pull request, #58: URL: https://github.com/apache/hadoop-site/pull/58 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HDFS-17599. EC: Fix the mismatch between locations and indices for mover [hadoop]

2024-08-25 Thread via GitHub
haiyang1987 commented on PR #6980: URL: https://github.com/apache/hadoop/pull/6980#issuecomment-2308760305 Will commit if no more other comments while wait two workday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] HDFS-17599. EC: Fix the mismatch between locations and indices for mover [hadoop]

2024-08-25 Thread via GitHub
haiyang1987 commented on PR #6980: URL: https://github.com/apache/hadoop/pull/6980#issuecomment-2308760107 LGTM. +1 from my side, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] HDFS-17573. Allow turn on both FSImage parallelization and compression [hadoop]

2024-08-25 Thread via GitHub
Hexiaoqiao commented on PR #6929: URL: https://github.com/apache/hadoop/pull/6929#issuecomment-2308756830 Committed to trunk. Thanks @Last-remote11 for your works! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] HDFS-17573. Allow turn on both FSImage parallelization and compression [hadoop]

2024-08-25 Thread via GitHub
Hexiaoqiao merged PR #6929: URL: https://github.com/apache/hadoop/pull/6929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

Re: [PR] HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode [hadoop]

2024-08-25 Thread via GitHub
Hexiaoqiao commented on code in PR #6926: URL: https://github.com/apache/hadoop/pull/6926#discussion_r1730295351 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3067,69 +3087,70 @@ public void run() { //

Re: [PR] HDFS-17599. EC: Fix the mismatch between locations and indices for mover [hadoop]

2024-08-25 Thread via GitHub
Hexiaoqiao commented on PR #6980: URL: https://github.com/apache/hadoop/pull/6980#issuecomment-2308740198 cc @haiyang1987 @zhangshuyan0 Would you mind to give another review? If no other blocker, please try to push forwards this PR. Thanks. -- This is an automated message from the Apache

Re: [PR] HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var [hadoop]

2024-08-25 Thread via GitHub
Hexiaoqiao commented on PR #6969: URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2308738326 Committed to trunk. Thanks @kevincai for your contributions! BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am

Re: [PR] HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var [hadoop]

2024-08-25 Thread via GitHub
Hexiaoqiao merged PR #6969: URL: https://github.com/apache/hadoop/pull/6969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876482#comment-17876482 ] ASF GitHub Bot commented on HADOOP-18708: - shameersss1 commented on PR #6884: U

Re: [PR] HADOOP-18708: Support S3 Client Side Encryption(CSE) With AWS SDK V2 [hadoop]

2024-08-25 Thread via GitHub
shameersss1 commented on PR #6884: URL: https://github.com/apache/hadoop/pull/6884#issuecomment-2308729197 @steveloughran - Are we good to take this forward ? Please let me know if there is anything else to address -- This is an automated message from the Apache Git Service. To respond t