[jira] [Commented] (HADOOP-19540) [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947580#comment-17947580 ] ASF GitHub Bot commented on HADOOP-19540: - pan3793 commented on code in PR #760

Re: [PR] HADOOP-19540. [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default [hadoop]

2025-04-26 Thread via GitHub
pan3793 commented on code in PR #7608: URL: https://github.com/apache/hadoop/pull/7608#discussion_r2062358931 ## BUILDING.txt: ## @@ -29,7 +29,11 @@ This requires a recent version of docker (1.4.1 and higher are known to work). On Linux / Mac: Install Docker and run this

Re: [PR] HADOOP-19540. [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default [hadoop]

2025-04-26 Thread via GitHub
vinayakumarb commented on code in PR #7608: URL: https://github.com/apache/hadoop/pull/7608#discussion_r2061995529 ## BUILDING.txt: ## @@ -29,7 +29,11 @@ This requires a recent version of docker (1.4.1 and higher are known to work). On Linux / Mac: Install Docker and run

[jira] [Commented] (HADOOP-19540) [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947577#comment-17947577 ] ASF GitHub Bot commented on HADOOP-19540: - vinayakumarb commented on code in PR

Re: [PR] YARN-11267. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-router. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7546: URL: https://github.com/apache/hadoop/pull/7546#issuecomment-2832933918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19425) [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947556#comment-17947556 ] ASF GitHub Bot commented on HADOOP-19425: - hadoop-yetus commented on PR #7653:

Re: [PR] HADOOP-19425. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure Part2. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7653: URL: https://github.com/apache/hadoop/pull/7653#issuecomment-2832745938 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HADOOP-19425. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure Part2. [hadoop]

2025-04-26 Thread via GitHub
slfan1989 opened a new pull request, #7653: URL: https://github.com/apache/hadoop/pull/7653 ### Description of PR JIRA: HADOOP-19425. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure Part2. ### How was this patch tested? ### For code changes: - [ ] Doe

[jira] [Commented] (HADOOP-19425) [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947553#comment-17947553 ] ASF GitHub Bot commented on HADOOP-19425: - slfan1989 opened a new pull request,

Re: [PR] HDFS-17767. Skip tests that depend on custom SecurityManager when Java doesn't support it [hadoop]

2025-04-26 Thread via GitHub
szetszwo commented on code in PR #7566: URL: https://github.com/apache/hadoop/pull/7566#discussion_r2061500341 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java: ## @@ -574,28 +575,36 @@ public void run() { }; //use SecurityMan

Re: [PR] HDFS-17767. Skip tests that depend on custom SecurityManager when Java doesn't support it [hadoop]

2025-04-26 Thread via GitHub
szetszwo commented on code in PR #7566: URL: https://github.com/apache/hadoop/pull/7566#discussion_r2061500341 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java: ## @@ -574,28 +575,36 @@ public void run() { }; //use SecurityMan

Re: [PR] HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4. [hadoop]

2025-04-26 Thread via GitHub
zhtttylz commented on code in PR #7647: URL: https://github.com/apache/hadoop/pull/7647#discussion_r2061299464 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestAdminHelper.java: ## @@ -28,11 +28,10 @@ public class TestAdminHelper { @Test pu

Re: [PR] HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7652: URL: https://github.com/apache/hadoop/pull/7652#issuecomment-2832052652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19426) Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947521#comment-17947521 ] ASF GitHub Bot commented on HADOOP-19426: - hadoop-yetus commented on PR #7652:

Re: [PR] YARN-11267. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-router. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7546: URL: https://github.com/apache/hadoop/pull/7546#issuecomment-2832047988 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947505#comment-17947505 ] ASF GitHub Bot commented on HADOOP-19414: - hadoop-yetus commented on PR #7638:

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7638: URL: https://github.com/apache/hadoop/pull/7638#issuecomment-2832017391 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake. [hadoop]

2025-04-26 Thread via GitHub
slfan1989 opened a new pull request, #7652: URL: https://github.com/apache/hadoop/pull/7652 ### Description of PR JIRA: HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake. ### How was this patch tested? ### For code changes: - [ ]

[jira] [Commented] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947507#comment-17947507 ] ASF GitHub Bot commented on HADOOP-19414: - hadoop-yetus commented on PR #7638:

[jira] [Commented] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947506#comment-17947506 ] ASF GitHub Bot commented on HADOOP-19414: - hadoop-yetus commented on PR #7638:

[jira] [Commented] (HADOOP-19532) Update commons-lang3 to 3.17.0

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947501#comment-17947501 ] ASF GitHub Bot commented on HADOOP-19532: - slfan1989 merged PR #7648: URL: http

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7638: URL: https://github.com/apache/hadoop/pull/7638#issuecomment-2832016722 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7638: URL: https://github.com/apache/hadoop/pull/7638#issuecomment-2832015772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19426) Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947504#comment-17947504 ] ASF GitHub Bot commented on HADOOP-19426: - slfan1989 opened a new pull request,

[jira] [Updated] (HADOOP-19426) Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19426: Labels: pull-request-available (was: ) > Upgrade JUnit from 4 to 5 in hadoop-azure-datal

Re: [PR] HADOOP-19532. Update commons-lang3 to 3.17.0 (#7591) [hadoop]

2025-04-26 Thread via GitHub
slfan1989 commented on PR #7648: URL: https://github.com/apache/hadoop/pull/7648#issuecomment-2832009067 @stoty Thanks for the contribution! The issue with the unit tests is unrelated to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (HADOOP-19532) Update commons-lang3 to 3.17.0

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947502#comment-17947502 ] ASF GitHub Bot commented on HADOOP-19532: - slfan1989 commented on PR #7648: URL

Re: [PR] HADOOP-19532. Update commons-lang3 to 3.17.0 (#7591) [hadoop]

2025-04-26 Thread via GitHub
slfan1989 merged PR #7648: URL: https://github.com/apache/hadoop/pull/7648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Commented] (HADOOP-19545) Update to ApacheDS 2.0.0.AM27 and ldap-api 2.1.5

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947496#comment-17947496 ] ASF GitHub Bot commented on HADOOP-19545: - slfan1989 commented on code in PR #7

Re: [PR] HADOOP-19545. Update to ApacheDS 2.0.0.AM27 and ldap-api 2.1.5 [hadoop]

2025-04-26 Thread via GitHub
slfan1989 commented on code in PR #7628: URL: https://github.com/apache/hadoop/pull/7628#discussion_r2061241769 ## hadoop-project/pom.xml: ## @@ -114,8 +114,8 @@ 1.78.1 -2.0.0.AM26 -2.0.0 +2.0.0.AM27 +2.1.5 Review Comment: The `ldap-api.version`

Re: [PR] YARN-11267. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-router. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7546: URL: https://github.com/apache/hadoop/pull/7546#issuecomment-2831977259 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11267. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-router. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7546: URL: https://github.com/apache/hadoop/pull/7546#issuecomment-2831977242 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19415) Upgrade JUnit from 4 to 5 in hadoop-common.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947492#comment-17947492 ] ASF GitHub Bot commented on HADOOP-19415: - hadoop-yetus commented on PR #7419:

Re: [PR] HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part6. [hadoop]

2025-04-26 Thread via GitHub
hadoop-yetus commented on PR #7419: URL: https://github.com/apache/hadoop/pull/7419#issuecomment-2831972604 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19433) Upgrade JUnit from 4 to 5 in hadoop-extras.

2025-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947486#comment-17947486 ] ASF GitHub Bot commented on HADOOP-19433: - slfan1989 commented on PR #7586: URL

Re: [PR] [DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. [hadoop]

2025-04-26 Thread via GitHub
slfan1989 commented on PR #7337: URL: https://github.com/apache/hadoop/pull/7337#issuecomment-2831965733 I’d like to provide an update on the progress of upgrading Hadoop from JUnit 4 to JUnit 5. I’ve outlined all the modules that need to be upgraded, totaling 51 modules. Currently, we have

Re: [PR] HADOOP-19433. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-extras. [hadoop]

2025-04-26 Thread via GitHub
slfan1989 commented on PR #7586: URL: https://github.com/apache/hadoop/pull/7586#issuecomment-2831959261 > `TestGetGroups` ran tests in the base class `GetGroupsTestBase`, which failed. Does JUnit 5 `@Disabled` not disable tests in superclasses? Would we need to override each method and app