Re: [PR] YARN-11801: NPE in FifoCandidatesSelector.selectCandidates when prempting resources for an auto-created queue without child queues [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7657: URL: https://github.com/apache/hadoop/pull/7657#issuecomment-2843361067 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19415) Upgrade JUnit from 4 to 5 in hadoop-common.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948591#comment-17948591 ] ASF GitHub Bot commented on HADOOP-19415: - hadoop-yetus commented on PR #7664:

Re: [PR] HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part7. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7664: URL: https://github.com/apache/hadoop/pull/7664#issuecomment-2843287319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948576#comment-17948576 ] ASF GitHub Bot commented on HADOOP-19399: - hadoop-yetus commented on PR #7443:

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7443: URL: https://github.com/apache/hadoop/pull/7443#issuecomment-2843036025 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11267. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-router. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7546: URL: https://github.com/apache/hadoop/pull/7546#issuecomment-2842939010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948563#comment-17948563 ] ASF GitHub Bot commented on HADOOP-19557: - hadoop-yetus commented on PR #7663:

Re: [PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() c… [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7663: URL: https://github.com/apache/hadoop/pull/7663#issuecomment-2842922165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17767. Skip tests that depend on custom SecurityManager when Java doesn't support it [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7566: URL: https://github.com/apache/hadoop/pull/7566#issuecomment-2842826667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948544#comment-17948544 ] ASF GitHub Bot commented on HADOOP-19399: - ahmarsuhail commented on PR #7443: U

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
ahmarsuhail commented on PR #7443: URL: https://github.com/apache/hadoop/pull/7443#issuecomment-2842719605 rebased and addressed most comments (i think!), will test and double check tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] YARN-11801: NPE in FifoCandidatesSelector.selectCandidates when preempting resources for an auto-created queue without child queues [hadoop]

2025-04-30 Thread via GitHub
susheelgupta7 commented on PR #7607: URL: https://github.com/apache/hadoop/pull/7607#issuecomment-2842707703 @brumi1024 I can't reproduce this issue on branch 3.3.0 This issue can be seen on branch-3.4.0 so created a pull request https://github.com/apache/hadoop/pull/7657/files -- This

[jira] [Commented] (HADOOP-19415) Upgrade JUnit from 4 to 5 in hadoop-common.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948535#comment-17948535 ] ASF GitHub Bot commented on HADOOP-19415: - slfan1989 opened a new pull request,

[PR] HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part7. [hadoop]

2025-04-30 Thread via GitHub
slfan1989 opened a new pull request, #7664: URL: https://github.com/apache/hadoop/pull/7664 ### Description of PR JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part7. ### How was this patch tested? ### For code changes: - [ ] Do

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
ahmarsuhail commented on code in PR #7443: URL: https://github.com/apache/hadoop/pull/7443#discussion_r2069058053 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSRegionEndpointResolver.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948532#comment-17948532 ] ASF GitHub Bot commented on HADOOP-19399: - ahmarsuhail commented on code in PR

[jira] [Resolved] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-30 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan resolved HADOOP-19414. - Fix Version/s: 3.5.0 Hadoop Flags: Reviewed Target Version/s: 3.5.0 Res

[jira] [Commented] (HADOOP-19548) [ABFS] Fix logging in FSDataInputStream buffersize as that is not used and confusing the customer

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948530#comment-17948530 ] ASF GitHub Bot commented on HADOOP-19548: - mukund-thakur commented on code in P

Re: [PR] HADOOP-19548: [ABFS][Backport to 3.4] Fix Logging in FSDataInputStream to Mention Correct Buffersize [hadoop]

2025-04-30 Thread via GitHub
mukund-thakur commented on code in PR #7660: URL: https://github.com/apache/hadoop/pull/7660#discussion_r2069029749 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java: ## @@ -118,22 +118,7 @@ import static org.apache.hadoop.fs.Com

[jira] [Commented] (HADOOP-19548) [ABFS] Fix logging in FSDataInputStream buffersize as that is not used and confusing the customer

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948529#comment-17948529 ] ASF GitHub Bot commented on HADOOP-19548: - mukund-thakur merged PR #7660: URL:

[jira] [Commented] (HADOOP-19548) [ABFS] Fix logging in FSDataInputStream buffersize as that is not used and confusing the customer

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948528#comment-17948528 ] ASF GitHub Bot commented on HADOOP-19548: - mukund-thakur commented on code in P

Re: [PR] HADOOP-19548: [ABFS][Backport to 3.4] Fix Logging in FSDataInputStream to Mention Correct Buffersize [hadoop]

2025-04-30 Thread via GitHub
mukund-thakur commented on code in PR #7660: URL: https://github.com/apache/hadoop/pull/7660#discussion_r2069025761 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java: ## @@ -118,22 +118,7 @@ import static org.apache.hadoop.fs.Com

Re: [PR] HADOOP-19548: [ABFS][Backport to 3.4] Fix Logging in FSDataInputStream to Mention Correct Buffersize [hadoop]

2025-04-30 Thread via GitHub
mukund-thakur merged PR #7660: URL: https://github.com/apache/hadoop/pull/7660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Updated] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-30 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-19414: Affects Version/s: 3.5.0 > Upgrade JUnit from 4 to 5 in hadoop-auth. > --

[jira] [Updated] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-30 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HADOOP-19414: Component/s: hadoop-auth test > Upgrade JUnit from 4 to 5 in hadoop-auth. >

[jira] [Commented] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948524#comment-17948524 ] ASF GitHub Bot commented on HADOOP-19414: - slfan1989 commented on PR #7638: URL

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-30 Thread via GitHub
slfan1989 commented on PR #7638: URL: https://github.com/apache/hadoop/pull/7638#issuecomment-2842487043 @cnauroth Thank you very much for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948522#comment-17948522 ] ASF GitHub Bot commented on HADOOP-19557: - steveloughran commented on PR #7663:

Re: [PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() c… [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on PR #7663: URL: https://github.com/apache/hadoop/pull/7663#issuecomment-2842483012 tested s3 london with analytics input stream. all good, one expected and unrelated test failure (AbstractContractOpenTest.testInputStreamReadNegativePosition) -- This is an automa

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948521#comment-17948521 ] ASF GitHub Bot commented on HADOOP-19557: - steveloughran opened a new pull requ

[PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() c… [hadoop]

2025-04-30 Thread via GitHub
steveloughran opened a new pull request, #7663: URL: https://github.com/apache/hadoop/pull/7663 …alls (#7662) S3A output streams no longer logs warnings on use of hflush() or, if fs.s3a.downgrade.syncable.exceptions = false, raises an UnsupportedOperationException . hsync() is

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-30 Thread via GitHub
slfan1989 merged PR #7638: URL: https://github.com/apache/hadoop/pull/7638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948516#comment-17948516 ] ASF GitHub Bot commented on HADOOP-19557: - steveloughran merged PR #7662: URL:

Re: [PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() calls [hadoop]

2025-04-30 Thread via GitHub
steveloughran merged PR #7662: URL: https://github.com/apache/hadoop/pull/7662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948513#comment-17948513 ] ASF GitHub Bot commented on HADOOP-19399: - ahmarsuhail commented on code in PR

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
ahmarsuhail commented on code in PR #7443: URL: https://github.com/apache/hadoop/pull/7443#discussion_r2068945451 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java: ## @@ -709,6 +742,18 @@ public void setEncryptionSecrets(final Encryp

[jira] [Updated] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19557: Release Note: S3A output streams no longer log warnings on use of hflush()/raise exceptio

Re: [PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() calls [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on code in PR #7662: URL: https://github.com/apache/hadoop/pull/7662#discussion_r2068923434 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java: ## @@ -829,7 +829,8 @@ public boolean hasCapability(String capability)

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948510#comment-17948510 ] ASF GitHub Bot commented on HADOOP-19557: - steveloughran commented on code in P

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948507#comment-17948507 ] ASF GitHub Bot commented on HADOOP-19399: - steveloughran commented on code in P

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on code in PR #7443: URL: https://github.com/apache/hadoop/pull/7443#discussion_r2068869620 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSRegionEndpointResolver.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software

Re: [PR] YARN-11267. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-router. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7546: URL: https://github.com/apache/hadoop/pull/7546#issuecomment-2842282023 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948498#comment-17948498 ] ASF GitHub Bot commented on HADOOP-19414: - hadoop-yetus commented on PR #7638:

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7638: URL: https://github.com/apache/hadoop/pull/7638#issuecomment-2842199570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948494#comment-17948494 ] ASF GitHub Bot commented on HADOOP-19399: - steveloughran commented on PR #7443:

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on PR #7443: URL: https://github.com/apache/hadoop/pull/7443#issuecomment-2842151041 If you can address those little nits and and are confident that the errors reported go away, then yes. -- This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948489#comment-17948489 ] ASF GitHub Bot commented on HADOOP-19399: - ahmarsuhail commented on PR #7443: U

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
ahmarsuhail commented on PR #7443: URL: https://github.com/apache/hadoop/pull/7443#issuecomment-2842123949 @steveloughran yeah those errors will go away once I rebase to the latest SDK. will rebase and address your comments now. are you ok with getting this into 3.4.2? i'm j

[jira] [Commented] (HADOOP-19399) S3A: Add support for CRT client

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948485#comment-17948485 ] ASF GitHub Bot commented on HADOOP-19399: - steveloughran commented on code in P

Re: [PR] HADOOP-19399. S3A: support CRT client. [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on code in PR #7443: URL: https://github.com/apache/hadoop/pull/7443#discussion_r2068647513 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/crt_client.md: ## @@ -0,0 +1,66 @@ + + +# Using the S3 CRT client + +This document explains usage of

[jira] [Commented] (HADOOP-19426) Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948474#comment-17948474 ] ASF GitHub Bot commented on HADOOP-19426: - slfan1989 commented on PR #7652: URL

Re: [PR] HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake. [hadoop]

2025-04-30 Thread via GitHub
slfan1989 commented on PR #7652: URL: https://github.com/apache/hadoop/pull/7652#issuecomment-2841956019 @cnauroth @anujmodi2021 Could you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] HADOOP-19526. Skip tests in Hadoop common that depend on SecurityManager if the JVM does not support it [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7567: URL: https://github.com/apache/hadoop/pull/7567#issuecomment-2841933955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19526) Skip tests in Hadoop common that depend on SecurityManager if the JVM does not support it

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948470#comment-17948470 ] ASF GitHub Bot commented on HADOOP-19526: - hadoop-yetus commented on PR #7567:

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948469#comment-17948469 ] ASF GitHub Bot commented on HADOOP-19557: - ahmarsuhail commented on code in PR

Re: [PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() calls [hadoop]

2025-04-30 Thread via GitHub
ahmarsuhail commented on code in PR #7662: URL: https://github.com/apache/hadoop/pull/7662#discussion_r2068635417 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java: ## @@ -829,7 +829,8 @@ public boolean hasCapability(String capability) {

[jira] [Commented] (HADOOP-19414) Upgrade JUnit from 4 to 5 in hadoop-auth.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948467#comment-17948467 ] ASF GitHub Bot commented on HADOOP-19414: - hadoop-yetus commented on PR #7638:

Re: [PR] HADOOP-19414. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-auth. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7638: URL: https://github.com/apache/hadoop/pull/7638#issuecomment-2841908056 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19426) Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948454#comment-17948454 ] ASF GitHub Bot commented on HADOOP-19426: - hadoop-yetus commented on PR #7652:

Re: [PR] HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7652: URL: https://github.com/apache/hadoop/pull/7652#issuecomment-2841794236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19526) Skip tests in Hadoop common that depend on SecurityManager if the JVM does not support it

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948447#comment-17948447 ] ASF GitHub Bot commented on HADOOP-19526: - hadoop-yetus commented on PR #7567:

Re: [PR] HADOOP-19526. Skip tests in Hadoop common that depend on SecurityManager if the JVM does not support it [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7567: URL: https://github.com/apache/hadoop/pull/7567#issuecomment-2841734104 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19212 [JDK23] org.apache.hadoop.security.UserGroupInformation … [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7434: URL: https://github.com/apache/hadoop/pull/7434#issuecomment-2841729274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948438#comment-17948438 ] ASF GitHub Bot commented on HADOOP-19557: - hadoop-yetus commented on PR #7662:

Re: [PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() calls [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7662: URL: https://github.com/apache/hadoop/pull/7662#issuecomment-2841687000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17767. Skip tests that depend on custom SecurityManager when Java doesn't support it [hadoop]

2025-04-30 Thread via GitHub
stoty commented on PR #7566: URL: https://github.com/apache/hadoop/pull/7566#issuecomment-2841663766 I have applied @szetszwo 's changes. Please check again @cnauroth . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] HDFS-17767. Skip tests that depend on custom SecurityManager when Java doesn't support it [hadoop]

2025-04-30 Thread via GitHub
stoty commented on code in PR #7566: URL: https://github.com/apache/hadoop/pull/7566#discussion_r2068464042 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeRegistration.java: ## @@ -79,8 +80,12 @@ public void checkConnect(String host, int port

[jira] [Commented] (HADOOP-19554) LocalDirAllocator still doesn't always recover from directory tree deletion

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948421#comment-17948421 ] ASF GitHub Bot commented on HADOOP-19554: - steveloughran commented on PR #7651:

Re: [PR] HADOOP-19554. LocalDirAllocator still doesn't always recover from directory deletion [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on PR #7651: URL: https://github.com/apache/hadoop/pull/7651#issuecomment-2841458683 I've decided not to target 3.4.2 with this * HDFS uses this, so needs care and attention * for s3a, we can fall back to using memory buffering and a shorter queue of pending

[jira] [Commented] (HADOOP-19554) LocalDirAllocator still doesn't always recover from directory tree deletion

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948420#comment-17948420 ] ASF GitHub Bot commented on HADOOP-19554: - steveloughran commented on code in P

Re: [PR] HADOOP-19554. LocalDirAllocator still doesn't always recover from directory deletion [hadoop]

2025-04-30 Thread via GitHub
steveloughran commented on code in PR #7651: URL: https://github.com/apache/hadoop/pull/7651#discussion_r2068351658 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java: ## @@ -406,27 +411,40 @@ public Path getLocalPathForWrite(String

[jira] [Commented] (HADOOP-19526) Skip tests in Hadoop common that depend on SecurityManager if the JVM does not support it

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948416#comment-17948416 ] ASF GitHub Bot commented on HADOOP-19526: - stoty commented on code in PR #7567:

Re: [PR] HADOOP-19526. Skip tests in Hadoop common that depend on SecurityManager if the JVM does not support it [hadoop]

2025-04-30 Thread via GitHub
stoty commented on code in PR #7567: URL: https://github.com/apache/hadoop/pull/7567#discussion_r2068315273 ## hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestExternalCall.java: ## @@ -65,8 +66,12 @@ private static Configuration getConf() { @BeforeEach

[jira] [Commented] (HADOOP-19417) Upgrade JUnit from 4 to 5 in hadoop-minikdc.

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948412#comment-17948412 ] ASF GitHub Bot commented on HADOOP-19417: - hadoop-yetus commented on PR #7661:

Re: [PR] HADOOP-19417. [Addendum] [JDK17] Upgrade JUnit from 4 to 5 in hadoop-minikdc. [hadoop]

2025-04-30 Thread via GitHub
hadoop-yetus commented on PR #7661: URL: https://github.com/apache/hadoop/pull/7661#issuecomment-2841359585 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19557: Labels: pull-request-available (was: ) > S3A: S3ABlockOutputStream to never log/reject h

[PR] HADOOP-19557 S3A: S3ABlockOutputStream to never log/reject hflush() calls [hadoop]

2025-04-30 Thread via GitHub
steveloughran opened a new pull request, #7662: URL: https://github.com/apache/hadoop/pull/7662 Calls to Syncable.hflush() on S3ABlockOutputStream instances are logged at debug and the statistics counter upgraded ### How was this patch tested? * modify exist

[jira] [Commented] (HADOOP-19557) S3A: S3ABlockOutputStream to never log/reject hflush(): calls

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948409#comment-17948409 ] ASF GitHub Bot commented on HADOOP-19557: - steveloughran opened a new pull requ

[jira] [Commented] (HADOOP-19550) Migrate ViewFileSystemBaseTest to Junit 5

2025-04-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948402#comment-17948402 ] ASF GitHub Bot commented on HADOOP-19550: - stoty commented on PR #7646: URL: ht

Re: [PR] HADOOP-19550. Migrate ViewFileSystemBaseTest to Junit 5 [hadoop]

2025-04-30 Thread via GitHub
stoty commented on PR #7646: URL: https://github.com/apache/hadoop/pull/7646#issuecomment-2841255965 The blanks should be fixed now, @cnauroth . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] HADOOP-19417. [Addendum] [JDK17] Upgrade JUnit from 4 to 5 in hadoop-… [hadoop]

2025-04-30 Thread via GitHub
zhtttylz opened a new pull request, #7661: URL: https://github.com/apache/hadoop/pull/7661 ### Description of PR JIRA: HADOOP-19417. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-minikdc. ### How was this patch tested? mvn clean test & junit test. ### For code changes: