[
https://issues.apache.org/jira/browse/HADOOP-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12314:
Attachment: HADOOP-12314.HADOOP-12111.00.patch
-00:
* replace $results with $result in
[
https://issues.apache.org/jira/browse/HADOOP-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12315:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
hbaseprotoc_postapply in the
[
https://issues.apache.org/jira/browse/HADOOP-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12315:
Attachment: HADOOP-12315.HADOOP-12111.00.patch
-00:
* replace $results with $result in
[
https://issues.apache.org/jira/browse/HADOOP-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694423#comment-14694423
]
Kengo Seki commented on HADOOP-12314:
-
Other concern: modules_workers can increase
Kengo Seki created HADOOP-12316:
---
Summary: Potential false-positive and false-negative in parsing
TAP output
Key: HADOOP-12316
URL: https://issues.apache.org/jira/browse/HADOOP-12316
Project: Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12316:
Attachment: HADOOP-12316.HADOOP-12111.00.patch
-00:
* fix the regex
* fix a footer message
I
[
https://issues.apache.org/jira/browse/HADOOP-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12316:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
Potential false-positive and
[
https://issues.apache.org/jira/browse/HADOOP-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12314:
Description: Follow-up from HADOOP-12247. check_unittests returns the value
of $\{result}, but
[
https://issues.apache.org/jira/browse/HADOOP-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12297:
Attachment: HADOOP-12297.HADOOP-12111.00.patch
Attaching a patch to document this caveat.
[
https://issues.apache.org/jira/browse/HADOOP-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12297:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
test-patch's basedir and
Kengo Seki created HADOOP-12315:
---
Summary: hbaseprotoc_postapply in the test-patch hbase personality
can return a wrong status
Key: HADOOP-12315
URL: https://issues.apache.org/jira/browse/HADOOP-12315
Kengo Seki created HADOOP-12314:
---
Summary: check_unittests in test-patch.sh can return a wrong status
Key: HADOOP-12314
URL: https://issues.apache.org/jira/browse/HADOOP-12314
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12297:
Summary: test-patch's basedir and patch-dir must be directories under the
user's home in docker
[
https://issues.apache.org/jira/browse/HADOOP-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679883#comment-14679883
]
Kengo Seki commented on HADOOP-12297:
-
Sorry, I guessed wrong. It's not a
[
https://issues.apache.org/jira/browse/HADOOP-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12310:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
final memory report sometimes
[
https://issues.apache.org/jira/browse/HADOOP-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12310:
Attachment: HADOOP-12310.HADOOP-12111.00.patch
Attaching a patch. Because it's difficult to
[
https://issues.apache.org/jira/browse/HADOOP-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12275:
Labels: newbie (was: )
Assignee: Kengo Seki
Status: Patch Available (was: Open)
[
https://issues.apache.org/jira/browse/HADOOP-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12275:
Attachment: HADOOP-12275.HADOOP-12111.00.patch
Attaching a patch.
releasedocmaker: unreleased
Kengo Seki created HADOOP-12305:
---
Summary: add support for javascript linter
Key: HADOOP-12305
URL: https://issues.apache.org/jira/browse/HADOOP-12305
Project: Hadoop Common
Issue Type:
Kengo Seki created HADOOP-12306:
---
Summary: make test-patch rubocop plugin configurable
Key: HADOOP-12306
URL: https://issues.apache.org/jira/browse/HADOOP-12306
Project: Hadoop Common
Issue
Kengo Seki created HADOOP-12307:
---
Summary: make test-patch ruby-lint plugin configurable
Key: HADOOP-12307
URL: https://issues.apache.org/jira/browse/HADOOP-12307
Project: Hadoop Common
Issue
[
https://issues.apache.org/jira/browse/HADOOP-12301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12301:
Description:
Some test-patch plugins have problems about counting the diff lines.
1.
Kengo Seki created HADOOP-12308:
---
Summary: make test-patch perlcritic plugin configurable
Key: HADOOP-12308
URL: https://issues.apache.org/jira/browse/HADOOP-12308
Project: Hadoop Common
Issue
[
https://issues.apache.org/jira/browse/HADOOP-12301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12301:
Description:
Some test-patch plugins have problems about counting the diff lines.
1.
Kengo Seki created HADOOP-12303:
---
Summary: test-patch pylint plugin fails silently and votes +1
incorrectly
Key: HADOOP-12303
URL: https://issues.apache.org/jira/browse/HADOOP-12303
Project: Hadoop
Kengo Seki created HADOOP-12301:
---
Summary: Fix some test-patch plugins to count the diff lines
correctly
Key: HADOOP-12301
URL: https://issues.apache.org/jira/browse/HADOOP-12301
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654784#comment-14654784
]
Kengo Seki commented on HADOOP-12286:
-
Thanks Allen for reviewing and committing. I
[
https://issues.apache.org/jira/browse/HADOOP-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12286:
Attachment: HADOOP-12286.HADOOP-12111.00.patch
Attaching a patch. To make this modification more
[
https://issues.apache.org/jira/browse/HADOOP-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12286:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
test-patch pylint plugin should
Kengo Seki created HADOOP-12297:
---
Summary: test-patch docker mode fails if patch-dir is not
specified or specified as an absolute path
Key: HADOOP-12297
URL: https://issues.apache.org/jira/browse/HADOOP-12297
[
https://issues.apache.org/jira/browse/HADOOP-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12287:
Attachment: HADOOP-12287.HADOOP-12111.01.patch
-01:
* Dockerfile modified
add support for perl
[
https://issues.apache.org/jira/browse/HADOOP-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12287:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
add support for perl
[
https://issues.apache.org/jira/browse/HADOOP-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12287:
Attachment: HADOOP-12287.HADOOP-12111.00.patch
Perl::Lint is faster, but it seems not enough
[
https://issues.apache.org/jira/browse/HADOOP-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12256:
Attachment: HADOOP-12256.HADOOP-12111.01.patch
-01:
* sort the ruby-lint output, because its
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647662#comment-14647662
]
Kengo Seki commented on HADOOP-12266:
-
bq. Negative votes still have the version in
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12266:
Attachment: HADOOP-12266.HADOOP-12111.02.patch
-02:
* Removed version info from the vote table
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12266:
Attachment: HADOOP-12266.HADOOP-12111.01.patch
-01:
* fixed unnecessary append file redirections
[
https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12255:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
Add support for rubocop
Kengo Seki created HADOOP-12285:
---
Summary: Reorganize test-patch footer table
Key: HADOOP-12285
URL: https://issues.apache.org/jira/browse/HADOOP-12285
Project: Hadoop Common
Issue Type:
[
https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12255:
Attachment: HADOOP-12255.HADOOP-12111.00.patch
Attaching a patch, which needs HADOOP-12266
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647683#comment-14647683
]
Kengo Seki commented on HADOOP-12266:
-
Oh, I misunderstood your comment. I'll remove
Kengo Seki created HADOOP-12286:
---
Summary: test-patch pylint plugin should support indent-string
option
Key: HADOOP-12286
URL: https://issues.apache.org/jira/browse/HADOOP-12286
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647872#comment-14647872
]
Kengo Seki commented on HADOOP-12255:
-
Got it.
Add support for rubocop
[
https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647850#comment-14647850
]
Kengo Seki commented on HADOOP-12255:
-
Should we add rubocop to the default
[
https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12255:
Attachment: HADOOP-12255.HADOOP-12111.01.patch
-01:
* Ruby and rubocop added to the Dockerfile
[
https://issues.apache.org/jira/browse/HADOOP-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647852#comment-14647852
]
Kengo Seki commented on HADOOP-12255:
-
Oh, passed each other
Add support for
[
https://issues.apache.org/jira/browse/HADOOP-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12256:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
add support for ruby-lint
[
https://issues.apache.org/jira/browse/HADOOP-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12256:
Attachment: HADOOP-12256.HADOOP-12111.00.patch
Attaching a wip patch. I must examine whether the
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12266:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
make test-patch plugins more
[
https://issues.apache.org/jira/browse/HADOOP-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12243:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
Rewrite grep -o's in test-patch
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12266:
Attachment: HADOOP-12266.HADOOP-12111.00.patch
Attaching a patch.
I confirmed that new warnings
[
https://issues.apache.org/jira/browse/HADOOP-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12243:
Attachment: HADOOP-12243.HADOOP-12111.00.patch
Attaching a patch. I confirmed that
[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12204:
Attachment: HADOOP-12204.HADOOP-12111.01.patch
Rebased the patch and fixed the indentation.
[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647158#comment-14647158
]
Kengo Seki commented on HADOOP-12204:
-
Thanks for the review and commitment Allen. I
[
https://issues.apache.org/jira/browse/HADOOP-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647145#comment-14647145
]
Kengo Seki commented on HADOOP-12266:
-
bq. I'm confused by something. Why is the
Kengo Seki created HADOOP-12273:
---
Summary: releasedocmaker.py fails with stacktrace if --project
option is not specified
Key: HADOOP-12273
URL: https://issues.apache.org/jira/browse/HADOOP-12273
[
https://issues.apache.org/jira/browse/HADOOP-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642785#comment-14642785
]
Kengo Seki commented on HADOOP-12273:
-
This code also seems strange.
{code}
if
[
https://issues.apache.org/jira/browse/HADOOP-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12273:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
releasedocmaker.py fails with
[
https://issues.apache.org/jira/browse/HADOOP-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12273:
Attachment: HADOOP-12273.HADOOP-12111.00.patch
Attaching a patch.
releasedocmaker.py fails with
[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12204:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
releasedocmaker should pass
[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12204:
Attachment: HADOOP-12204.HADOOP-12111.00.patch
Attaching a wip patch. Pylint result before this
[
https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12254:
Attachment: HADOOP-12254.HADOOP-12111.00.patch
Attaching a patch. It makes test-patch to run
[
https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12254:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
test-patch.sh should run
[
https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643011#comment-14643011
]
Kengo Seki commented on HADOOP-12254:
-
Surprisingly, the filefilter function in the
[
https://issues.apache.org/jira/browse/HADOOP-12277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12277:
Description: The content should be the same, however, rather than a mvn
site-compatible links, it
[
https://issues.apache.org/jira/browse/HADOOP-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12273:
Attachment: HADOOP-12273.HADOOP-12111.01.patch
Thanks Allen, I fixed the patch.
[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643615#comment-14643615
]
Kengo Seki commented on HADOOP-12204:
-
Thanks Allen, I'll rebase and fix the
[
https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12254:
Attachment: HADOOP-12254.HADOOP-12111.01.patch
Ah, thanks! Attaching a fixed patch. I confirmed
[
https://issues.apache.org/jira/browse/HADOOP-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12265:
Attachment: HADOOP-12265.HADOOP-12111.00.patch
Attaching a patch. I confirmed that pylint is
[
https://issues.apache.org/jira/browse/HADOOP-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12265:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
Pylint should be installed in
Kengo Seki created HADOOP-12265:
---
Summary: Pylint should be installed in test-patch docker
environment
Key: HADOOP-12265
URL: https://issues.apache.org/jira/browse/HADOOP-12265
Project: Hadoop Common
Kengo Seki created HADOOP-12266:
---
Summary: make test-patch plugins more consistent
Key: HADOOP-12266
URL: https://issues.apache.org/jira/browse/HADOOP-12266
Project: Hadoop Common
Issue Type:
[
https://issues.apache.org/jira/browse/HADOOP-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639777#comment-14639777
]
Kengo Seki commented on HADOOP-12265:
-
Documents should be updated also.
Pylint
[
https://issues.apache.org/jira/browse/HADOOP-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636110#comment-14636110
]
Kengo Seki commented on HADOOP-12130:
-
+1 non-binding other than following minor
[
https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12207:
Attachment: HADOOP-12207.HADOOP-12111.02.patch
Thanks Allen, I fixed it.
-02:
* adding version
[
https://issues.apache.org/jira/browse/HADOOP-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633518#comment-14633518
]
Kengo Seki commented on HADOOP-12237:
-
Thanks [~ozawa], I misread your comment.
+1
[
https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633886#comment-14633886
]
Kengo Seki commented on HADOOP-12207:
-
The case no additional error exists:
{code}
[
https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12207:
Attachment: HADOOP-12207.HADOOP-12111.01.patch
Thanks for the reviews and comments. Attaching a
[
https://issues.apache.org/jira/browse/HADOOP-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632303#comment-14632303
]
Kengo Seki commented on HADOOP-10854:
-
Great improvement for shell script quality
[
https://issues.apache.org/jira/browse/HADOOP-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632323#comment-14632323
]
Kengo Seki commented on HADOOP-12118:
-
[~gliptak] If it simplifies java code and
[
https://issues.apache.org/jira/browse/HADOOP-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12157:
Attachment: HADOOP-12157.HADOOP-12111.05.patch
Thanks, I overlooked that case. Attaching a fixed
[
https://issues.apache.org/jira/browse/HADOOP-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632427#comment-14632427
]
Kengo Seki commented on HADOOP-12243:
-
No, I just thought it's easier to rewrite the
[
https://issues.apache.org/jira/browse/HADOOP-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632438#comment-14632438
]
Kengo Seki commented on HADOOP-12237:
-
[~ozawa], I'm not familiar with urllib, but
[
https://issues.apache.org/jira/browse/HADOOP-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12243:
Summary: Rewrite grep -o's in test-patch and smart-apply-patch because it's
not POSIX compliant
[
https://issues.apache.org/jira/browse/HADOOP-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12157:
Attachment: HADOOP-12157.HADOOP-12111.04.patch
Attaching a fixed patch.
test-patch should
Kengo Seki created HADOOP-12243:
---
Summary: Grep command used in test-patch and smart-apply-patch
should be GNU's one, not POSIX
Key: HADOOP-12243
URL: https://issues.apache.org/jira/browse/HADOOP-12243
[
https://issues.apache.org/jira/browse/HADOOP-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629738#comment-14629738
]
Kengo Seki commented on HADOOP-12228:
-
+1 non-binding. All principal features are
[
https://issues.apache.org/jira/browse/HADOOP-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12157:
Attachment: HADOOP-12157.HADOOP-12111.03.patch
bq. I just have some concerns it might match more
[
https://issues.apache.org/jira/browse/HADOOP-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624181#comment-14624181
]
Kengo Seki commented on HADOOP-12157:
-
Patch 03 is also wrong. I'll upload a collect
[
https://issues.apache.org/jira/browse/HADOOP-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623788#comment-14623788
]
Kengo Seki commented on HADOOP-12225:
-
Trivial nit: s/Mavn/Maven/
+1 non-binding
[
https://issues.apache.org/jira/browse/HADOOP-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12187:
Attachment: HADOOP-12187.HADOOP-12111.02.patch
Thanks for the comment Allen, attaching a revised
[
https://issues.apache.org/jira/browse/HADOOP-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12197:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
smart-apply-patch shouldn't
[
https://issues.apache.org/jira/browse/HADOOP-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12197:
Attachment: HADOOP-12197.HADOOP-12111.01.patch
Attaching a patch, though I'm not sure I can
[
https://issues.apache.org/jira/browse/HADOOP-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623433#comment-14623433
]
Kengo Seki commented on HADOOP-12196:
-
bq. I wonder if we are overthinking this and
[
https://issues.apache.org/jira/browse/HADOOP-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12199:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
Optimize find_changed_modules
[
https://issues.apache.org/jira/browse/HADOOP-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12199:
Attachment: HADOOP-12199.HADOOP-12111.01.patch
Attaching a patch. Debug output before this patch
[
https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12207:
Attachment: HADOOP-12207.HADOOP-12111.00.patch
Attaching a patch. Sample output:
{code}
[
https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12207:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
Add support for pylint
[
https://issues.apache.org/jira/browse/HADOOP-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12196:
Attachment: HADOOP-12196.HADOOP-12111.01.patch
Attaching a patch. I adopted the former plan.
[
https://issues.apache.org/jira/browse/HADOOP-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12196:
Assignee: Kengo Seki
Status: Patch Available (was: Open)
shellcheck plugin is picking up
101 - 200 of 403 matches
Mail list logo
