[ 
https://issues.apache.org/jira/browse/HADOOP-16819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850260#comment-17850260
 ] 

Kiran Velumuri commented on HADOOP-16819:
-----------------------------------------

[~ghanko] This issue is still present and causing intermittent failure of  
[TestLlapSignerImpl.testSigning|https://github.com/apache/hive/blob/3c0705eaf5121c7b61f2dbe9db9545c3926f26f1/llap-server/src/test/org/apache/hadoop/hive/llap/security/TestLlapSignerImpl.java#L195]
 - HIVE-22621. Could you please help me to understand why this effort has been 
paused and please help to get this merged? Thank you.

> Possible inconsistent state of AbstractDelegationTokenSecretManager
> -------------------------------------------------------------------
>
>                 Key: HADOOP-16819
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16819
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, security
>    Affects Versions: 3.3.0
>            Reporter: Hankó Gergely
>            Assignee: Hankó Gergely
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HADOOP-16819.001.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> [AbstractDelegationTokenSecretManager.updateCurrentKey|https://github.com/apache/hadoop/blob/581072a8f04f7568d3560f105fd1988d3acc9e54/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java#L360]
>  increments the current key id and creates the new delegation key in two 
> distinct synchronized blocks.
> This means that other threads can see the class in an *inconsistent state, 
> where the key for the current key id doesn't exist (yet)*.
> For example the following method sometimes returns null when the token 
> remover thread is between the two synchronized blocks:
> {noformat}
> @Override
> public DelegationKey getCurrentKey() {
>   return getDelegationKey(getCurrentKeyId());
> }{noformat}
>  
> Also it is possible that updateCurrentKey is called from multiple threads at 
> the same time so *distinct keys can be generated with the same key id*.
>  
> This issue is suspected to be the cause of the intermittent failure of  
> [TestLlapSignerImpl.testSigning|https://github.com/apache/hive/blob/3c0705eaf5121c7b61f2dbe9db9545c3926f26f1/llap-server/src/test/org/apache/hadoop/hive/llap/security/TestLlapSignerImpl.java#L195]
>  - HIVE-22621.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to