[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275613#comment-16275613
]
Ping Liu commented on HADOOP-14600:
---
This is great to hear! Finally, this gets in. Thanks
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273970#comment-16273970
]
Ping Liu edited comment on HADOOP-14600 at 12/1/17 5:47 AM:
Just verified.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273970#comment-16273970
]
Ping Liu commented on HADOOP-14600:
---
Just verified. There is no error!
I missed {{-Pnative}} in
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: command_line_test_result__linux.txt
command_line_test_result__windows.txt
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268098#comment-16268098
]
Ping Liu commented on HADOOP-14600:
---
Yes, Chris. I am verifying the patch. There is an issue just
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263821#comment-16263821
]
Ping Liu edited comment on HADOOP-14600 at 11/23/17 5:01 AM:
-
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263821#comment-16263821
]
Ping Liu commented on HADOOP-14600:
---
[~chris.douglas] Finally, this round is green. That's great! Do
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257912#comment-16257912
]
Ping Liu commented on HADOOP-14600:
---
[~chris.douglas] excellent catch! Your correction is perfect.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239865#comment-16239865
]
Ping Liu commented on HADOOP-14600:
---
This time unit test fails on different test case
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.006.patch
> LocatedFileStatus constructor forces RawLocalFS to exec a
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: (was: HADOOP-14600.006.patch)
> LocatedFileStatus constructor forces RawLocalFS to
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239347#comment-16239347
]
Ping Liu commented on HADOOP-14600:
---
[~chris.douglas] You are right. {{path}} doesn't connect to
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.006.patch
> LocatedFileStatus constructor forces RawLocalFS to exec a
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235082#comment-16235082
]
Ping Liu commented on HADOOP-14600:
---
Can someone have a look at this? As I said before, the unit test
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.005.patch
* Moved up deprecation suppression annotation in
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.004.patch
=> Fixed license issue
- added ASF license header to newly
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186875#comment-16186875
]
Ping Liu commented on HADOOP-14600:
---
[~ste...@apache.org]
Thanks for your detailed code review!
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.003.patch
> LocatedFileStatus constructor forces RawLocalFS to exec a
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160168#comment-16160168
]
Ping Liu commented on HADOOP-14600:
---
Changes has been made. *HADOOP-14600.002.patch* is attached.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.002.patch
> LocatedFileStatus constructor forces RawLocalFS to exec a
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157223#comment-16157223
]
Ping Liu commented on HADOOP-14600:
---
Excellent comments. I'm going to make the suggested changes.
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154192#comment-16154192
]
Ping Liu commented on HADOOP-14600:
---
I couldn't successfully set up a local environment to run
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151289#comment-16151289
]
Ping Liu commented on HADOOP-14600:
---
Yeah, it must be automatically included with MingW, Visual
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151255#comment-16151255
]
Ping Liu commented on HADOOP-14600:
---
Thanks [~aw]! I have both Cygwin and Git. But Neither has
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151090#comment-16151090
]
Ping Liu commented on HADOOP-14600:
---
Now I am trying to do the patch test on my Windows. It looks
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150822#comment-16150822
]
Ping Liu commented on HADOOP-14600:
---
Hi [~jzhuge], thanks for your help!
The patch and the test file
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Liu updated HADOOP-14600:
--
Attachment: HADOOP-14600.001.patch
TestRawLocalFileSystemContract.java
>
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150254#comment-16150254
]
Ping Liu commented on HADOOP-14600:
---
Oops, looks like I don't have permission to attach files. I'll
[
https://issues.apache.org/jira/browse/HADOOP-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150245#comment-16150245
]
Ping Liu commented on HADOOP-14600:
---
I just followed [~steve_l]'s idea to add stat() native
29 matches
Mail list logo