[jira] [Commented] (HADOOP-8275) harden serialization logic against malformed or malicious input

2012-04-13 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253871#comment-13253871 ] Tom White commented on HADOOP-8275: --- Can you write some unit tests for the new

[jira] [Commented] (HADOOP-8209) Add option to relax build-version check for branch-1

2012-04-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252691#comment-13252691 ] Tom White commented on HADOOP-8209: --- I renamed VersionInfo#getBuildVersion to

[jira] [Commented] (HADOOP-8209) Add option to relax build-version check for branch-1

2012-04-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252808#comment-13252808 ] Tom White commented on HADOOP-8209: --- Agree that not changing VersionInfo is better. +1

[jira] [Commented] (HADOOP-7030) new topology mapping implementations

2012-03-22 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235873#comment-13235873 ] Tom White commented on HADOOP-7030: --- Steve - these are good features, but it's better

[jira] [Commented] (HADOOP-8200) Remove HADOOP_[JOBTRACKER|TASKTRACKER]_OPTS

2012-03-22 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236108#comment-13236108 ] Tom White commented on HADOOP-8200: --- +1 Remove

[jira] [Commented] (HADOOP-8167) Configuration deprecation logic breaks backwards compatibility

2012-03-14 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229312#comment-13229312 ] Tom White commented on HADOOP-8167: --- #2 seems like the best option in this case. +1 for

[jira] [Commented] (HADOOP-8098) KerberosAuthenticatorHandler should use _HOST replacement to resolve principal name

2012-02-28 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218419#comment-13218419 ] Tom White commented on HADOOP-8098: --- +1 KerberosAuthenticatorHandler

[jira] [Commented] (HADOOP-8082) add hadoop-client and hadoop-minicluster to the dependency-management section

2012-02-16 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209552#comment-13209552 ] Tom White commented on HADOOP-8082: --- +1 add hadoop-client and

[jira] [Commented] (HADOOP-8083) javadoc generation for some modules is not done under target/

2012-02-16 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209733#comment-13209733 ] Tom White commented on HADOOP-8083: --- ${project.build.directory} is the {{target}}

[jira] [Commented] (HADOOP-8083) javadoc generation for some modules is not done under target/

2012-02-16 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210071#comment-13210071 ] Tom White commented on HADOOP-8083: --- +1 javadoc generation for some

[jira] [Commented] (HADOOP-8074) Small bug in hadoop error message for unknown commands

2012-02-15 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208922#comment-13208922 ] Tom White commented on HADOOP-8074: --- I think this should be reverted so Daryn's

[jira] [Commented] (HADOOP-8055) Distribution tar.gz does not contain etc/hadoop/core-site.xml

2012-02-10 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205535#comment-13205535 ] Tom White commented on HADOOP-8055: --- The patch looks fine to me, but I'm confused by

[jira] [Commented] (HADOOP-8023) Add unset() method to Configuration

2012-02-06 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201441#comment-13201441 ] Tom White commented on HADOOP-8023: --- +1 This is a compatible addition to the 1.x

[jira] [Commented] (HADOOP-8009) Create hadoop-client and hadoop-minicluster artifacts for downstream projects

2012-02-03 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199844#comment-13199844 ] Tom White commented on HADOOP-8009: --- +1 for releasing these artifacts for active

[jira] [Commented] (HADOOP-8003) Make SplitCompressionInputStream an interface instead of an abstract class

2012-01-29 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195856#comment-13195856 ] Tom White commented on HADOOP-8003: --- I think we should try to do this without breaking

[jira] [Commented] (HADOOP-7980) API Compatibility between 0.23 and 1.0 in org.apache.hadoop.io.compress.Decompressor

2012-01-18 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188557#comment-13188557 ] Tom White commented on HADOOP-7980: --- Implementations of custom decompressors can add

[jira] [Commented] (HADOOP-7939) Improve Hadoop subcomponent integration in Hadoop 0.23

2012-01-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185384#comment-13185384 ] Tom White commented on HADOOP-7939: --- What is the reason to revert symlink resolution

[jira] [Commented] (HADOOP-7920) Remove Avro RPC

2012-01-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185434#comment-13185434 ] Tom White commented on HADOOP-7920: --- The remaining classes are for AvroSerialization,

[jira] [Commented] (HADOOP-7934) Normalize dependencies versions across all modules

2012-01-05 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180672#comment-13180672 ] Tom White commented on HADOOP-7934: --- +1 Thanks for running the tests.

[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs and friends from Hadoop 1.x

2012-01-05 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180962#comment-13180962 ] Tom White commented on HADOOP-7937: --- The javac warning is because sync() is deprecated.

[jira] [Commented] (HADOOP-7934) Normalize dependencies versions across all modules

2012-01-03 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13178915#comment-13178915 ] Tom White commented on HADOOP-7934: --- +1 This looks good to me. Have you been able to

[jira] [Commented] (HADOOP-7939) Improve Hadoop subcomponent integration in Hadoop 0.23

2011-12-29 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177241#comment-13177241 ] Tom White commented on HADOOP-7939: --- bq. We already have almost *all* of the proposed

[jira] [Commented] (HADOOP-7732) hadoop java docs bad pointer to hdfs package

2011-12-28 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176718#comment-13176718 ] Tom White commented on HADOOP-7732: --- Hi Matt, there's some more background at

[jira] [Commented] (HADOOP-7732) hadoop java docs bad pointer to hdfs package

2011-12-27 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176312#comment-13176312 ] Tom White commented on HADOOP-7732: --- Since HDFS is accessed by users through FileSystem

[jira] [Commented] (HADOOP-7912) test-patch should run eclipse:eclipse to verify that it does not break again

2011-12-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167683#comment-13167683 ] Tom White commented on HADOOP-7912: --- Apart from a typo (checkEclpiseGeneration) this

[jira] [Commented] (HADOOP-7884) test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.

2011-12-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167676#comment-13167676 ] Tom White commented on HADOOP-7884: --- The test-patch builds run with the base directory

[jira] [Commented] (HADOOP-7884) test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.

2011-12-12 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167773#comment-13167773 ] Tom White commented on HADOOP-7884: --- As things stand, test-patch will always do a build

[jira] [Commented] (HADOOP-7899) Generate proto java files as part of the build

2011-12-09 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166500#comment-13166500 ] Tom White commented on HADOOP-7899: --- +1 Generate proto java files as

[jira] [Commented] (HADOOP-7810) move hadoop archive to core from tools

2011-12-09 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166711#comment-13166711 ] Tom White commented on HADOOP-7810: --- +1 for the trunk patch. move

[jira] [Commented] (HADOOP-7738) Document incompatible API changes between 0.20.20x and 0.23.0 release

2011-12-06 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163731#comment-13163731 ] Tom White commented on HADOOP-7738: --- Here are some notes on the differences I have

[jira] [Commented] (HADOOP-7874) native libs should be under lib/native/ dir

2011-12-01 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161071#comment-13161071 ] Tom White commented on HADOOP-7874: --- Sounds reasonable. What testing did you do on the

[jira] [Commented] (HADOOP-7874) native libs should be under lib/native/ dir

2011-12-01 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161260#comment-13161260 ] Tom White commented on HADOOP-7874: --- +1 native libs should be under

[jira] [Commented] (HADOOP-7874) native libs should be under lib/native/ dir

2011-11-30 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13160509#comment-13160509 ] Tom White commented on HADOOP-7874: --- it is using lib/native/${JAVA_PLATFORM} for the

[jira] [Commented] (HADOOP-7590) Mavenize streaming and MR examples

2011-11-22 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155295#comment-13155295 ] Tom White commented on HADOOP-7590: --- Arun, I don't feel strongly where streaming lives.

[jira] [Commented] (HADOOP-7590) Mavenize streaming and MR examples

2011-11-18 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152972#comment-13152972 ] Tom White commented on HADOOP-7590: --- I don't disagree with this assessment, but can't

[jira] [Commented] (HADOOP-7590) Mavenize streaming and MR examples

2011-11-18 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153255#comment-13153255 ] Tom White commented on HADOOP-7590: --- Looks good to me, +1. I think it's OK to fix the

[jira] [Commented] (HADOOP-7590) Mavenize streaming and MR examples

2011-11-17 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152387#comment-13152387 ] Tom White commented on HADOOP-7590: --- I think the tests are relevant as they act as

[jira] [Commented] (HADOOP-7590) Mavenize streaming and MR examples

2011-11-17 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152660#comment-13152660 ] Tom White commented on HADOOP-7590: --- How about opening a JIRA for these failing tests

[jira] [Commented] (HADOOP-7809) Backport HADOOP-5839 to 0.20-security - fixes to ec2 scripts to allow remote job submission

2011-11-08 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146779#comment-13146779 ] Tom White commented on HADOOP-7809: --- Joydeep, have you looked at Whirr

[jira] [Commented] (HADOOP-7801) HADOOP_PREFIX cannot be overriden

2011-11-07 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145737#comment-13145737 ] Tom White commented on HADOOP-7801: --- +1 This is a reasonable change. Nit: the change

[jira] [Commented] (HADOOP-7802) hadoop script unconditionnaly source $bin/../libexec/hadoop-config.sh

2011-11-07 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145739#comment-13145739 ] Tom White commented on HADOOP-7802: --- +1 hadoop script unconditionnaly

[jira] [Commented] (HADOOP-7787) binary and source tarball names are not consistent

2011-11-07 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145747#comment-13145747 ] Tom White commented on HADOOP-7787: --- I would suggest hadoop-${project.version}.tar.gz

[jira] [Commented] (HADOOP-7590) Mavenize the MR1 JARs (main and test) creation

2011-11-01 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141305#comment-13141305 ] Tom White commented on HADOOP-7590: --- Alejandro, the problem you are seeing won't be a

[jira] [Commented] (HADOOP-7785) Add equals, hashcode, toString to DataChecksum

2011-10-31 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140941#comment-13140941 ] Tom White commented on HADOOP-7785: --- +1 Add equals, hashcode,

[jira] [Commented] (HADOOP-7782) Add a way to merge javadocs?

2011-10-29 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139442#comment-13139442 ] Tom White commented on HADOOP-7782: --- The short answer is mvn javadoc:aggregate

[jira] [Commented] (HADOOP-7741) Maven related JIRAs to backport to 0.23

2011-10-26 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136056#comment-13136056 ] Tom White commented on HADOOP-7741: --- HADOOP-7763 Maven related JIRAs

[jira] [Commented] (HADOOP-7741) Maven related JIRAs to backport to 0.23

2011-10-26 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136618#comment-13136618 ] Tom White commented on HADOOP-7741: --- HADOOP-7768 Maven related JIRAs

[jira] [Commented] (HADOOP-7758) Make GlobFilter class public

2011-10-19 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131134#comment-13131134 ] Tom White commented on HADOOP-7758: --- +1 this looks better. Add some class-level javadoc

[jira] [Commented] (HADOOP-7755) Detect MapReduce PreCommit Trunk builds silently failing when running test-patch.sh

2011-10-18 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130017#comment-13130017 ] Tom White commented on HADOOP-7755: --- +1 Detect MapReduce PreCommit

[jira] [Commented] (HADOOP-7737) normalize hadoop-mapreduce hadoop-dist dist/tar build with common/hdfs

2011-10-13 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126880#comment-13126880 ] Tom White commented on HADOOP-7737: --- +1 I tried with and without -Dtar. I managed to

[jira] [Commented] (HADOOP-7738) Document incompatible API changes between 0.20.20x and 0.23.0 release

2011-10-13 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126984#comment-13126984 ] Tom White commented on HADOOP-7738: --- I would like to eliminate the false positives

[jira] [Commented] (HADOOP-7743) Add Maven profile to create a full source tarball

2011-10-13 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127014#comment-13127014 ] Tom White commented on HADOOP-7743: --- +1 Add Maven profile to create a

[jira] [Commented] (HADOOP-7035) Document incompatible API changes between releases

2011-09-29 Thread Tom White (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117776#comment-13117776 ] Tom White commented on HADOOP-7035: --- 1. Is it possible that the tool needs to be