[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-21 Thread via GitHub
Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1517600783 Okay, maybe i was to quick again...

[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-20 Thread via GitHub
Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1516585419 > I didn't catch that, which integration tool? you have some internal integration tool? We are just changing the name of a test class. > > Ok, may be just leave that test class

[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-19 Thread via GitHub
Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1515091484 > Can you rebase this and check if the checkstyle warnings are introduced by this change. > > Avoid any unrelated change apart from fixing the typo. If you find some other

[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-04-19 Thread via GitHub
Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1515090681 I do not think the changes still work. since the complaint is from the integration tool that does not like that i changed the name of 2 java files. -- This is an automated message

[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

2023-03-14 Thread via GitHub
Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1468109556 > There are some 21 occurrences in the project, do you plan to volunteer fix in one go? Committing one-one occurrence might be too much. > > Any IDE should get you sorted in just