[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r932136279 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: Th

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930987990 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: >

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930987990 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: >

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930293301 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: I

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930252453 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: @g

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929126701 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj.filters: ## @@ -48,19 +46,16 @@ Source Files - - Source Files

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929121380 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -142,16 +140,16 @@ /D HADOOP_ISAL_LIBRARY=L\"isa-l.dll\" -

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #4616: HADOOP-18357. Retarget solution file to VS2019

GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929120970 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: I