Nargeshdb commented on a change in pull request #2790:
URL: https://github.com/apache/hadoop/pull/2790#discussion_r598850886
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
##########
@@ -264,9 +264,9 @@ void format(NamespaceInfo nsInfo, boolean force) throws
IOException {
*/
@Override // Closeable
public void close() throws IOException {
- storage.close();
Review comment:
Yes, exactly. If it throws an exception, then committedTxnId and
curSegment are never closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
