[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-01 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961258064 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1122,41 +1115,50 @@ public void testSelectV

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-01 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961257965 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-08-25 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r955628485 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-08-25 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r955628327 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-08-25 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r955628159 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-08-25 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r955627989 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-08-25 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r955627637 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java: ## @@ -750,10 +750,13 @@ public GetJournaledEditsResponseProto get

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-08-25 Thread GitBox
ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r955627539 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java: ## @@ -750,10 +750,13 @@ public GetJournaledEditsResponseProto get