[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1205937429 The failed UT `org.apache.hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes.testBalancerWithObserverWithFailedNode` works well locally. -- This is an automated message from the A

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1205113551 @ferhui Sir, thanks for your review. > CI reported that 'This branch has conflicts that must be resolved' I have fixed this conflict. This conflict is in `EditLogTailer.java`

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1203488819 @ferhui Thanks for your review. I have updated this patch based on the latest trunk. Please help me review it again, thanks. -- This is an automated message from the Apache Git

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1193144300 > can correct them in the classes you modified. @ferhui I have corrected them, please help me review it again. Thanks~ -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1192649976 Copy, I will correct them. Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1192231376 > After completing this pr, can you help summarize the precautions in the process of using logger, so that other partners can refer to it later? @slfan1989 Sure, I will summarize it

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1192230791 can remove isDebugEnabled from those clauses without '+' --- Do you mean correct all classes in hadoop-hdfs module? In this patch, I just modified the classes that are used fre

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1190973192 @slfan1989 ping. Can you push this PR forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1183206857 > I have one question to ask, that is why some code should remove LOG.isDebugEnabled()? @slfan1989 Thanks for your review. If you have any other questions or good ideas, please le

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1178595411 @goiri thanks for your review, I learned a lot and have updated the patch. Please help me review it again. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1175795921 > What are we saving by doing this? In [PR-4480](https://github.com/apache/hadoop/pull/4480#event-6923776715), I do a performance stress test about it. And found that adding isDebugEnab