[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-01 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1234914937 @xkrogen Sir, sorry to ping you again. Please help me review this patch again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-06 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1238805756 @xkrogen Sir, thank you for your patient answers and reviews, as well as nice suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-13 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1245232780 @xkrogen After deep thinking and do some verifications, I found there are two places should be fixed for the case that `sinceTxId = highestTxId + 1`. Currently Journal throws one `N

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-13 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1245257209 @xkrogen Sir, I create a new ticket HDFS-16771 to resolve this problems. If you have any good ideas, please share with me. Thanks. -- This is an automated message from the Apache Git Se