[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-08-01 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1201842552 Thanks @slfan1989 for you review and nice suggestion. I will close this PR and accomplish it in HDFS-16695. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190972132 @slfan1989 Thanks for your suggestion, I will create a draft PR to found all places of Hadoop-Hdfs module. After I completed it, I'm asking for your help to review it. -- This is an au

[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190317977 I can create an issue to optimize lambda in hadoop-hdfs module. And create some sub tasks to fix one by one. We can review sub PRs and merge them into the big issue first, then merge it t

[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190310464 Thanks @slfan1989 for your suggestion. I can create a new PR to optimize lambda in hadoop-hdfs moudle, but it will be a huge PR. It will be difficult for reviewing and merging. In additi