[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-15 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1214872605 @Hexiaoqiao @ayushtkn Master, ping, please help me merge this PR and review [PR-4699](https://github.com/apache/hadoop/pull/4699)? Thanks -- This is an automated message from the Apache

[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-07 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1207529359 Yes, we are here, and I have create a new [PR-4699](https://github.com/apache/hadoop/pull/4699) to fix other cases in DataNode.java. @ayushtkn @Hexiaoqiao Can you help me review th

[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-03 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1204212206 @Hexiaoqiao Thanks for your review. > Would you mind to give another check? Sure, I will check them. BTW, If it's ok, can I fix them in a new PR? I hope this PR is just used to f

[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-01 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1201945547 @ayushtkn Thank you very much for helping me review it. Yes, you are right, we should return an empty value for this case. How about change it same with `getDiskBalancerStatus`, suc