aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321492007
Thank you @ashutoshcipher for your contribution and thank you @slfan1989 for
your review! Also, thank you for cleaning up bunch of checkstyle issues :)
> hadoop-yarn-project: The pa
aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321479607
Thank you @ashutoshcipher The test result looks good to me. Could you revert
the empty line change?
--
This is an automated message from the Apache Git Service.
To respond to the messag
aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1312930418
> CONFLICT (content): Merge conflict in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/BasePBImplRecordsTest.java
I could reproduce it.
aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1306832333
I want to check if there's other YARN modules depend on the test class in
hadoop-yarn-common before merging this.
--
This is an automated message from the Apache Git Service.
To respond
aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1305767597
Thank you @ashutoshcipher for your patch. I reviewed 57 out of 105 files and
now I have no comments. I'll review the rest tomorrow.
--
This is an automated message from the Apache Git S
