[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #4706: HADOOP-18073. Adds in s3 client config and updates list.

2022-08-23 Thread GitBox
ahmarsuhail commented on code in PR #4706: URL: https://github.com/apache/hadoop/pull/4706#discussion_r952789775 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/TestRequestFactory.java: ## @@ -170,9 +170,11 @@ private void createFactoryObjects(RequestFacto

[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #4706: HADOOP-18073. Adds in s3 client config and updates list.

2022-08-21 Thread GitBox
ahmarsuhail commented on code in PR #4706: URL: https://github.com/apache/hadoop/pull/4706#discussion_r950871357 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ## @@ -390,4 +490,63 @@ protected static AmazonS3 configureAmazonS3Clie