ahmarsuhail commented on pull request #3927:
URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1066846326
@mukund-thakur @mehakmeet would you be able to take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ahmarsuhail commented on pull request #3927:
URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1068149236
thanks for the review @mehakmeet. I've made some of the changes and had a
couple of questions for the other comments.
--
This is an automated message from the Apache Git
ahmarsuhail commented on pull request #3927:
URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1069313450
Thanks for clarifying @mehakmeet, I've updated the test, and made changes in
`skip()` to update `nextReadPos` and use `getPos()`
--
This is an automated message from the A
ahmarsuhail commented on pull request #3927:
URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1076254943
@mehakmeet are these changes okay now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ahmarsuhail commented on PR #3927:
URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1305339683
@steveloughran have rebased, also tested again, no test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
