ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1547944652
> I'm going to merge this in and then play with myself
did you mean to trunk or somewhere else?
I was thinking I'll complete the rebase and we can update this feature
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1547890139
sounds good. I'm currently working on rebasing, there are couple of things
that went into trunk for MPU which are causing conflicts, I should be able to
complete the rebase and test
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1520407484
sounds good. I've to follow up with a few other fixes anyway. For fixing the
spotbugs issue, do you mean reverting the changes made for spotbugs (moving to
a separate method)?
--
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1516104764
couldn't get `mvn findbugs:findbugs` to run, got ` [java] The following
classes needed for analysis were missing:
[java] java.lang.Object
[java]
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1511606609
I added
```
```
to hadoop-tools/hadoop-aws/dev-support/findbugs-exclude.xml, but that hasn't
suppressed the spotbug for some reason.
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1511108657
thanks @steveloughran, `s3AsyncClient` looks safe to me, have suppressed the
warning. Like you mentioned, Similar to the `futurePool`, it's created in the
unsynchronized initialize()
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1490355464
Add the amazon.cn check where? haven't added `Endpoint is not set ||
Endpoint is set && ends in amazonaws.com || ARN is set` in this PR (if that is
where you meant)
--
This is an
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1485030132
Sounds good, I've created
[this](https://issues.apache.org/jira/browse/HADOOP-18683) JIRA for adding in a
new config option. Are we ok to merge this PR?
Also, I was wondering,
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1479763570
I have some concerns for about this region first approach for third party
stores as well. The region probe is not going to work. I don't know how regions
actually work for third party
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1476471723
thanks @steveloughran, have addressed most comments and have a couple of
questions. Will open a JIRA for the follow up items mentioned, and also for
setting a socket factory for the
ahmarsuhail commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1450136517
@steveloughran this PR addresses (most) outstanding issues with the SDK
upgrade PR, could you please review? Not sure why the yetus unit tests are
failing, they run fine locally. And
11 matches
Mail list logo
