amaroti commented on pull request #2897: URL: https://github.com/apache/hadoop/pull/2897#issuecomment-819387790
@bgaborg I have tested this manully with hand using two clusters. I have not yet looked into how the unit tests look like for hadoop. I will take a look at it. Also Ayush Saxena (@ayushtkn) had made some usefull points on the jira ticket that I will take a look at shortly: https://issues.apache.org/jira/browse/HADOOP-17611?focusedCommentId=17320445&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17320445 > Seems there are two PRs, More or less doing the same thing I guess, I just had a glance on the second one, > > So, who ever plans to chase this, Couple of points to keep in mind: > > We need a test in AbstractContractDistCpTest which all the FileSystems can also use > Should cover two scenarios. First When preserve Time is specified it should preserve time and when not it shouldn't in case of parallel copy. The latter case is working ok as of now, To make sure we don't change the behaviour > The parent modification time is to be preserved when the parent is in the scope of copy, not always. say your are copying /dir/fil1 to /dir1/file2 using parallel copy, then we don't touch /dir1 AFAIK > > The above are the basic requirements, Now the below stuff, If possible we should do: > > For parent directories preserve only once, say if you have 10K files under that parent, then do that setTimes 10K times. > And if the parallel copy is enabled, there is no point of preserving before concat operation, we can save that call. > > > > This isn't a one liner, and throw some challenges, So, please decide who wants to chase this and together work on one PR only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
