[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989124730 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java: ## @@ -2003,4 +2006,40 @@ public void testContentTy

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989124730 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java: ## @@ -2003,4 +2006,40 @@ public void testContentTy

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989120654 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java: ## @@ -73,39 +102,15 @@ import org.apache.hadoop

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989119024 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSParametersProvider.java: ## @@ -127,6 +126,10 @@ public class HttpFS

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989115132 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java: ## @@ -2192,4 +2194,76 @@ public Void execute(FileSyste

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989110352 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java: ## @@ -1882,18 +1884,52 @@ public BlockLocation[] getFil

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989106311 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java: ## @@ -965,4 +968,53 @@ private static SnapshotStatus toSna

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989105774 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java: ## @@ -370,7 +370,26 @@ public InputStream run() throws