[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5568: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

2023-05-12 Thread via GitHub
ayushtkn commented on code in PR #5568: URL: https://github.com/apache/hadoop/pull/5568#discussion_r1192839897 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java: ## @@ -379,13 +380,18 @@ public static

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5568: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

2023-04-19 Thread via GitHub
ayushtkn commented on code in PR #5568: URL: https://github.com/apache/hadoop/pull/5568#discussion_r1171494224 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java: ## @@ -383,7 +384,9 @@ public ShortCircuitCache(int