[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-25 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-848475017 @zhuxiangyi Thanks for contribution, @goiri Thanks for review!, merged to trunk! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-19 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-843997354 @zhuxiangyi Thanks, i think it is reasonable, go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-842789126 @zhuxiangyi the case i mentioned is common, not special. If you delete directory, the baseTrashPath(even if TrashRoot exists) would be created (first time). Anyway, I think 1st wa

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-842747337 @zhuxiangyi So I get a bit confused, what is the problem that this PR resolves ? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-841962259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-17 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-842146030 @zhuxiangyi Thanks for comments! > With this solution, as long as there is a mount point for Trash and the Trash directory exists, Router can move data to Trash. I want to kn

[GitHub] [hadoop] ferhui commented on pull request #3009: HDFS-16024: RBF: Rename data to the Trash should be based on src loca…

2021-05-16 Thread GitBox
ferhui commented on pull request #3009: URL: https://github.com/apache/hadoop/pull/3009#issuecomment-841962259 @zhuxiangyi Thanks for contribution. @goiri Thanks for review! It's an interesting issue. Do you give more details about your production cases? Some comments about the descr