[GitHub] [hadoop] ferhui commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

ferhui commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1209082414 @ZanderXu Good catch! Change visibility because of Test cases, right? Is there a way to avoid changing it and make it concise? -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop] ferhui commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

ferhui commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1210072454 I'm not sure. How about adding a test utility class to that package? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] ferhui commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

ferhui commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1212715520 @ZanderXu Thanks for your contribution! Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop] ferhui commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

ferhui commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1214926249 @xkrogen Thanks for pointing it out. Reverted. @ZanderXu can raise a new MR and we can discuss it later. -- This is an automated message from the Apache Git Service. To respond to the mes