[GitHub] [hadoop] flaming-archer commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-27 Thread via GitHub
flaming-archer commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1695119686 > final bit of credit; is `TIsNotT` your jira account id? as we need to credit you on jira too yes, it is my jira account id. -- This is an automated message from the Apach

[GitHub] [hadoop] flaming-archer commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-24 Thread via GitHub
flaming-archer commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1691503212 > hey, remember to include the JIRA ID in the commit title; when i first saw this in the commit message i thought it was a CVE fix going in. > > how about we revert and then r

[GitHub] [hadoop] flaming-archer commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-22 Thread via GitHub
flaming-archer commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1689214830 I don't think the failure of the above test has anything to do with my pr. Can anybody merge my code now. Thx. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] flaming-archer commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-20 Thread via GitHub
flaming-archer commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1685282215 When will this code be merged, so it will become my first PR. Hhh,😄. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] flaming-archer commented on pull request #5959: HDFS-17162. RBF: Add missing comments in StateStoreService

2023-08-18 Thread via GitHub
flaming-archer commented on PR #5959: URL: https://github.com/apache/hadoop/pull/5959#issuecomment-1683535756 @simbadzina Could you please help to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t