functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822806901
> No, it's a non-blocking write so by definition it will never hang – unless
induced by fault injection.
@daryn-sharp I have considered this counterargument in
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822713500
> Thanks @functioner
> The detailed discussions (except the lambda argument) should have been on
the Jira.
>
> > IMO, this is a classic Producer-Consumer problem,
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822649368
> Thanks @functioner
> The detailed discussions (except the lambda argument) should have been on
the Jira.
I see. I will make a comment of summary in Jira after the
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822617097
> > In that case, please change the title of the Jira and the description to
remove references to "hanging" problems.
>
> @amahussein I still would like to argue about
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822591028
> In that case, please change the title of the Jira and the description to
remove references to "hanging" problems.
@amahussein I still would like to argue about this
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822564254
> If any concerns about lambda expression, we could improve it rather than
reject it directly.
@amahussein A common way to eliminate such overhead is preparing multiple
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822054054
@amahussein Thanks for the comment.
Can I send an email to you to explain more about the issue? @Hexiaoqiao and
I have some more discussion on it, and some discussion is
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-820106508
@Hexiaoqiao thanks for the reminder. I've added:
1. comments for removing `logSyncNotifyExecutor.shutdown()`
2. configuration for the size of `logSyncNotifyExecutor`
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819605128
@Hexiaoqiao Thanks for the comment, I removed
`logSyncNotifyExecutor.shutdown()`.
I think we also need to add some comments in the code to show why we don't
shutdown
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-806363752
> @functioner would you mind to add unit test to cover this improvement?
I'm writing a unit test to cover this improvement. After I read the test
cases of `TestEditLog`
functioner commented on pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#issuecomment-806219473
Thanks @Hexiaoqiao for your review. I have added the multi-threaded executor
for it.
For the exception handling part, I observe the original semantics of
`RpcEdit`
11 matches
Mail list logo
