goiri commented on code in PR #5946: URL: https://github.com/apache/hadoop/pull/5946#discussion_r1294841343
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java: ########## @@ -623,4 +648,22 @@ public void initUserPipelineMap(Configuration conf) { YarnConfiguration.DEFAULT_ROUTER_PIPELINE_CACHE_MAX_SIZE); this.userPipelineMap = Collections.synchronizedMap(new LRUCacheHashMap<>(maxCacheSize, true)); } + + private URL getRedirectURL() throws Exception { + Configuration conf = getConfig(); + String webAppAddress = WebAppUtils.getWebAppBindURL(conf, YarnConfiguration.ROUTER_BIND_HOST, + WebAppUtils.getRouterWebAppURLWithoutScheme(conf)); + String[] hostPort = StringUtils.split(webAppAddress, ':'); + if (hostPort.length != 2) { + throw new YarnRuntimeException("Router can't get valid redirect proxy url"); + } + String host; + if (StringUtils.isBlank(hostPort[0]) || hostPort[0].equals("0.0.0.0")) { Review Comment: Probably we can go directly: ``` String host= hostPort[0]; if (StringUtils.isBlank(host) || host.equals("0.0.0.0")) { host = InetAddress.getLocalHost().getCanonicalHostName(); } ``` ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java: ########## @@ -623,4 +648,22 @@ public void initUserPipelineMap(Configuration conf) { YarnConfiguration.DEFAULT_ROUTER_PIPELINE_CACHE_MAX_SIZE); this.userPipelineMap = Collections.synchronizedMap(new LRUCacheHashMap<>(maxCacheSize, true)); } + + private URL getRedirectURL() throws Exception { + Configuration conf = getConfig(); + String webAppAddress = WebAppUtils.getWebAppBindURL(conf, YarnConfiguration.ROUTER_BIND_HOST, + WebAppUtils.getRouterWebAppURLWithoutScheme(conf)); + String[] hostPort = StringUtils.split(webAppAddress, ':'); + if (hostPort.length != 2) { + throw new YarnRuntimeException("Router can't get valid redirect proxy url"); + } + String host; + if (StringUtils.isBlank(hostPort[0]) || hostPort[0].equals("0.0.0.0")) { + host = InetAddress.getLocalHost().getCanonicalHostName(); + } else { + host = hostPort[0]; + } + return new URL(YarnConfiguration.useHttps(this.getConfig()) ? "https" : "http", host, + Integer.parseInt(hostPort[1]), ""); Review Comment: Extract the port. ``` String scheme = YarnConfiguration.useHttps(this.getConfig()) ? "https" : "http"; int port = Integer.parseInt(hostPort[1]), "") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org