haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1556804800
> we can live with that 150 checkstlye warning, some tests are indeed huge,
didn't like this checkstyle warning itself, should relax this a bit for atleast
for test code.
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1555609612
Update PR.
please @ayushtkn @virajjasani help review it again, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554608527
> > a miss on the actual PR. "Period"
>
> I agree.
>
> @haiyang1987 for this PR, since you already have the opportunity, I would
like to propose these changes so that any
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554602389
> In case you find the numbers messed up for any of the other commands as
well, can you raise a ticket to fix it as well?
yeah, I will review the code and if I find that the
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1554599509
Thanks @ayushtkn @virajjasani help me review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1553914007
Hi @Hexiaoqiao @ZanderXu @tomscut @ayushtkn please help review this minor
changes when you are available, Thanks.
--
This is an automated message from the Apache Git
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1553913412
The failed unit test seems unrelated to the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
haiyang1987 commented on PR #5667:
URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1552654604
Jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
