[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-06 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1578868127 Thanks a lot, sir Replied Message | From | ***@***.***> | | Date | 06/06/2023 22:22 | | To | ***@***.***> | | Cc | ***@***.***>***@***.***> |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-06 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1578249636 > Should we skip dnd and dnd2 when turn on heartbeat here? Otherwise the corrupt replicas may be deleted from InvalidateBlock if delete commands are sent. @zhangshuyan0 Hi,

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-05 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1576468725 @Hexiaoqiao he @ayushtkn @sodonnel @zhangshuyan0 Hi, sir. Could you please help me to push this issue forward ? Thanks again. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-25 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1562543360 @ayushtkn Sir, feel so sorry about involving you here too late. could you also please help review this PR ? Thanks a lot. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-22 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1556708182 ![image](https://github.com/apache/hadoop/assets/25115709/a181d152-e642-4b41-a770-03b7f8d693f2) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-21 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1556424290 > @Hexiaoqiao Sir, thanks for your suggestions. 1、The failed UT was passed in my local environment. 2、I have fixed checkstyle problems. Thanks again. -- This is

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-19 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1554053305 @ayushtkn Sir, could you please also help me review this PR ？ thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-17 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1552291958 fix checkstyle, hadoop.hdfs.TestErasureCodingPolicies and hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy were passed in my local environment. --

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-17 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1551205998 > @hfutatzhanghb Thanks for involving me here. It makes sense to me. +1 to "add a test somehow to reproduce the issue and check if it is fixed". > > > In other words, if a

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-16 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1549846297 > Have you validated this change works correctly, as I did not test the code when I wrote it? > > Also, do you think you could add a test somehow to reproduce the issue and

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-16 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1549102000 Hi, @sodonnel @Hexiaoqiao @tomscut , could you please help me review the code. thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-12 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1545343969 > Hi, @sodonnel . Sorry for replying late and thanks your reviewing. I totally agree with you. Current fix still has problems, I will take a look at this continuously.