[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-31 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1658078551 > Hi @hfutatzhanghb , Thanks for your contribution. When review PRs, I found that #5889, #5891, #5814 both try to solve the same issue but split them, right? If true, I just suggest

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-27 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1653616192 > Thank you very much for your detailed description of the bug, it made me understand. We need to fix the case where there are two internal blocks of the same block group on the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-26 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1651191979 @zhangshuyan0 @Hexiaoqiao @slfan1989 Sir, this PR has been moved to https://github.com/apache/hadoop/pull/5891. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-26 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1651135519 @Hexiaoqiao @zhangshuyan0 Sir, thanks for replying. Yes, I met some issues. Details are below: 1. As mentioned in [HDFS-17047](https://issues.apache.org/jira/browse/HDFS-17047),

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649746379 @Hexiaoqiao @ayushtkn @slfan1989 @tomscut Sir, could you please help me review this code when you have free time ? Thanks a lot. -- This is an automated message from the Apache

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-25 Thread via GitHub
hfutatzhanghb commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1649723105 > @hfutatzhanghb Thanks for your contribution! Can we apply for a JIRA ticket? @slfan1989 Sir, thanks for replying, have updated JIRA ticket~ -- This is an automated