iwasakims edited a comment on pull request #2727:
URL: https://github.com/apache/hadoop/pull/2727#issuecomment-787853012


   @functioner @ferhui, I made the timeout configurable by introducing 
`ipc.client.rpc-timeout.ms` in 
[HADOOP-11252](https://issues.apache.org/jira/browse/HADOOP-11252). Since the 
code was intended to keep behavior on existing deployment not using 
`ipc.client.rpc-timeout.ms` in the configuration, you may feel it is not 
straightforward. IPC_CLIENT_RPC_TIMEOUT_DEFAULT was set to 0 for the same 
reason. Since there has been no error report around the 
ipc.client.rpc-timeout.ms for a long time, changing the default value should be 
OK now. If just updating the the value of IPC_CLIENT_RPC_TIMEOUT_DEFAULT and 
relevant tests is enough, it should be better than modifying Client.java in 
order to avoid bringing new bug.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to