[GitHub] [hadoop] jianghuazhu commented on pull request #3376: HDFS-16208. Support Delete API with FGL.

2022-07-28 Thread GitBox
jianghuazhu commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1198838825 Thanks @prasad-acit . I have read your update carefully, here are some of my personal insights: 1. We should hold child locks in FSDirDeleteOp, here are some of my suggestions.

[GitHub] [hadoop] jianghuazhu commented on pull request #3376: HDFS-16208. Support Delete API with FGL.

2022-06-02 Thread GitBox
jianghuazhu commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1144654653 Hi @prasad-acit , nice to talk to you. For delete using FGL, it may be safer to add child locks before fsn.removeLeasesAndINodes(). ![image](https://user-images.githubusercontent