liuml07 commented on a change in pull request #2841:
URL: https://github.com/apache/hadoop/pull/2841#discussion_r606038591
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
##########
@@ -241,6 +241,13 @@ public void run() {
.start();
} catch (SocketTimeoutException ignored) {
// wake up to see if should continue to run
+ if (peer != null) {
+ LOG.warn("A timeout occurred between DataXceiverServer: {} " +
Review comment:
1. Let's rename the `ignored` to ste as now we are not ignoring it.
2. Let's not use warn level here. This seems not a concern for this timeout
exception generally. I think info this level and `debug` for the `else` clause
should be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
