ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-967711751
Paging @steveloughran @aw-was-here @busbey ... we'd like to ship this
opentelemetry-agent.jar in the distribution but we don't want it on the class
path. Can you advise on how w
ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-966557663
Okay, this patch to your branch,
```
diff --git a/hadoop-client-modules/hadoop-client/pom.xml
b/hadoop-client-modules/hadoop-client/pom.xml
index dced359b286..82f38cc77e
ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-966536367
Oh I see, you already have the dependency in the `hadoop-project/pom.xml`. I
guess it doesn't get picked up from there during packaging. So my patch is not
quite right either.
ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-966523434
This isn't right, but it's along the path,
```
diff --git a/hadoop-client-modules/hadoop-client/pom.xml
b/hadoop-client-modules/hadoop-client/pom.xml
index dced359b286..
ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-966519014
I think you need to add the otel-agent jar as a dependency to hadoop-common
and exclude it as a dependency from hadoop-client. then it'll show up in
`share/hadoop/common/lib`. T
ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-965717655
@ArkenKiran where do you get the opentelemetry-agent jar for your testing?
I've built this patch and it appears that the agent jar is not included.
```
$ mvn clean inst
ndimiduk commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-964407226
That's great progress, @ArkenKiran ! You got there before I could. On the
read path, any block cache miss will go to the hdfs client for a read (can
still be local via short-cir