[GitHub] [hadoop] omalley commented on a diff in pull request #5138: HDFS-16844: Adds resilancy when StateStore gets exceptions.

omalley commented on code in PR #5138: URL: https://github.com/apache/hadoop/pull/5138#discussion_r1025776365 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/records/MockStateStoreDriver.java: ## @@ -0,0 +1,125 @@ +/* + * Licen

[GitHub] [hadoop] omalley commented on a diff in pull request #5138: HDFS-16844: Adds resilancy when StateStore gets exceptions.

omalley commented on code in PR #5138: URL: https://github.com/apache/hadoop/pull/5138#discussion_r1024567351 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/records/TestRouterState.java: ## @@ -82,4 +96,141 @@ public void test

[GitHub] [hadoop] omalley commented on a diff in pull request #5138: HDFS-16844: Adds resilancy when StateStore gets exceptions.

omalley commented on code in PR #5138: URL: https://github.com/apache/hadoop/pull/5138#discussion_r1024312684 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/records/TestRouterState.java: ## @@ -82,4 +96,141 @@ public void test

[GitHub] [hadoop] omalley commented on a diff in pull request #5138: HDFS-16844: Adds resilancy when StateStore gets exceptions.

omalley commented on code in PR #5138: URL: https://github.com/apache/hadoop/pull/5138#discussion_r1024297499 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/records/TestRouterState.java: ## @@ -82,4 +96,141 @@ public void test

[GitHub] [hadoop] omalley commented on a diff in pull request #5138: HDFS-16844: Adds resilancy when StateStore gets exceptions.

omalley commented on code in PR #5138: URL: https://github.com/apache/hadoop/pull/5138#discussion_r1024296927 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/records/TestRouterState.java: ## @@ -82,4 +96,141 @@ public void test

[GitHub] [hadoop] omalley commented on a diff in pull request #5138: HDFS-16844: Adds resilancy when StateStore gets exceptions.

omalley commented on code in PR #5138: URL: https://github.com/apache/hadoop/pull/5138#discussion_r1024284004 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/CachedRecordStore.java: ## @@ -125,7 +125,6 @@ public boolean loadCac